grafana

Commit Graph

Author	SHA1	Message	Date
Laura Benz	bc9a37ee8d	Glue: Add configuration support to PATCH (#56117 ) * feat: add config to tests v0 * feat: add config to UpdateCorrelationCommand * refactor: repair some tests * refactor: repair another test * refactor: repair last test * refactor: remove possible test * refactor: add comments * refactor: add changes from code review * refactor: implement more detailed patch * feat: add tests for partial config update * refactor: make error handling more detailed Co-authored-by: Giordano Ricci <me@giordanoricci.com> Co-authored-by: Giordano Ricci <me@giordanoricci.com>	3 years ago
George Robinson	802d67eeca	Alerting: Support values in notification templates (#56457 ) We have received a lot of feedback regarding the ValueString in alert notifications. Perhaps one of the most frequent complaints about ValueString is that it is difficult to read because it contains a lot of information, and the information is shown as a JSON-like string. Users have often asked how it can be templated and the answer is that it can't. Until now users have been able to add custom annotations to their alert rules which contains values via the $values variable added in previous versions of Grafana. However, these custom annotations must be added for each of the user's alert rule, instead of once in a template that all of their alerts can be notified via. This commit adds then the much requested feature to support values in notification templates. Users can then create a single template that prints the annotations, labels and values of their alerts in a format of their choice!	3 years ago
Joe Blubaugh	7312a2dab0	Alerting: Mark all tests that interact with the database as Integration tests. (#54875 ) Previously, two tests were not explicitly marked as integration tests and so were not run against all 3 supported databases in the CI environment.	3 years ago
Ryan McKinley	b24be6c0fc	ObjectStore: add a kind registry (#56507 )	3 years ago
Nathan Marrs	ac91df0ea2	Canvas: Add demo dashboards (#56351 ) Co-authored-by: drew08t <drew08@gmail.com> Co-authored-by: Adela Almasan <adela.almasan@grafana.com> Co-authored-by: Ryan McKinley <ryantxu@gmail.com>	3 years ago
Yuriy Tseretyan	3487e68d15	Alerting: Fix migration to create rules with group index 1 (#56511 )	3 years ago
Yuriy Tseretyan	e2f1201382	Alerting: Fix migration to not add label "alertname" (#56509 ) * do not add label alertname because it is overridden in state manager anyway * update state manager to not consider labels with same value as dupe	3 years ago
Artur Wierzbicki	bf264d2f76	Query library: `requiresDevMode` dummy backend (#56466 ) * query library - dummy backend * fix tests * dont explicitly marshall backend dataresponse * skip integration tests * null check for tests * added query library to codeowners * null check for tests * lint	3 years ago
Gabriel MABILLE	7595ed0668	FIX: Remove RBAC datasource permissions upon datasource deletion (#56530 ) * FIX: Remove RBAC datasource permissions upon datasource deletion * Use scope provider instead * Fix test	3 years ago
Joey Tawadrous	74c809f544	Plugins: Introduce new Flame graph panel (#56376 ) * Flamegraph * Updated flame graph width/height values * Fix top table rendering issue * Add feature toggle for flamegraph in explore * Update tests * Hide flamegraph from dash panel viz list if feature toggle not enabled * Show table if no flameGraphFrames * Add flame graph to testdata ds * Minor improvement	3 years ago
George Robinson	762688d67f	Alerting: Fix pq: missing FROM-clause for table "a" (#56453 ) This commit fixes a bug where changing the Folder or Rule Group of an existing rule returns the following error in PostgreSQL "pq: missing FROM-clause for table a"	3 years ago
Joe Blubaugh	13067b39da	Alerting: Update replacement of prometheus-alertmanager (#56519 ) grafana.com/grafana/prometheus-alertmanager has been updated to a version that fixes some bugs upstream. This change just updates that dependency and a few shared ones.	3 years ago
Emil Tullstedt	bb479e030a	RBAC: Redirect to /login when forceLogin is set (#56469 )	3 years ago
Jeff Levin	331110bde5	refactor public dashboards middleware testing (#55706 ) This PR refactors how we add the orgId to the context on a public dashboard paths. We also split out accessToken handling into its own package and rework status code for "RequiresValidAccessToken". We will be modeling all endpoints to use these status codes going forward. Additionally, it includes a scaffold for better middleware testing and refactors existing tests to table drive tests.	3 years ago
Ryan McKinley	609abf00d1	ObjectStore: Write json as json when possible (#56433 )	3 years ago
Yuriy Tseretyan	7b6437402a	Alerting: Refactor state manager's cache (#56197 ) * remove ResetAllStates because it's not used * refactor cache to accept logs, metrics and url as method args * update manager Warm method to set the entire state at once * remove unused reset method * introduce ruleStates * change getOrCreate to belong to ruleStates * update Get to not return error	3 years ago
Matias Chomicki	729ce8bb72	Loki: query editor using Monaco (#55391 ) * loki: switch to a monaco-based query field, step 1 (#46291) * loki: use monaco-logql (#46318) * loki: use monaco-logql * updated monaco-logql * fix all the tests (#46327) * loki: recommend parser (#46362) * loki: recommend parser * additional improvements * more improvements * type and lint fixes * more improvements * trigger autocomplete on focus * rename * loki: more smart features (#46414) * loki: more smart features * loki: updated syntax-highlight version * better explanation (#46443) * better explanation * improved help-text Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com> Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com> * Fix label * feat(loki-monaco-editor): add monaco-logql as a dependency * feat(loki-monaco-editor): add back range function removed during merge * feat(loki-monaco-editor): sync imports with recent changes * feat(loki-monaco-editor): add missing lang provider functions * feat(loki-monaco-editor): fix imports * feat(loki-monaco-editor): display monaco editor by default Temporarily * Chore: remove commented code * Chore: minor refactor to NeverCaseError * Chore: minor code cleanups * feat(loki-monaco-editor): add history implementation Will see how it behaves and base the history slicing on tangible feedback * feat(loki-monaco-editor): turn completion data provider into a class * Chore: fix missing imports * feat(loki-monaco-editor): refactor data provider methods Move complexity scattered everywhere to the provider * Chore: clean up redundant code * Chore: minor comments cleanup * Chore: simplify override services * Chore: rename callback * feat(loki-monaco-editor): use query hints implementation to parse expression * feat(loki-monaco-editor): improve function name * Chore: remove superfluous variable in favor of destructuring * Chore: remove unused imports * Chore: make method async * feat(loki-monaco-editor): fix deprecations and errors in situation * feat(loki-monaco-editor): comment failing test case * Chore: remove comment from test * Chore: remove duplicated completion item * Chore: fix linting issues * Chore: update language provider test * Chore: update datasource test * feat(loki-monaco-editor): create feature flag * feat(loki-monaco-editor): place the editor under a feature flag * Chore: add completion unit test * Chore: add completion data provider test * Chore: remove unwanted export * Chore: remove unused export * Chore(loki-query-field): destructure all props * chore(loki-completions): remove odd string * fix(loki-completions): remove rate_interval Not supported * fix(loki-completions): remove line filters for after pipe case We shouldn't offer line filters if we are after first pipe. * refactor(loki-datasource): update default parameter * fix(loki-syntax): remove outdated documentation * Update capitalization in pkg/services/featuremgmt/registry.go Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com> * refactor(situation): use node types instead of names * Chore: comment line filters pending implementation It's breaking the build due to a linting error. * Chore: update feature flag test after capitalization change * Revert "fix(loki-completions): remove line filters for after pipe case" This reverts commit `3d003ca4bc`. * Revert "Chore: comment line filters pending implementation" This reverts commit `84bfe76a6a`. Co-authored-by: Gábor Farkas <gabor.farkas@gmail.com> Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com> Co-authored-by: Ivana Huckova <ivana.huckova@gmail.com>	3 years ago
Torkel Ödegaard	9300ae7ce6	NavTree: Don't add license and stats page unless your a Grafana Admin (#56410 )	3 years ago
Levente Balogh	55187ebc48	Navtree: Make it possible to configure standalone plugin pages (#56393 ) * feat: make it possible to register standalone app plugin pages under different sections * refactor(sample.ini): use "admin" instead of "starred" section in the INI Co-authored-by: Torkel Ödegaard <torkel@grafana.com> * feat(defaults.ini): add app navigation settings to the defaults.ini as well * fix: use the correct key in the tests Co-authored-by: Torkel Ödegaard <torkel@grafana.com>	3 years ago
Joe Blubaugh	b476ae62fb	Alerting: Write and Delete multiple alert instances. (#55350 ) Prior to this change, all alert instance writes and deletes happened individually, in their own database transaction. This change batches up writes or deletes for a given rule's evaluation loop into a single transaction before applying it. These new transactions are off by default, guarded by the feature toggle "alertingBigTransactions" Before: ``` goos: darwin goarch: arm64 pkg: github.com/grafana/grafana/pkg/services/ngalert/store BenchmarkAlertInstanceOperations-8 398 2991381 ns/op 1133537 B/op 27703 allocs/op --- BENCH: BenchmarkAlertInstanceOperations-8 util.go:127: alert definition: {orgID: 1, UID: FovKXiRVzm} with title: "an alert definition FTvFXmRVkz" interval: 60 created util.go:127: alert definition: {orgID: 1, UID: foDFXmRVkm} with title: "an alert definition fovFXmRVkz" interval: 60 created util.go:127: alert definition: {orgID: 1, UID: VQvFuigVkm} with title: "an alert definition VwDKXmR4kz" interval: 60 created PASS ok github.com/grafana/grafana/pkg/services/ngalert/store 1.619s ``` After: ``` goos: darwin goarch: arm64 pkg: github.com/grafana/grafana/pkg/services/ngalert/store BenchmarkAlertInstanceOperations-8 1440 816484 ns/op 352297 B/op 6529 allocs/op --- BENCH: BenchmarkAlertInstanceOperations-8 util.go:127: alert definition: {orgID: 1, UID: 302r_igVzm} with title: "an alert definition q0h9lmR4zz" interval: 60 created util.go:127: alert definition: {orgID: 1, UID: 71hrlmR4km} with title: "an alert definition nJ29_mR4zz" interval: 60 created util.go:127: alert definition: {orgID: 1, UID: Cahr_mR4zm} with title: "an alert definition ja2rlmg4zz" interval: 60 created PASS ok github.com/grafana/grafana/pkg/services/ngalert/store 1.383s ``` So we cut time by about 75% and memory allocations by about 60% when storing and deleting 100 instances.	3 years ago
Ryan McKinley	b4e23e5d32	ObjectStore: update dev protobuf definitions (#56428 )	3 years ago
juanicabanas	69c49f6ba2	PublicDashboards: Make mixed datasource calls concurrently (#56421 ) PublicDashboards: Make mixed datasource calls concurrently	3 years ago
Alexander Weaver	8df830557a	Alerting: Move annotation functionality behind a history persistence interface (#56133 ) * Move annotation functionality behind a history persistence interface * Rename to RecordState * Fix lint error in import aliasing * One more import linter error	3 years ago
Ryan McKinley	97d19830cf	ObjectStore: rename modified to updated (#56420 )	3 years ago
Artur Wierzbicki	a94acb7f61	Object store: get user from context (#56346 ) * GRPC Server: Add signedInUser to context after auth * add permissions to signedInUser * add access control permissions test * add additional signedInUser checks * get user from context * move `UserFromContext` to object/auth.go Co-authored-by: Todd Treece <todd.treece@grafana.com>	3 years ago
idafurjes	bc7a383252	Remove org methods from sqlstore interface (#56358 ) * Remove org methods from sqlstore interface * Remove some mocks * Fix some tests	3 years ago
Yuriy Tseretyan	ad2a1dd680	Alerting: Start ticker only when scheduler starts (#56339 )	3 years ago
Tania	222c33c307	Remove branding feature toggle (#56379 )	3 years ago
Torkel Ödegaard	aa274500cf	TopNav: Fixes to page and plugin page handling (#56278 ) * Added labels * App page fixes * Switch to switch * Fixing sort position for Apps	3 years ago
Levente Balogh	ae5e8bc53b	refactor: rename Data Connections to Connections (#56353 )	3 years ago
idafurjes	5167c55760	Chore: Move methods from sqlstore to user store (#56305 ) * Copy sqlstore methods to suer store * Adjust ProvideService signatures in test * Add xorm tags and tests for search * Remove methods from sqlstore * fix lint in tests	3 years ago
Todd Treece	4163f31d76	GRPC Server: Add signedInUser to context (#56059 )	3 years ago
sam boyer	ba97b268d0	Playlist: Split PlaylistItem into standalone TS type (#56343 ) * playlist: Split PlaylistItem into standalone TS type * update playlist model * actually set the title Co-authored-by: Ryan McKinley <ryantxu@gmail.com>	3 years ago
Ryan McKinley	4fc9b9aa35	Storage: Cleanup object history API (#56215 )	3 years ago
Kat Yang	7715672fb3	Chore: use org service methods (#55768 ) * Chore: use org service methods * fix tests * fix errors * adjust func signatures for getbyname * 💩 * Use the same fake service to get the user in AC and in HS * Fix middleware test * Fix more middleware test * Fix api tests Co-authored-by: gamab <gabi.mabs@gmail.com> Co-authored-by: Ida Furjesova <ida.furjesova@grafana.com>	3 years ago
Ryan McKinley	d5e2713168	Storage: Add HTTP endpoint for object store service (#56214 )	3 years ago
Ryan McKinley	3b1a8d45ed	Playlist: update service so it supports both read+write (#55959 )	3 years ago
idafurjes	a25516fbe3	Chore: Copy sqlstore methods to user store (#56280 ) * Chore: Copy sqlstore methods to user store * Fix xorm tag * Add tests * Remove unused methods from sqlstore	3 years ago
Todd Treece	2d433194d0	GRPC Server: Add tracing interceptors (#56045 ) Co-authored-by: Artur Wierzbicki <artur.wierzbicki@grafana.com>	3 years ago
idafurjes	a863a4d95d	Chore: Copy user methods over to user store (#56000 ) * Chore: Copy user methods over to user store * Fix some tests and bugs * Add some more tests * Move tests to user store * Move back the tests * Add some tests	3 years ago
Giordano Ricci	489b302c03	Glue: Correlations minor APIs behavior improvements (#56078 ) * add correlation config type, CorrelationConfig validator & default values * make config required when creating correlations * make targetUID optional, add validation for createCommand & configType * fix tests * update remaining tests * fix lint error * Update pkg/services/correlations/models.go Co-authored-by: Piotr Jamróz <pm.jamroz@gmail.com> * update docs Co-authored-by: Piotr Jamróz <pm.jamroz@gmail.com>	3 years ago
Ashley Harrison	8984507291	Navigation: show breadcrumbs correctly when on the home page (#55759 ) * show breadcrumbs correctly when on the home page * adjust breadcrumb unit tests * update betterer * fix backend tests * update getSectionRoot to look at the home nav id * remove redundant setting of home dashboard * construct a home navmodelitem in the backend * fix cases when the feature toggle is off * fix unit test * fix more unit tests * refactor how buildBreadcrumbs works * use HOME_NAV_ID * move homeNav useSelector into NavToolbar * remove unnecesary cloneDeep * don't need locationUtil here * restore using getUrlForPartial in DashboardPage * special case for the editview query param * remove commented out code * add comment to clarify splice behaviour * slightly cleaner syntax	3 years ago
Santiago	09f8e026a1	Alerting: Expose info about notification delivery errors in a new /receivers endpoint (#55429 ) * (WIP) switch to fork AM, first implementation of the API, generate spec * get receivers avoiding race conditions * use latest version of our forked AM, tests * make linter happy, delete TODO comment * update number of expected paths to += 2 * delete unused endpoint code, code review comments, tests * Update pkg/services/ngalert/notifier/alertmanager.go Co-authored-by: Matthew Jacobson <matthew.jacobson@grafana.com> * remove call to fmt.Println * clear naming for fields * shorter variable names in GetReceivers Co-authored-by: Matthew Jacobson <matthew.jacobson@grafana.com>	3 years ago
Ashley Harrison	3e688ecf7d	Navigation: remove `description` from the backend navmodel and use `subTitle` instead (#56155 ) * remove description from the backend navmodel and use subTitle instead * only add admin subtitle in topnav	3 years ago
Eric Leijonmarck	f7de253cdd	fix: remove permission grouping (#56157 )	3 years ago
Ryan McKinley	385ebea540	Devenv: move timeseries dashboards to a timeseries folder (#56131 )	3 years ago
Artur Wierzbicki	85b965cbec	Storage: Dummy object server and basic integration tests (#56014 ) * object extractors * update bluge to use summary values * gosec * move to store/object package * references * references * references * same thign but with protobuf * now the service * now with summary * now with summary * from protobuf * from protobuf * cleanup * remove hand crafted file * update proto definitions * update comments * remove properties * remove properties * re-generate * add batch * move ref to raw struct * GRPC test infra * fix merge * add delete * lint * rename to dummyobjectserver * update comment * refactor collection, simplify dummy server * update * refactor test structure * more tests * more tests * replace collection with infra/persistentcollection * skip if not integration test suite * very important lint fix Co-authored-by: Ryan McKinley <ryantxu@gmail.com>	3 years ago
Ryan McKinley	268a49cb38	Devenv: add dashboard showing timeseries out of range points (#56130 )	3 years ago
Alexander Weaver	c16317e5b8	Alerting: Move fake rule store to the test utilities package (#56062 ) * Move fakeRuleStore to tests/fakes package * Break stub dependencies on store * Update existing tests to point to new location * Remove unused stub of TimeNow * Rename fake to take advantage of package name	3 years ago
sam boyer	9ec7b202b6	playlist: introduce coremodel schema, swap in for backend DTO types (#56048 ) * Add simplest possible playlist schema * Add @grafana(decisionNeeded) attributes * playlistid, not playlist_id	3 years ago

1 2 3 4 5 ...

4329 Commits (efed72096f1634b24885b0fb9d4b1b75ac9faa96)