grafana

Commit Graph

Author	SHA1	Message	Date
mikkancso	06f4cc0880	Admin/Plugins: Set category filter in connections link (#64393 ) set category filter in connections link	2 years ago
mikkancso	913cb17eac	Connections: Fix minor issues around Your connections/Data sources page (#63801 ) * Connections: redirects to data sources If Data sources page is the only child of Your connections, then the NavLandingPage doesn't really make sense. * DataSourcesList: do not show add button twice If there are no data sources configured, then the DataSourcesList page shows a large CTA to add a data source. Therefore, the add new data source button in the header is redundant, let's remove it from there in this case. * DataSources: redirect to Connections after delete The primary place of the DataSourceList page is under Connections, provided that the `dataConnectionsConsole` feature is turned on. Therefore, let's redirect there after deleting a data source.	2 years ago
Levente Balogh	cf650c9349	Connections: Fix route-guards (#62771 ) * fix: use case-sensitive routes for Connections The reason to do this is to have the backend route-guards work properly. (The backend route guards are case-sensitive, thus if the FE would serve the case-insensitive version, then the backend route guards could be bypassed.) * tests: update the tests	2 years ago
Torkel Ödegaard	b8e7ef48d0	AppChrome: Unify logic for chromeless pages that should not have NavBar, CommandPalette, Search etc (#62281 ) * Keybindings: No global keybindings on chromeless pages * simplify condition * Refactoring * Align name and file * Move logic into AppChrome * minor fix * Update Page.tsx * Fixing test * Fixed tests * More fixes * Fixed more tests * Fixing final test * Fixed search in old nav	2 years ago
Gilles De Mey	702fd0f9e8	Docs: Update wording / text and copy (#61868 ) Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com>	2 years ago
Levente Balogh	cc502bbfbd	Connections: update the style of the cards (#61989 )	2 years ago
Levente Balogh	4def287e62	Connections: Show the Dashboards tab under DataSource settings (#61841 ) * fix: use the correct URL for editing datasource dashboards * feat: show the Datasource/Dashboards page under Connections as well * refactor: remove unnecessary `useNavModel()` utility * feat: add a utility for creating the nav-model for DS settings tabs * refactor: use nav-model crating utility in Edit Datasource	2 years ago
Levente Balogh	9d4e940097	Connections: Don't use `gridSize` directly in styling (#61684 ) refactor: don't use gridSize directly	2 years ago
Levente Balogh	4ef82dc73f	Connections: Show a "No access" modal if the user has no permissions (#61397 ) * feat: add a new modal for displaying no-access info * feat(CardGrid): add an onClick handler for items * feat: open a no-access modal when clicking on a connection in the catlog * feat: update permissions Open a "No access" modal when the user clicks a connection type but has no permissions creating a datasource out of it * test: add tests for opening the No Access modal * test: fix the user permissions in tests * Wip * Revert "Wip" This reverts commit `7f080c7f77`.	2 years ago
Ana Ivanov	24ef778f4d	Connect Data: Make search bar sticky (#61529 )	2 years ago
Levente Balogh	8b290bba55	Connections: Update redirect alert message (#61152 ) * fix(Alert): don't add padding to content when there is no title * Feat(Connections): update the style and wording of the redirect alert * fix(UI/Alert): more resilient check for has title	2 years ago
Levente Balogh	6b2394eff1	Connections: Make "Connect data" a section title (#61144 ) * Wip * Fix: change tests to cater for the new scenario * feat(Connections): redirect to "Your connections / Datasources" if cannot admin plugins	2 years ago
mikkancso	8e8f498674	Connections: Add redirect notice for datasources and plugins pages (#61037 ) * add redirect notice for datasources and plugins pages * do not depend on the internal implementation of Alert The deleted css piece was problematic because it relied on the internals of Alert. If we don't remove that padding, then the Alert looks a bit off, so I added some title to the Alert to look better. This way the Connections LinkButton is not vertically aligned to the center, but this is the closest we can get to the designed alert without doing hacks and reimplementing the Alert component.	2 years ago
mikkancso	0adcdae325	Connections: Show only data source plugins on Connect Data page (#60523 ) show only data source plugins on connect data page We intended to show only data source plugins on this page, but this filter was missing until now.	2 years ago
mikkancso	899b035087	Connections: Update datasource details url (#60521 ) update datasource details url My ultimate goal is to make the cloud-onboarding plugin link to datasource details page inside Connections. I tried to do that, so that it linked to `/connections/connect-data/datasources/:id`, but it didn't work. Details below: We have a problem with the datasources details page url: If the plugin is not present, then the `/connections/connect-data/datasources/:id` url is finely served by Grafana. However, when the plugin is present, we register a Route entry like this: `<Route exact=false path='/connections/connect-data' component={AppPlugin} />` And this entry will be higher in the routes list than the datasources Route. This means that every path under `/connections/connect-data` will be served by the plugin. That's why exact is false. Otherwise the plugin couldn't serve integrations details at `connect-data/infrastructure/:id`. So `exact=false` is needed. What can we do? 1. Put Grafana's Connection routes higher in the list of routes. 2. Find a different URL for datasources details page Unfortunately, we can't do 1., because: Routes roughly look like this (in this order): - exact: false, path: connections/connect-data, component: AppPlugin - exact: false, path: connections/your-connections/infrastructure, component: AppPlugin - exact: false, path: connections, component: Connections So if a request comes for `/connections` or `/connections/your-connections` or `/connections/your-connections/datasources`, it will be served by Connections. Therefore, we can't really put the route for Connections higher in the list of routes, because then it will match all routes beginning with `/connections`, and the plugin's routes will have no effect. So the only alternative left is to find another path :/ Since we set the DataSourceDetailsPage's navId explicitly to `connections-connect-data`, the breadcrumbs will continue to show the data source page as a child item of the Connect Data page :)	2 years ago
mikkancso	e4d4eacd36	Connections: Render a landing page for pages without actual content (#60369 ) * render a landing page for pages without actual content To be consistent with other pages in Grafana * update tests	2 years ago
mikkancso	edb86d4bf3	DataSources: fix DataSourceAddButton component (#60176 ) * fix DataSourceAddButton component This component implicitly returned `false` when `canCreateDataSource` was false, and that way it didn't qualify as a function component. We fixed it to explicitly return null in this case. * DataSourceAddButton: update function signature This is more consistent with other code in this codebase.	2 years ago
Ashley Harrison	3a5c3b517c	Navigation: conditionally use actions in `DataSourceListPage` (#60300 ) * conditionally use actions in DataSourceListPage * fix unit tests	2 years ago
mikkancso	c72322874d	Connections: Update "Your connections/Data sources" page (#58589 ) * navtree.go: update Data sources title and subtitle * DataSourceList: move add button to header * DataSourcesList: add buttons to items The action buttons are added inside `<Card.Tags>` so that they end up at the right end of the card, as it was designed. The "Build a Dashboard" button's functionality is not defined yet. * DataSourcesListHeader: add sort picker * fix css * tests: look for the updated "Add new data source" text * tests: use an async test method to verify component updates are wrapped in an act() * update e2e selector for add data source button * fix DataSourceList{,Page} tests * add comment for en dash character * simplify sorting * add link to Build a Dashboard button * fix test * test build a dashboard and explore buttons * test sorting data source elements * DataSourceAddButton: hide button when user has no permission * PageActionBar: remove unneeded '?' * DataSourcesList: hide explore button if user has no permission * DataSourcesListPage.test: make setup prop explicit * DataSourcesList: use theme.spacing * datasources: assure explore url includes appSubUrl * fix tests and add test case for missing permissions Co-authored-by: Levente Balogh <balogh.levente.hu@gmail.com>	3 years ago
Levente Balogh	778fb07464	Plugins: Make the Plugin Details page reusable (#58741 ) * refactor(PluginDetails): use react-router hooks instead of props * Wip * refactor: remove unnecessary constant * feat: use the original plugin details page under connections * chore: use better wording in the not-found warning Co-authored-by: Jack Westbrook <jack.westbrook@gmail.com> * chore: use the renderer utility everywhere in the test * chore: don't show a title while loading a plugin Co-authored-by: Jack Westbrook <jack.westbrook@gmail.com>	3 years ago
lean.dev	83bd57244d	Chore: Update version (#58750 )	3 years ago
Levente Balogh	181640b080	Connections: Support standalone plugin pages (#57772 ) * feat(Connections): create sub-pages wrapped by `<Page>` * feat(Connections): rename the Connections page and update routes * feat(Connections): use new url for editing datasources * refactor(Connections): remove unused tab components * feat(Connections): update routes and nav titles * tests: fix tests for Connections * tests: fix typo in backend tests	3 years ago
kay delaney	a8c181bf6a	Chore: Migrate usage of v1 theme to v2 (#58154 )	3 years ago
mikkancso	a4e66a2a01	Connections: New "Connect data" page with data source catalog (#56772 ) * remove Plugins and CloudIntegrations tab and add ConnectData tab * ConnectData: add Search component and use it * ConnectData: add DataSourcePluginList component * add CardGrid component * add CategoryHeader component * ConnectData: restructure content DataSourcePluginList is removed, because its responsibilities are actually the same as ConnectData's responsibilities. NoResults was added as a reusable component, and was moved out of CardGrid, since there could be more CardGrid on one page, but only one NoResults. * fix spacer * use LoadingPlaceholder * CardGrid: add margin * generalize CardGridProps * move isLoading and error into CardGrid We'd like CardGrid to be reusable, even multiple times within a page. In this case, it's better UX if we show the loading or error states per card grid, not for the whole page. * ConnectData: fix NoResults condition * fix and add meaningful tests * fix indentation * move isLoading and error back to ConnectData * make `url` required for CardGrid items	3 years ago
Levente Balogh	ae5e8bc53b	refactor: rename Data Connections to Connections (#56353 )	3 years ago

25 Commits (f23c8e5cd1d890c309e661b8d139b222b13fc787)