grafana

Commit Graph

Author	SHA1	Message	Date
Piotr Jamróz	b64802ed3b	Correlations: Add error logging (#78272 ) * Add error logging when parsing correlations * Make orgId optional * Add module property and move source and target to context for better readability	1 year ago
Piotr Jamróz	64d05e009a	Correlations: Ensure datasource uid property exists when a link is created (#78167 ) Ensure datasource uid property exists	2 years ago
Khushi Jain	f41f939c1c	i18n: Markup up correlations forms for translations (#75264 ) * correlations/forms * Update public/app/features/correlations/Forms/ConfigureCorrelationBasicInfoForm.tsx Co-authored-by: Josh Hunt <joshhunt@users.noreply.github.com> * Update public/app/features/correlations/Forms/ConfigureCorrelationBasicInfoForm.tsx Co-authored-by: Josh Hunt <joshhunt@users.noreply.github.com> * Update public/app/features/correlations/Forms/ConfigureCorrelationBasicInfoForm.tsx Co-authored-by: Josh Hunt <joshhunt@users.noreply.github.com> * Update public/app/features/correlations/Forms/ConfigureCorrelationBasicInfoForm.tsx Co-authored-by: Josh Hunt <joshhunt@users.noreply.github.com> * Added rest of filed * minor-changes * map function * retriggered * Update public/app/features/correlations/Forms/TransformationsEditor.tsx Co-authored-by: Piotr Jamróz <pm.jamroz@gmail.com> * removed whitespace * removed whitespace * more changes --------- Co-authored-by: Josh Hunt <joshhunt@users.noreply.github.com> Co-authored-by: Piotr Jamróz <pm.jamroz@gmail.com>	2 years ago
Piotr Jamróz	b7f854a06c	Correlations: Fix incorrect state transitions in transformations editor (#77434 ) * Extract transformations editor row to a seprate component * Use css object instead of string literals * Update .betterer.results * Post merge fixes * Bring back validation rules * Switch to css/object * Post-merge fixes Ensuring Stack from grafana-ui is used after conflicts with `25779bb6e5`	2 years ago
Alex Khomenko	25779bb6e5	Stack: Use the component from grafana/ui (#77543 ) * grafana/ui: Move Stack out of unstable * grafana/ui: Replace imports * Replace the import from experimental * Cleanup * Remove invalid prop * Add flexGrow * Remove Stack used in Field * Remove import	2 years ago
Kristina	9e0ca0d113	Correlations: Add transformations to Explore Editor (#75930 ) * Add transformation add modal and use it * Hook up saving * Add transformation vars to var list, show added transformations * Form validation * Remove type assertion, start building out transformation data in helper (WIP) * Style expression better, add delete logic * Add ability to edit, additional styling on transformation card in helper * simplify styling, conditionally run edit set up logic * Keep more field information in function, integrate it with new editor * Show default label on collapsed section, use deleteButton for confirmation of deleting transformations * Change transformation add calculations from function to hook, add label to collapsed header, add transformation tooltip * Make correlation and editor dirty state distinctive and integrate, WIP * Track action pane for more detailed messaging/actions * Better cancel modal logic * Remove changes to adminsitration transformation editor * Remove debugging line * Remove unneeded comment * Add in logic for closing editor mode * Add tests for modal logic * Use state to build vars list for helper * WIP * Fix labels and dirty state * Fix bad message and stop exiting mode if discard action is performed * Fix tests * Update to not use unstable component and tweak default label	2 years ago
Ashley Harrison	07cc7504ee	Icon: Simplify and remove wrapping `<div>` (#76819 ) * remove wrapping div * update tests, just gotta figure out how to handle fontawesome :( * add spinner.svg which matches the font-awesome spinner * add mock for react-inlinesvg * update mock and fix some tests * fix FormField test * fix CorrelationsPage tests * increase timeout	2 years ago
Kristina	4b3d63dcdc	Correlations: Add an editor in Explore (#73315 ) * Start adding correlations editor mode * Add selector for merge conflict resolution * Enable saving * Build out new corelation helper component * flesh out save with label/description, change color * Have breadcrumb exit correlation editor mode * Add extension property to show/hide, use it for correlations * Bring in feature toggle * Remove unnecessary param * Cleanup * Parse logs json * Work on correlation edit mode bar * Tinker with a top element for the editor mode * Handle various explore state changes with correlations editor mode * WIP - add unsaved changes modal * Have correlation bar always rendered, sometimes hidden * Add various prompt modals * Clear correlations data on mode bar unmount, only use not left pane changes to count as dirty * Move special logic to explore * Remove all shouldShow logic from plugin extensions * remove grafana data changes * WIP - clean up correlations state * Interpolate data before sending to onclick * Override outline button coloring to account for dark background * More cleanup, more color tweaking * Prettier formatting, change state to refer to editor * Fix tests * More state change tweaks * ensure correlation save ability, change correlation editor state vars * fix import * Remove independent selector for editorMode, work close pane into editor exit flow * Add change datasource post action * Clean up based on PR feedback, handle closing left panel with helper better * Remove breadcrumb additions, add section and better ID to cmd palette action * Interpolate query results if it is ran with a helper with vars * Pass the datasource query along with the correlate link to ensure the datasource unique ID requirement passes * Use different onmount function to capture state of panes at time of close instead of time of mount * Fix node graph’s datalink not working * Actually commit the fix to saving * Fix saving correlations with mixed datasource to use the first query correlation UID * Add tracking * Use query datasources in mixed scenario, move exit tracking to click handler * Add correlations to a place where both can be used in the correlations editor * Be more selective on when we await the datasource get * Fix CSS to use objects * Update betterer * Add test around new decorator functionality * Add tests for decorate with correlations * Some reorganization and a few tweaks based on feedback * Move dirty state change to state function and out of component * Change the verbiage around a little * Various suggestions from Gio Co-authored-by: Giordano Ricci <me@giordanoricci.com> * More small Gio-related tweaks * Tie helper data to datasource - clear it out when the datasource changes * Missed another Gio tweak * Fix linter error * Only clear helper data on left pane changes * Add height offset for correlation editor bar so it doesn’t scroll off page --------- Co-authored-by: Piotr Jamróz <pm.jamroz@gmail.com> Co-authored-by: Giordano Ricci <me@giordanoricci.com>	2 years ago
Khushi Jain	b75c7b4c49	i18n: Markup CorrelationsPage for translations (#74892 ) * i18n: Translations under features/correlations * more changes * add links * add changes * changes * changes	2 years ago
Piotr Jamróz	946da57b6a	Correlations: Allow creating correlations for provisioned data sources (#73737 ) * Allow creating correlations for provisioned data sources * Update docs * Fix linting * Add missing props * Add missing props * Fix linting * Fix linting * Clarify error name * Removed error handling for a non-existing use case * Create a list of deleted data datasources based on all configs * Add org_id to correlations * Add tests * Allow org_id to be null in case org_id=0 is used * Create organization to ensure stable id is generated * Fix linting * Ensure backwards compatibility * Add deprecation information * Update comments * Override existing datasSource variable so the UID is retrieved correctly * Migrate correlations indices * Default org_id when migrating * Remove redundant default * Make PK non-nullable * Post merge fixes * Separate data sources / correlations provisioning * Adjust comments * Store new data sources in spy store so it can be used to test correlations as well * Fix linting * Update tests * Ensure response is closed * Avoid creating duplicates during provisioning * Fix updating provisioned column and update tests * Rename error message * Fix linting errors * Fix linting errors and rename variable * Update test * Update pkg/services/sqlstore/migrations/correlations_mig.go Co-authored-by: Giordano Ricci <me@giordanoricci.com> * Remove unused error * Fix lining --------- Co-authored-by: Giordano Ricci <me@giordanoricci.com>	2 years ago
Ivan Ortega Alba	8415dd40d7	DSPicker: Use new DS picker everywhere in Grafana (#70609 )	2 years ago
Ashley Harrison	9852b24d61	Chore: Upgrade prettier to v3 (#71764 ) * Update dependency prettier to v3 (#71586) * Update dependency prettier to v3 * run prettier * ignore prettier update in legacy select scss * update command line arg --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com> * unplug prettier --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>	2 years ago
Ashley Harrison	5ca382c88a	Revert "Update dependency prettier to v3 (#71586 )" (#71755 ) This reverts commit `2e8cd1c021`.	2 years ago
renovate[bot]	2e8cd1c021	Update dependency prettier to v3 (#71586 ) * Update dependency prettier to v3 * run prettier * ignore prettier update in legacy select scss * update command line arg --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>	2 years ago
Kristina	b6fbf307d9	Explore: Add checking for target datasources and add test (#70855 ) Add checking for target datasources and add test	2 years ago
Kristina	f18a02149a	Correlations: Create paginated API (#65241 ) * Add pagination params and apply to sql * Create getCorrelationsResponse that returns metadata * Set up pagination, change correlations fetch to only get source datasource correlations * Move correlations from root to pane, only fetch correlations for one datasource when initialized or datasource is changed * Fix tests * Fix remaining tests * Use functional component to handle state * Remove unneeded mocks, fix tests * Change perPage to limit * Fix Go Tests * Fix linter * Remove parameter * Account for mixed datasources * Delete unused hook * add source UID filter to API, start backing out front end hook changes * add source IDs to API, use when loading or changing datasource * Fix prettier * Mock correlations response * Get correlations for all datasources in mixed scenario * Add documentation for new parameters * Attempt to fix swagger * Fix correlations page * add swagger and openapi docs * Add mocks to failing test * Change API for consistency, remove extra hooks and unused function * Add max to limit and re-gen api docs * Move the page to the previous page if deleting all the rows on the page * Only fetch if remove does not have value * Change page to a reference hook * Fix documentation, a test and some logic thinking page could be 0	2 years ago
Kristina	2738a3a6da	Correlations: Account for restricted datasource (#70717 ) * Account for restricted datasource * Allow for fetching datasource to return undefined and beef up filtering after to remove invalid datasources * Revert "Account for restricted datasource" This reverts commit `1087159b93`. * Empty-Commit	2 years ago
Kristina	3850f7b334	Correlations: UX updates (#69313 ) * Round 1 * Add comma * Remove validate query from editor * Slightly change headings * Change text	2 years ago
Laura Benz	24502c4c4a	Add tooltip to instances of IconButton (#68880 ) * refactor: tooltip is required * refactor: add tooltips * refactor: add tooltips * refactor: add tooltips * refactor: add tooltips * refactor: add tooltips * refactor: add tooltips * refactor: adjust tests * refactor: apply changes from code review * refactor: adjust component for e2e test * refactor: adjust fallback * refactor: apply changes from code review * refactor: apply changes from code review * refactor: set IconButton default as type=button and remove from use cases * refactor: remove aria-labels when duplicated and type=button from use cases * refactor: clean up * refactor: fix tests * refactor: fix type errors * refactor: remove changes in order in order to add them to a separate PR * refactor: set IconButton default as type=button * refactor: remove tooltip * refactor: apply changes requested in review	2 years ago
Kristina	0db397b8be	Correlations: Enable traceView formatted links (#67160 ) * Enable correlations links for traceView formatted fields * Add other links to the span UI * Show both “legacy” and dataframe links * bandaid test * Remove special path logic, stringify all non strings before applying regex * Fix test * Do not create new instance of factory for every call, change header to correlations * Get links from more than one field * Remove categories * Fix google cloud link tests * Add test for multiple internal links * Remove changes to datasources provisioning * Added sorting, changed log link title	2 years ago
Kristina	80162146a0	Correlations: Add links to prometheus dataframe where labels are split out (#67736 ) Add links to prometheus dataframe where labels are split out	2 years ago
Kristina	9d69d3173f	Correlations: Add transformation editor (#66217 ) * There was an attempt * Change disabled state based on transformation type * Add validation to transformation type * Revert "Add validation to transformation type" This reverts commit 2188a3d9a93aec5eeafcdd40510391ba1a53671a. * Add validation to transformation type * Move transformations editor to a separate file * Make name more descriptive * Ensure type dropdown has always the same width * Add tooltips around transformation options * Slight style changes * Remove autofocus on append, integrate read only to transformationeditor, save values that disappear so they come back * Remove yaml changes * Have variable background color work with alternating colors on different themes * Make expression required for regular expressions * Remove unused empty form object * Fix bug about transformation’s values saved in memory * Better validation formatting for expression * Add labels and (for now) non working test, attempt to fix saved transformation delete/add bug * Fix datalink comment * Remove fancy CSS due to background change * Fix deleting saved transformation bug, finish tests * Consolidate transformation types * Double check aria labels * Change aria labels, fix tests * Add a transformation with the create correlation test --------- Co-authored-by: Piotr Jamróz <pm.jamroz@gmail.com>	2 years ago
Ashley Harrison	4abe0249ba	Chore: Clean up old navigation (#66287 ) * remove code outside of the topnav feature flag * delete NavBar folder * remove topnav toggle from backend * restructure AppChrome folder * fix utils mock * fix applinks tests * remove tests since they're covered in e2e * fix 1 of the approotpage tests * Fix another dashboardpage test * remove reverse portalling + test for plugins using deprecated onNavChanged method * kick drone * handle correlations	2 years ago
Torkel Ödegaard	4796a63554	InteractiveTable: Updated design and minor tweak to Correlactions page (#66443 ) * InteractiveTable: Updated design * Fix css issue * Fixed test * Removed leftover	2 years ago
Piotr Jamróz	92b69dfb97	Correlations: Track completion rate for adding correlations (#66361 ) Track completion rate for adding correlations	2 years ago
Piotr Jamróz	4e14224669	Correlations: Fix parsing create/update response (#66193 ) * Fix parsing create/update response * Make types more explicit	2 years ago
Piotr Jamróz	423abe3cea	Correlations: Show variables used in the target query (#66009 ) * Show variables used in the target query * Remove redundant dot * Add usage stats about correlations * Revert "Add usage stats about correlations" This reverts commit `6f0c70084a`.	2 years ago
Piotr Jamróz	90b15d41bf	Correlations: Don't show Add button in empty call-to-action page when user has no sufficient permissions (#66006 ) Do not show add correlation button if user has no permissions to add new correlations	2 years ago
Piotr Jamróz	383148bcd1	Glue: Fix creating duplicated data links created by Correlations (#65490 ) * Ensure correlations do not create duplicated data links * Remove correlation links before processing each correlation * Improve test coverage	2 years ago
Piotr Jamróz	b033fe8d73	Glue: Split correlations editor into 3 steps (#64818 ) * Create simple Wizard for Correlations editor * Allow using custom navigation in the wizard * Update types * Add more info * Add comments * Update comments * Remove main info box to avoid having too many info boxes * Fix CorrelationsPage.test.tsx * Add Wizard test * Simplify Correlations wizard * Make expected typing error more explicit * Don't use meaningless defaults	2 years ago
Ashley Harrison	b19f7bb653	Chore: update more unit tests to work with react 18 (#64812 ) update more unit tests to work with react 18	2 years ago
Ashley Harrison	e0e6165f70	Chore: adjust more unit tests to work with react 18 (#64759 ) adjust unit tests to work with react 18	2 years ago
Kristina	06dfe2156f	Explore: Add transformations to correlation data links (#61799 ) * bring in source from database * bring in transformations from database * add regex transformations to scopevar * Consolidate types, add better example, cleanup * Add var only if match * Change ScopedVar to not require text, do not leak transformation-made variables between links * Add mappings and start implementing logfmt * Add mappings and start implementing logfmt * Remove mappings, turn off global regex * Add example yaml and omit transformations if empty * Fix the yaml * Add logfmt transformation * Cleanup transformations and yaml * add transformation field to FE types and use it, safeStringify logfmt values * Add tests, only safe stringify if non-string, fix bug with safe stringify where it would return empty string with false value * Add test for transformation field * Do not add null transformations object * Break out transformation logic, add tests to backend code * Fix lint errors I understand 😅 * Fix the backend lint error * Remove unnecessary code and mark new Transformations object as internal * Add support for named capture groups * Remove type assertion * Remove variable name from transformation * Add test for overriding regexes * Add back variable name field, but change to mapValue * fix go api test * Change transformation types to enum, add better provisioning checks for bad type name and format * Check for expression with regex transformations	2 years ago
Torkel Ödegaard	b8e7ef48d0	AppChrome: Unify logic for chromeless pages that should not have NavBar, CommandPalette, Search etc (#62281 ) * Keybindings: No global keybindings on chromeless pages * simplify condition * Refactoring * Align name and file * Move logic into AppChrome * minor fix * Update Page.tsx * Fixing test * Fixed tests * More fixes * Fixed more tests * Fixing final test * Fixed search in old nav	2 years ago
Levente Balogh	29119a7d08	UI/Alert: Infer the `role` property based on the `severity` (#61242 ) * feat(UI/Alert): add two new optional properties: 'ariaLabel' and 'role' * docs(UI/Alert): add some docs to the props * feat: infer the role based on the severity * fix: stop overriding props * fix: fix a test depending on the wrong alert role	2 years ago
Piotr Jamróz	e8ef0395b1	Glue: Hide run queries button in Correlations Page (#61039 ) * Hide run queries button in Correlations Page when showing Loki and Prometheus editors * Use more semantic selectors Co-authored-by: Giordano Ricci <me@giordanoricci.com> * Use more semantic selectors Co-authored-by: Giordano Ricci <me@giordanoricci.com> * Post-merge fix (remove duplicate) Co-authored-by: Giordano Ricci <me@giordanoricci.com>	2 years ago
Laura Benz	9400ccf478	Glue: Validate target query in correlations page (#57245 ) * feat: add draft version of validate button * feat: add some styling and basics * temp: intermediate result * refactor: solve TODOs * refactor: replace string in state * refactor: replace error message style * refactor: set validate state on change in ds * refactor: add QueryRunner * refactor: add QueryRunner * temp: temporary status * Emit PanelData to check if the query is valid * refactor: clean up * refactor: improve a11y of error message and adjust test * Remove deprecated property call, change equality * refactor: add changes from code review * refactor: remove memory leak * refactor: replace query runner * refactor: adjust error handling * refactor: move testing to related unit test * refactor: clean up test for QueryEditorField * refactor: clean up test for CorrelationsPage * refactor: repair test * refactor: clean up * refactor: add refId in order avoid errors when running Loki queries * refactor: replace buildQueryTransaction + set query to invalid if query is empty * refactor: add empty query value to test cases * refactor: end handleValidation after setIsValidQuery() * refactor: refactor test * refactor: fix last two tests * refactor: modify validation * refactor: add happy path * refactor: clean up * refactor: clean up tests (not final) * refactor: further clean up * refactor: add condition for failing * refactor: finish clean up * refactor: changes from code review * refactor: add response state to condition Co-authored-by: Piotr Jamróz <pm.jamroz@gmail.com> * refactor: fix prettier issue * refactor: remove unused return * refactor: replace change in queryAnalytics.ts * refactor: remove correlations from query analytics * refactor: remove unnecessary test preparation * refactor: revert changes from commit `4997327` Co-authored-by: Piotr Jamróz <pm.jamroz@gmail.com> Co-authored-by: Kristina Durivage <kristina.durivage@grafana.com>	2 years ago
Giordano Ricci	dc918f7e91	Grafana UI: Add experimental InteractiveTable component (#58223 ) * wip * move table * refine example * move to experimental * add row expansion example * add expanded row to kitchen sink * add column prop docs * add props docs * remove useless example * WIP * use unique id per row & proper aria attrs for expander * add custom cell rendering example * Remove multisort * rename shrink to disableGrow * move isTruthy type guard to @grafana/data * add missing prop from TableData interface * make column id required * fix correlations table * expand on docs * remove leftover comment * rename to InteractiveTable * add some tests * add expansion tests * fix tests * revert unneeded changes * remove extra header rule	3 years ago
Giordano Ricci	e4c394dfcd	Correlations: add tracking for add, update, delete, and details expanded (#58239 ) * Correlations: add tracking for add, update, delete, and details expanded * add tests * change delete event * rename handlers	3 years ago
kay delaney	e85917f041	Chore/React18: Update component prop types (#56898 )	3 years ago
Piotr Jamróz	ae927eab73	Glue: Enrich query results data frames in Explore with correlations to generate static links from correlations (#56295 ) * Attach static generic data link to data frames in Explore * WIP * Always load correlations config when the query is run This will be moved to Wrapper.tsx and called only once Explore is mounted * remove comment * Load the config when Explore is loaded * Clean up * Check for feature toggle, simplify cod * Simplify the code * Remove unused code * Fix types * Add a test for attaching links * Revert package.json changes * Display title provided in the correlation label * Add missing mocks * Fix tests * Merge branch 'main' into ifrost/integration/attach-generic-data-link # Conflicts: # public/app/features/explore/Wrapper.tsx # public/app/features/explore/state/main.ts * Remove redundant async calls * Do not block Wrapper before correlations are loaded (only delay the query) * Test showing results after correlations are loaded * Post-merge fix * Use more consistent naming * Avoid null assertions Co-authored-by: Elfo404 <me@giordanoricci.com>	3 years ago
Giordano Ricci	da9d8fe14f	Correlations: Add query editor and target field to settings page (#55567 ) * Fix: use type=button in editor * Grafana-UI: TextArea: make ctextare a block element * WIP: add field & target query to correlations * add table query helpers & test ordering * refactor some tests for disappearance * chore: move QueryEditorField & add tests * cleanup & fix typo * revert textarea changes * update form to support new config * move defaults	3 years ago
Laura Fernández	fca252e7dc	A11y: enable rule jsx-a11y/alt-text (#55832 ) * Enable jsx-a11y/alt-text rule * Fix errors * Fix tests * Enable jsx-a11y/alt-text rule after solving merge conflict * Delete unused import * Modify files according to the reviewer's comments * Revert test changes and update snapshot * tweaks to image alt names Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>	3 years ago
Giordano Ricci	d815e2cb56	Correlations: Return 200 instead of 404 for empt correlation lists (#55242 ) * return 200 instead of 404 for empty correlations list * handle empty list response & improve consistency	3 years ago
Piotr Jamróz	9b4cdfe652	Correlations: Hide Correlations Page behind a feature toggle (#55224 ) * Hide Correlations Page behind a toggle * Remove redundant defaults * Ensure top nav is rendered when correlations are disabled This is for the case when: [feature_toggles] topnav = true	3 years ago
kay delaney	4c7732ad17	Chore: Upgrade Typescript to 4.8.2 (#54901 ) * Chore: Upgrade typescript to 4.8.2	3 years ago
Giordano Ricci	c68d7f1e35	Correlations: Add CorrelationSettings Page (#53821 ) * GrafanaUI: add option to close DeleteButton on confirm click * add datasource readOnly info to frontend settings * move isTruthy utility type guard * add generic non-visualization table component * Add correlations settings page * add missing readOnly in mock * Fix typo * avoid reloading correlations after add/remove * use DeepPartial from rhf * validate source data source * fix validation logic * fix navmodel test * add missing readonly property * remove unused styles * handle multiple clicks on elements * better UX for loading states * fix remove handler * add glue icon	3 years ago

47 Commits (f3cdb4489881f4e92cd50d379ca9b720ec63077d)