grafana

Commit Graph

Author	SHA1	Message	Date
Marcus Efraimsson	6768c6c059	Chore: Remove public vars in setting package (#81018 ) Removes the public variable setting.SecretKey plus some other ones. Introduces some new functions for creating setting.Cfg.	1 year ago
Ryan McKinley	025b2f3011	Chore: use any rather than interface{} (#74066 )	2 years ago
Serge Zaitsev	0bdb105df2	Chore: Remove xorcare/pointer dependency (#63900 ) * Chore: remove pointer dependency * fix type casts * deprecate xorcare/pointer library in linter * rooky mistake	2 years ago
George Robinson	1f984409a2	Alerting: Fix a bug taking screenshots with Dashboard UID (#63220 ) This commit fixes a bug where Grafana would fail to take a screenshot if the same Dashboard UID was present across two or more different orgs.	2 years ago
Serge Zaitsev	d6d4097567	Chore: Fix goimports grouping in alerting (#62424 ) * fix goimports * fix goimports order	2 years ago
George Robinson	9af7adef76	Alerting: Support customizable timeout for screenshots (#60981 ) This commit adds a customizable timeout for screenshots called capture_timeout. The default value is 10 seconds, and the maximum value is 30 seconds. This timeout should be less than the minimum Interval of all Evaluation Groups to avoid back pressure on alert rule evaluation.	2 years ago
Sasha Melentyev	c02003af3c	Refactor time durations (#58484 ) This change uses `time.Second` in place of `1000 * time.Millisecond` and `time.Minute` in place of `60*time.Second`.	3 years ago
George Robinson	c5ae1bcfe0	Alerting: Fix logging pointer address of DashboardUID and PanelID variables (#58539 )	3 years ago
George Robinson	68600c224b	Alerting: Log when alert rule cannot be screenshot to help debugging (#58537 )	3 years ago
Alexander Weaver	2bfdda5b68	Alerting: Break dependency between state and image packages (#58381 ) * Refactor state and manager to not depend directly on image interface * Move generic errors to models package * Move NotAvailableImageService to state as its only references are in state tests * Move NoopImageService to state package * Move mock to state package * Fix linter error * Fix comment styling * Fix a couple added references introduced by rebase * Empty commit to kick build	3 years ago
George Robinson	7e852720e3	Alerting: Fix images cached on rule instead of dashboard panel signature (#58510 )	3 years ago
George Robinson	b92a0223e3	Alerting: Improve debug logs in image service (#58507 )	3 years ago
George Robinson	c646ff0ce3	Alerting: Fix screenshots were not cached (#58493 )	3 years ago
George Robinson	ad9ac85ee0	Alerting: Use hash of opts in singleflight (#58474 )	3 years ago
George Robinson	215ffee437	Alerting: Fix screenshot is not taken for stale series (#57982 )	3 years ago
Alexander Weaver	3ddb28bad9	Find-and-replace 'err' logs to 'error' to match log search conventions (#57309 )	3 years ago
George Robinson	2f85172718	Alerting: Remove blank comment (#56889 )	3 years ago
George Robinson	bad4f7fec5	Alerting: Change screenshots to use components (#55156 ) * Alerting: Change screenshots to use components This commit changes screenshots to use a number of components instead of a set of functional wrappers. It moves the uploading of screenshots from the screenshot package to the image package so we can re-use the same code for both uploading screenshots and server-side images; SingleFlight from the screenshot package to the image package so we can use it for both taking and uploading the screenshot, where as before it was used just for taking the screenshot; and it also removes the use of a cache because we know that screenshots can be taken at most once per tick of the scheduler.	3 years ago
George Robinson	196b781c70	Alerting: Delete expired images from the database (#53236 ) This commit adds a DeleteExpiredService that deletes expired images from the database. It is run in the periodic collector service.	3 years ago
George Robinson	d59db0b8e6	Alerting: Better metrics and renamed BrowserScreenshotService (#51564 )	3 years ago
Kristin Laemmert	9de00c8eb2	chore/backend: move dashboard errors to dashboard service (#51593 ) * chore/backend: move dashboard errors to dashboard service Dashboard-related models are slowly moving out of the models package and into dashboard services. This commit moves dashboard-related errors; the rest will come in later commits. There are no logical code changes, this is only a structural (package) move. * lint lint lint	3 years ago
George Robinson	fe797dcfdc	Alerting: Improvements to image package (#51576 ) This commit makes a number of improvements to the image package: - Improved comments - Return the correct error when a dashboard does not exist - Set a timeout in context.Context	3 years ago
George Robinson	ed56755dd7	Alerting: Remove duplicate error message (#51515 )	3 years ago
Jean-Philippe Quéméner	fd664e4beb	Alerting: replace a duplicated configuration key (#50350 ) This PR renames the configuration key enabled to capture. This is needed as we already have a configuration key with the name enabled. Fixes #50328 Co-authored-by: Jean-Philippe Quéméner <JohnnyQQQQ@users.noreply.github.com>	3 years ago
Joe Blubaugh	9e8efaa459	Alerting: Add stored screenshot utilities to the channels package. (#49470 ) Adds three functions: `withStoredImages` iterates over a list of models.Alerts, extracting a stored image's data from storage, if available, and executing a user-provided function. `withStoredImage` does this for an image attached to a specific alert. `openImage` finds and opens an image file on disk. Moves `store.Image` to `models.Image` Simplifies `channels.ImageStore` interface and updates notifiers that use it to use the simpler methods. Updates all pkg/alert/notifier/channels to use withStoredImage routines.	3 years ago
Joe Blubaugh	12c25759da	Alerting: Attach screenshot data to Slack notifications. (#49374 ) This change extracts screenshot data from alert messages via a private annotation `__alertScreenshotToken__` and attaches a URL to a Slack message or uploads the data to an image upload endpoint if needed. This change also implements a few foundational functions for use in other notifiers.	3 years ago
Joe Blubaugh	1d724810de	Alerting: State Manager takes screenshots. (#49338 ) The State Manager will now take screenshots when an alert instance switches to an Alerting or Resolved state. Signed-off-by: Joe Blubaugh joe.blubaugh@grafana.com	3 years ago
Joe Blubaugh	687e79538b	Alerting: Add a general screenshot service and alerting-specific image service. (#49293 ) This commit adds a pkg/services/screenshot package for taking and uploading screenshots of Grafana dashboards. It supports taking screenshots of both dashboards and individual panels within a dashboard, using the rendering service. The screenshot package has the following services, most of which can be composed: BrowserScreenshotService (Takes screenshots with headless Chrome) CachableScreenshotService (Caches screenshots taken with another service such as BrowserScreenshotService) NoopScreenshotService (A no-op screenshot service for tests) SingleFlightScreenshotService (Prevents duplicate screenshots when taking screenshots of the same dashboard or panel in parallel) ScreenshotUnavailableService (A screenshot service that returns ErrScreenshotsUnavailable) UploadingScreenshotService (A screenshot service that uploads taken screenshots) The screenshot package does not support wire dependency injection yet. ngalert constructs its own version of the service. See https://github.com/grafana/grafana/issues/49296 This PR also adds an ImageScreenshotService to ngAlert. This is used to take screenshots with a screenshotservice and then store their location reference for use by alert instances and notifiers.	3 years ago

28 Commits (f4b432841b8849c6cd88466808619fef1c47d2b3)