grafana

Commit Graph

Author	SHA1	Message	Date
Misi	12b1170631	Auth: Validation fixes for SSO Settings (#82252 ) * Validation fixes * Add URL validations + tests * Add ApiUrl validation * Refactor validators * lint * Clean up * Improvements	1 year ago
Dan Cech	790e1feb93	Chore: Update test database initialization (#81673 ) * streamline initialization of test databases, support on-disk sqlite test db * clean up test databases * introduce testsuite helper * use testsuite everywhere we use a test db * update documentation * improve error handling * disable entity integration test until we can figure out locking error	1 year ago
Misi	b1dc505a2b	Auth: Validate admin assignment in SSO Settings (#82233 ) * Add validation for allowAssignGrafanaAdmin * Update default values * Do not render hidden fields * Change error message * Improve tests --------- Co-authored-by: Clarity-89 <homes89@ukr.net>	1 year ago
Diego Augusto Molina	a6342fa576	Chore: Fix data race within tests and enable a few parallel tests in ssosettingsimpl (#81837 ) * Chore: Fix data race within tests of SSO Setting implementation * Chore: fix data race within tests to allow parallel testing * Chore: rollback changes runtime code to test a different approach * Chore: Fix data race in SSO Setting implementation Upsert method * Chore: fix typo in comment	1 year ago
Mihai Doarna	395a06ab86	Auth: fix swagger responses for the SSO settings API (#81639 ) fix swagger responses for the sso settings API	1 year ago
Misi	bcc2409564	Auth: Add validation to Generic OAuth API and UI (#81345 ) * wip * Update validation * Chore: Remove InputControl usage * Fixes, validation * Remove empty option * Validation changes * Add tests, rename * lint --------- Co-authored-by: Clarity-89 <homes89@ukr.net>	1 year ago
Misi	7e96a2be56	Auth: Reload OAuth provider after deletion of the current settings (#81374 ) * Reload after deletion of the current settings * Add grafana_ssosettings_setting_reload_failure_total counter * Returns successfully if data reload failed	1 year ago
Misi	c47b55ae10	Auth: Add SSO settings usage stats (#81143 ) * Add usage stats * UsageStats test + svc rename * Fix test	1 year ago
Misi	8246d97587	Auth: Introduce `configurable_providers` config option for SSO settings (#80911 ) * Add SSOSettingsConfigurableProviders config option * Add check to Delete and ListWithRedactedSecrets * Add check to GET, small improvements	1 year ago
Misi	20bb0a3ab1	AuthN: Support reloading SSO config after the sso settings have changed (#80734 ) * Add AuthNSvc reload handling * Working, need to add test * Remove commented out code * Add Reload implementation to connectors * Align and add tests, refactor * Add more tests, linting * Add extra checks + tests to oauth client * Clean up based on reviews * Move config instantiation into newSocialBase * Use specific error	1 year ago
colin-stuart	e241188f00	Auth: Implement the SSO Settings List endpoint (#80769 ) * add list endpoint & initial tests * add tests and ETag * format service_test.go * add list swagger param, generate openAPI, remove ETag, use RedactedPassword * correct swagger param name * Align tests to latest changes * use setting.RedactedValue() * add string assertion * lint & require no error on res.Body.Close() * add custom response type --------- Co-authored-by: Mihaly Gyongyosi <mgyongyosi@users.noreply.github.com>	1 year ago
Mihai Doarna	b8cf8ec8d7	Auth: fix swagger response for get SSO settings endpoint (#80817 ) fix swagger response for get SSO settings endpoint	1 year ago
Misi	da6926f6f7	Auth: SSOSettings handle secret update (#80591 ) * first touches * Merge missing SSO settings to support Advanced Auth pages * fix * Update secrets correctly * Add test for upsert with redactedsecret * Verify decryption in the List tests	1 year ago
Misi	c196bde2e0	Auth: Include missing SSO settings from system settings on read paths (#80421 ) * first touches * Merge missing SSO settings to support Advanced Auth pages * fix	1 year ago
Mihai Doarna	39e4f8ec1b	Auth: configure SSO settings reload interval from the ini file (#80290 ) * configure sso reload interval from ini file * change section name to sso_settings	1 year ago
Mihai Doarna	4bf5c63657	Auth: tidy up the database layer from the SSO Settings Service (#80341 ) tidy up the database layer	1 year ago
Mihai Doarna	772e5993b6	Auth: reload SSO settings for HA setups (#80231 ) * reload SSO settings for HA setups * remove check for grafana HA * add unit tests * fetch all sso settings with one sql query * register background service	1 year ago
Ryan McKinley	1caaa56de0	FeatureFlags: Use interface rather than manager (#80000 )	1 year ago
Mihai Doarna	3332562900	Auth: use Empty() for sending empty http responses in SSO Settings API (#80200 ) use Empty() for sending empty http response	1 year ago
Mihai Doarna	adb7295bab	Auth: Send an empty http response without the json header in SSO Settings API (#80197 ) send an empty http response without the json header	1 year ago
colin-stuart	062e772bb2	Auth: Implement the SSO Settings GET endpoint (#79144 ) * Return data in camelCase from the OAuth fb strategy * changes * wip * Add defaults for oauth fb strategy * revert other changes * basic includeDefaults query param implementation * basic secret removal and etag implementation * correct imports * rebase * move default settings filter to models * only replace ClientSecret value if set * first GetForProvider test & use FNV for ETag to avoid Blocklisted import error * add tests * add annotation for the openapi spec & generate spec * remove TODO * use IsSecret, improve tests, remove DefaultOAuthSettings * add comment explaining generateFNVETag * add error handling for generateFNVETag * run go generate * Update pkg/services/ssosettings/api/api.go Co-authored-by: Mihai Doarna <mihai.doarna@grafana.com> * move isSecret to service, create GetForProviderWithRedactedSecrets func * add unit test for GetForProviderWithRedactedSecrets & remove duplicated code * regen openapi/swagger * revert dependency bumps --------- Co-authored-by: Mihaly Gyongyosi <mgyongyosi@users.noreply.github.com> Co-authored-by: Mihai Doarna <mihai.doarna@grafana.com>	1 year ago
Misi	eae6adf002	Auth: Use cfg.Raw in OAuthStrategy for loading settings (#80136 ) Use cfg.Raw in OAuthStrategy, remove unnecessary tests	1 year ago
Mihai Doarna	359b118e6a	Auth: fix camelCase in getFallbackStrategyFor() func (#80061 ) fix camelCase in getFallbackStrategyFor() func	1 year ago
Mihai Doarna	c219a19f97	Auth: Add missing 404 status code from the SSO Settings delete endpoint (#79982 ) add missing 404 status code from sso settings delete endpoint	1 year ago
Mihai Doarna	ade91e5038	Auth: Implement the SSO Settings update endpoint (#79676 ) * merge with system settings before storing them in the db * add base for validating sso settings * add unit tests for sso settings validation * call Reload() from sso service upsert() * remove actual validation because it was moved in a separate pr * use constant to fix lint error * check if provider is configurable in service Upsert() method * add unit tests for update provider settings api method * fix lint error	1 year ago
Mihai Doarna	6465d87afd	Auth: Add basic validation for SSO settings (#79696 ) * add basic validation for sso settings * remove validation for the client secret	1 year ago
Mihai Doarna	0f4cd3090b	Auth: Modify scopes field value in tests to be comma separated (SSO Settings API) (#79759 ) modify scopes field value to be comma separated	1 year ago
Mihai Doarna	1ef9417765	Auth: Use camelCase in SSO Settings API (#79755 ) use camelCase in SSO Settings API	1 year ago
Mihai Doarna	9648a06dde	Auth: Add swagger metadata for the update SSO Settings endpoint (#79580 ) * add swagger doc for sso settings update endpoint * add generated api specs	1 year ago
Mihai Doarna	53d209e6f1	Auth: Fix flaky tests that are mocking time.Now() from SSO Settings (#79581 ) test time values using require.WithinDuration() instead of mocking time.Now()	1 year ago
Mihai Doarna	15d8a1f94d	Auth: Remove types from SSOSettings struct in SSO service (#79459 ) * replace SSOSettings with SSOSettingsDTO * fix database tests * fix oauth strategy * fix sso settings service tests * add secrets encryption on update * rename SSOSettingsDTO to SSOSettings * remove extraKeys from strategy * change back settings type from createOAuthConnector to OAuthInfo * do not parse multi-value fields in oauth strategy	1 year ago
Misi	ce1450d4d3	Chore: Configure SkipOrgRoleSync from OAuthInfo for OAuth connectors (#79443 ) * Configure SkipOrgRoleSync from OAuthInfo * Remove skipOrgRoleSync from socialbase and connectors * Add test to socialimpl.ProvideService * Deprecate AuthSettings' fields * clean up misleading init of frontendsettings.Auth	1 year ago
Misi	50f4e78a39	Auth: Use SSO settings service to load social connectors + refactor (#79005 ) * Refactor to prevent cyclic dependencies * Move list authorization to the API layer * Init connectors using the SSO settings service in case the ssoSettingsApi feature toggle is enabled * wip, need to handle the cyclic dep * Remove cyclic dependency * Align tests + refactor * Move back OAuthInfo to social * Delete pkg/login/social/constants * Move reloadable registration to the social providers * Rename connectors.Error to connectors.SocialError	1 year ago
Mihai Doarna	d7641b0ecb	Auth: encrypt secrets for oauth providers in SSO settings API service (#79081 ) encrypt secrets for oauth providers	1 year ago
Misi	d3a269ab3b	Auth: Load ini/env vars settings in the fallback strategy (#78495 ) * Return data in camelCase from the OAuth fb strategy * changes * wip * Add defaults for oauth fb strategy * revert other changes * Add tests * Add Defaults to cfg and use it in OAuthStrategy * Return OAuthInfo from OAuthStrategy lint * Remove unnecessary Defaults * Introduce const for fields, fix import order * Align failing tests * clean up * Changes requested by @gamab * Update pkg/services/ssosettings/strategies/oauth_strategy_test.go Co-authored-by: Gabriel MABILLE <gamab@users.noreply.github.com> * Load data on startup * Rename + simplify --------- Co-authored-by: Gabriel MABILLE <gamab@users.noreply.github.com>	2 years ago
Mihai Doarna	2e2b1cd9e4	Refactor SSOSettings to use types (#78675 ) * refactor SSOSettings to use types * test struct * refactor SSOSettings struct to use types * fix database tests * fix populateSSOSettings() to accept an SSOSettings param * fix all tests from the database layer * handle errors for converting to/from SSOSettings * add json tag on OAuthInfo fields * use continue instead of if/else * add the source field to SSOSettingsDTO conversion * remove omitempty from json tags in OAuthInfo struct	2 years ago
Mihai Doarna	27d8b68c9c	Auth: Add more tests for the SSO settings upsert function (#78544 ) * add more tests for the SSO settings upsert function * fix client id to match provider * use time now in tests	2 years ago
Mihai Doarna	f0d3e27ea7	Add unit tests for the removeSSOSettings API method (#78476 ) add unit tests for the removeSSOSettings api method	2 years ago
Misi	3607a00692	Auth: Use camelCase in SSO Settings API (#78480 ) Return/accept camelCase fields in sso setting api	2 years ago
Mihai Doarna	875ea092df	Add more unit tests for removeSSOSettings method (#78329 ) * add more unit tests for remove sso settings * add unit tests for the service method	2 years ago
Misi	437ae8e8c5	Auth: Refactor OAuth connectors' initialization (#77919 ) * Refactor AzureAD to init itself * Use mapstructure to convert data to OAuthInfo * Update * Align tests * Remove unused functions * Add owner to mapstructure * Clean up, lint * Refactor Okta init, Align tests * Address review comments, fix name in newSocialBase * Update newSocialBase first param * Refactor GitLab init, align tests * Update pkg/login/social/common.go Co-authored-by: Karl Persson <kalle.persson@grafana.com> * Use ini conversion to map * Leftovers * Refactor GitHub connector initialization, align tests * Refactor Google connector init, align tests * Refactor grafana_com connector, align tests * Refactor generic_oauth connector init, align tests * cleanup * Remove util.go * Add tests for custom field init * Change OAuthInfo's Extra type * Fix * Replace interface{} with any * clean up --------- Co-authored-by: Karl Persson <kalle.persson@grafana.com>	2 years ago
Mihai Doarna	9da9bbf907	Add swagger code for the removeProviderSettings API method (#78270 ) * add swagger code for the remove provider SSO settings API method * replace fine grained with role based * address feedback	2 years ago
Misi	7ae0ff1309	RBAC: Add OAuth provider scopes separately to fixed:authentication.config:writer (#78202 ) Add OAuth provider setting scopes to fixed:authentication writer * Change SSO Settings api scopes * Remove unused RBAC Action	2 years ago
Ryan McKinley	f69fd3726b	FeatureToggles: Add context and and an explicit global check (#78081 )	2 years ago
Mihai Doarna	6d74746997	Auth: Replace literal http status codes with constants from http pkg (#78116 ) replace literal http status codes with constants from http pkg	2 years ago
Misi	5285e9503b	Auth: SSO settings foundations (#77724 ) * inital changes, db migration * changes * Implement basic GetAll, Delete * Add first batch of tests * Add more tests * Add service tests for GetForProvider, List * Update http_server.go + wire.go * Lint + update fixed role * Update CODEOWNERS * Change API init * Change roles, rename * Review with @kalleep * Revert a mistakenly changed part * Updates based on @dmihai 's feedback --------- Co-authored-by: Karl Persson <kalle.persson@grafana.com>	2 years ago

46 Commits (f4b432841b8849c6cd88466808619fef1c47d2b3)