75 Commits (faa29db241c1d52c016b23201225e92d2c4bb9ef)

Author	SHA1	Message	Date
kay delaney	375dcc3813	Chore: Change VariableModel to TypedVariableModel in most places (#76690)	2 years ago
Ashley Harrison	ff0642bf6e	Chore: Type improvements 🧹 (#75271) ... * fix some e2e flows types * some type fixes * must... fix... more... * MOAR * MOREMOREMORE * 1 more	2 years ago
Ashley Harrison	0c44a6f9bb	Chore: Improve typings 🧹 (#74599) ... * various type fixes * candlestick panel type fixes * few more fixes * some fixes * more :) * moar! * undo change to SilencesFilter * undo change to configureStore	2 years ago
Alexa V	97c3cd1af3	Dashboard: Fix Variable Dropdown to Enforce Minimum One Selection when 'All' Option is Configured (#69839)	2 years ago
Yelmor	8e7fa50775	Dashboard: Variables Dropdown - Fix Flickering on Refresh (#72566)	2 years ago
Ashley Harrison	e0587dfb30	Chore: Replace deprecated usage of `shape.borderRadius()` (#72672) ... * properly mark borderRadius() as deprecated, replace borderRadius() with default * undo a couple of changes * use radius.pill in FilterPill	2 years ago
Andres Martinez Gotor	5d07b1c884	Chore: Move getSearchFilterScopedVar to @grafana/data (#71839)	2 years ago
Simon Podlipsky	6f880b713a	Variables: allow `{}` type in `VariableWithOptions.current ` (#64358)	2 years ago
Polina Boneva	6137e45fe1	Template Variables: Input field in dashboard does not send network requests for query var with ${__searchFilter} (#67839) ... Co-authored-by: Ivan Ortega Alba <ivanortegaalba@gmail.com>	2 years ago
Christy O'Reilly	a7bb87d15d	Chore: Refactor to introduce VARIABLE_PREFIX constant (#62980) ... Co-authored-by: Ivan Ortega Alba <ivanortegaalba@gmail.com>	2 years ago
Ryan McKinley	2578774188	Chore: Avoid explicit React.FunctionComponent<Props> when possible (round 3) (#64839)	2 years ago
Ryan McKinley	d710507bc5	Chore: Avoid explicit `React.FC<Props>` when possible (#64722)	2 years ago
Dominik Prokop	e4d591fc01	OptionsPicker: Correctly highlight template variable value when filtering (#63495) ... * VariablePicker: Correctly highlight items when filtering * Change interactions for selecting values in variable options picker * Review	2 years ago
Ashley Harrison	5b8c2f494d	Chore: convert `VariableOptions` to use emotion instead of scss (#64135) ... convert VariableOptions to use emotion instead of scss	2 years ago
Josh Hunt	54aaaf169f	Internationalization: Mark up more of Dashboard Variables and Browse/Search Dashboards (#63518) ... * Extract dirty translations from main * Translate some variable phrases * Translate nav bar * Translate search/browse * Fix header returning null * Translate search results type * fix test	2 years ago
Ashley Harrison	f8d89eff56	Chore: fix type errors in tests (#63270) ... * fix any's in tests * fix more any's in tests * more test type fixes * fixing any's in tests part 3 * more test type fixes * fixing test any's p5 * some tidy up * fix template_srv	2 years ago
yusuf-multhan	50df85189c	Variables: Allow user to filter values in dropdown using white space (#60622) ... Fix #60589	3 years ago
Laura Fernández	3cedcdedbd	Internationalization: Translate VariableInput and VariableOptions components (#58748)	3 years ago
Torkel Ödegaard	6ed35292fe	Variables: SceneVariable update process (#57784) ... * First baby steps * First baby steps * No progress really * Updates * no progress * refactoring * Progress on sub menu and value selectors * Some more tweaks * Lots of progress * Progress * Updates * Progress * Tweaks * Updates * Updates to variable system * Cleaner tests * Update * Some cleanup * correct test name * Renames and moves * prop rename * Fixed scene template interpolator * More tests for SceneObjectBase and fixed issue in EventBus * Updates * More tweaks * More refinements * Fixed test * Added test to EventBus * Clone all scene object arrays * Simplify * tried to merge issue * Update * added more comments to interface * temp progress * Trying to simplify things, but struggling a bit * Updated * Tweaks * Progress on fixing the select componenet and typing, and sharing code in a base class * Updated * Multi select * Simpler loading state * Update * removed failOnConsole * Removed old funcs * Moved logic from update manage to MultiValueVariable * Added tests for MultiValueVariable logic * Made value a more abstract concept to support object values * renamed func to getValueText * Refactored and moved logic to VariableSet * Added test for deactivation and query cancelling * Tweaks * Fixed lint issues	3 years ago
Laura Fernández	e402a8f27d	A11y: enable rule jsx-a11y/anchor-is-valid (#56690)	3 years ago
Josh Hunt	4b4d546e32	Typed variables pt4: Remove generics from getVariable (#53017) ... * wip * make diff easier to read * Update template_srv getVariables to return new TypedVariableModel * update VariableType to use the type from TypedVariableModel * tidy things up * Chore: Use type-accurate mock variables in tests * Chore: Type VariableState to use TypedVariableModel * fix typo * remove type assertion from template_srv.getVariables * use typescript/no-redeclare for compatibility with ts overloads * remove generics from getVariable() and overload it to only return undefined based on arguments * update usages of getVariable() * Fix Interval variable options picker not working	3 years ago
Josh Hunt	06d78ea904	Dashboards: Disable variable pickers for snapshots (#52827) ... * user essentials mob! 🔱 lastFile:public/app/features/variables/textbox/TextBoxVariablePicker.tsx * user essentials mob! 🔱 * user essentials mob! 🔱 lastFile:public/app/features/variables/adhoc/picker/AdHocFilter.tsx * finish up disabling variables in snapshots * remove accident * use theme.spacing instead of the v1 shim Co-authored-by: Joao Silva <joao.silva@grafana.com> Co-authored-by: Leodegario Pasakdal <leodegario.pasakdal@grafana.com>	3 years ago
Ashley Harrison	683bbc7373	Templating: Changing between variables with the same name now correctly triggers a dashboard refresh (#51490) ... * user essentials mob! 🔱 * user essentials mob! 🔱 lastFile:public/app/features/variables/pickers/OptionsPicker/actions.ts * user essentials mob! 🔱 lastFile:public/app/features/variables/pickers/OptionsPicker/actions.test.ts * linting * update betterer Co-authored-by: kay delaney <kay@grafana.com>	3 years ago
kay delaney	bb7e556efc	Templating: Prefix variable picker element IDs (#48405)	3 years ago
Josh Hunt	3c6e0e8ef8	Chore: ESlint import order (#44959) ... * Add and configure eslint-plugin-import * Fix the lint:ts npm command * Autofix + prettier all the files * Manually fix remaining files * Move jquery code in jest-setup to external file to safely reorder imports * Resolve issue caused by circular dependencies within Prometheus * Update .betterer.results * Fix missing // @ts-ignore * ignore iconBundle.ts * Fix missing // @ts-ignore	3 years ago
Ashley Harrison	d832bde270	Upgrade `@testing-library/user-event` to v14 (#47898) ... * Update dependency @testing-library/user-event to v14 * everything is async... * everything is async pt.2 * Fix cascader tests * hack the yarn.lock file to remove the old version of @testing-library/dom * some more fixes! * MOAR FIXES * more fixes * remove a bunch of places where we're wrapping in act() * down to 7 failing tests... * Fix arrow tests * Fix rest of NavBarItem tests * Fix last tests * Use {Enter} instead of {enter} * Revert "Use {Enter} instead of {enter}" This reverts commit e72453bb52. * remove some unused act imports * Fix LibraryPanelsSearch tests * more stable test * More consistent test... Co-authored-by: Renovate Bot <bot@renovateapp.com>	3 years ago
Hugo Häggmark	dbec2b02fd	Variables: move state tree into a keyed state (#44642) ... * Variables: move state tree into a keyed state * Update public/app/features/variables/state/transactionReducer.ts Co-authored-by: kay delaney <45561153+kaydelaney@users.noreply.github.com> * Chore: fix prettier error * Chore: renamed slices and lastUid * Chore: rename toUidAction * Chore: rename dashboardVariableReducer * Chore: rename state prop back to templating * Chore renames variable.dashboardUid * Chore: rename toDashboardVariableIdentifier * Chore: rename getDashboardVariable * Chore: rename getDashboardVariablesState * Chore: rename getDashboardVariables * Chore: some more renames * Chore: small clean up * Chore: small rename * Chore: removes unused function * Chore: rename VariableModel.stateKey * Chore: rename KeyedVariableIdentifier.stateKey * user essentials mob! 🔱 * user essentials mob! 🔱 * user essentials mob! 🔱 * user essentials mob! 🔱 Co-authored-by: kay delaney <45561153+kaydelaney@users.noreply.github.com> Co-authored-by: kay delaney <kay@grafana.com> Co-authored-by: Alexandra Vargas <alexa1866@gmail.com> Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>	3 years ago
renovate[bot]	d87cd6f26c	Update dependency prettier to v2.5.1 (#43473) ... * Update dependency prettier to v2.5.1 * prettier fixes * chore(toolkit): bump prettier to 2.5.1 * style(eslint): bump grafana config to 2.5.2 in core and toolkit * style(mssql-datasource): fix no-inferrable-types eslint errors Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com> Co-authored-by: Jack Westbrook <jack.westbrook@gmail.com>	4 years ago
Hugo Häggmark	4b4afc7b2c	Chore: reduces circular dependencies for variables/utils.ts (#44087) ... * Chore: move constants to own file * Chore: moves safe* functions to grafana/data * Chore: moves safe* functions to grafana/data * Chore: adds VariableQueryEditorProps and deprecates VariableQueryProps * Chore: remove getDefaultVariableAdapters function * Chore: moves transaction status to types * Chore: fix tests that do not initialise TemplateSrv * Chore: change space when stringifying * Chore: revert safe* func move * Chore: remove circular dependency in Explore utils	4 years ago
Hugo Häggmark	4c727248a3	Chore: Fix for query variables using DataSourceRef (#41255)	4 years ago
Ashley Harrison	e48d77b1eb	Variables: Improve display when selecting variables with the same value (#40607) ... * Variables: Allow selection of different variables with the same value * Variables: Don't modify this key	4 years ago
Alexander Kubyshkin	8cdc752497	Fix variable input field size (#38850) (#39156)	4 years ago
Alex Khomenko	d90c822e69	Fix key prop when rendering options (#38595)	4 years ago
Tobias Skarhed	1f091c448f	Template variables: Keyboard navigation improvements (#38001) ... * Fix variable labels * Add proper labeling for input * Add ids to PickerRenderer * Fix tests * Update PR feedback * OptionsPicker: Change to id * Inherit aria attributes * Add checkbox role * Fix typo * Add proper label reference * Update role and label * Prevent spreadng non-DOM attributes * Move form layout to other component * Remove haspopup * Add testid to selector * Add HTMLProps extension * Use list * Move styles outside of class * Add cx	4 years ago
Hugo Häggmark	f73be970d3	Variables: Removes experimental Tags feature (#33361) ... * Variables: Removes experimental Tags feature * Refactor: adds dashboard migration * Tests: fixes snapshots * Docs: removes docs for experimental feature * Refactor: dummy change * Docs: removes reference	4 years ago
kay delaney	bad048b7ba	Performance: Standardize lodash imports to use destructured members (#33040) ... * Performance: Standardize lodash imports to use destructured members Changes lodash imports of the form `import x from 'lodash/x'` to `import { x } from 'lodash'` to reduce bundle size. * Remove unnecessary _ import from Graph component * Enforce lodash import style * Fix remaining lodash imports	4 years ago
Hugo Häggmark	34b4f7c717	Chore: Reduces strict errors (#33012) ... * Chore: reduces strict error in OptionPicker tests * Chore: reduces strict errors in FormDropdownCtrl * Chore: reduces has no initializer and is not definitely assigned in the constructor errors * Chore: reduces has no initializer and is not definitely assigned in the constructor errors * Chore: lowers strict count limit * Tests: updates snapshots * Tests: updates snapshots * Chore: updates after PR comments * Refactor: removes throw and changes signature for DashboardSrv.getCurrent	4 years ago
Hugo Häggmark	6087980de0	Variables: Confirms selection before opening new picker (#32586) ... * Variables: Confirms selection before opening new picker * Tests: fixes e2e tests	4 years ago
Torkel Ödegaard	10badea19e	Emotion: Upgrades emotion from 10 to 11 and updates all import paths (#32541) ... * Babel: Updates babel dependencies to latest version * Emotion: Upgrade form 10 to 11 * Fixing tests * Updated to use emotion/css instead in test	4 years ago
Torkel Ödegaard	340334994f	Variables: Fixes error when manually non-matching entering custom value in variable input/picker (#32390)	4 years ago
Hugo Häggmark	bc60ce9cce	Variables: Fixes filtering in picker with null items (#31979) ... * Variables: Fixes filtering in picker with null items * Chore: some cleanup	4 years ago
Dominik Prokop	a55a272276	Routing NG: Replace Angular routing with react-router (#31463) ... * Add router packages * Get react app root work instead of Angular one * Logger util * Patch Angular routing ($routeProvider, $routeParamsProvider) * Use react-router-dom history instead of separate dependency * Add test routes * Sidemenu - use Link instead of anchors * Patch Angular $location service (stub) * WIP: geting rid of $location provider from TimeSrv * Intercept anchor clicks to use history under the hood * Sync Redux location slice with history state * Make login/logout work * Debug routes for testing * Make force login work * Make sure query param change does not recreate page components * Hide side menu in specified locations * Make the dashboar route query parameters work, make panel edit menu work * Enable more routes * Fix side menu * Handle view modes * Disable playlist routes * Make SafeDynamicImport work again * Bring back router-debug * Separate redux location sync from route rendering * Refactor updateLocation to thunk and move force refresh(login) to it * Fixing init dashboard issue * Support switching between dashboards without an unmount of DashboardPage * More fixes for init dashboard and panel edit * More type fixes * Moving angular location wrapper out of main LocationService, and fixing typescript issues * Fixed last typescript errors * LocationService: Move to runtime and remove getLocationService and export singleston const instead (#31523) * Moving location service implementation to runtime and removing get function and making it a package const singleton * Added test that used locationService directly * removed unused import * AngularApp: Moving angular dependencies and the app boot out of the main app into it's own file (#31525) * Fixes angular panels by calling the monkey patch * Moving angular stuff to to it's own files * udpated * Fixing clicking on divs and spans inside anchor * Moving app notifications out of angular app and removing angular directive wrapper * Moving search from angular to react and removing angular search wrapper * Clean up, tried to remove the redux location wrapper but requires a big update for DashboardPage, so adding it back * Moving AppWrapper to root to limit circular dependencies (app/core -> app/routing and back) * Open and close search now works * Hide sidemenu when in kiosk mode * Restoring some keybindings like ESC key * Removed kiosk events and simplified it, just handled through updating URL * Fixing typescript errors * Simplified GrafanaRouteComponentProps and renamed to ContainerProps * renamed back * Changed AlertRuleList to use GrafanaRouteComponentProps and location.search passed to it * Removing the reloadOnSearch property, this is not needed now for react as react by default does not unmount components when only url match or query parmas change * SafeDynamicImport causing unmount un every search update, not sure how to fix yet * Fix signature for SafeDynamicImport so we do not create new route components on every route render * Removing the redux location wrapper as it was causing errors, and making dashboard page work with RouteProps (location, match) etc * Updating DashboardPage and SoloPanelPage to use match params and history location * Fixed DashboardPage tests * Fixing solo route tests * LocationService: Rename getCurrentLocation to just getLocation * do not intercept link clicks with target blank or self * Experimental useUrlParams hook * Update DataSourceSettingsPage to use router match params * fix links with urls that have no starting / to work like before * Fix forceLogin * Add queryParams to GrafanaRouteComponentProps * PanelEditor get rid of updateLocation and location state * Improve grafana route query params typing * Add getSearchObject to LocationService * Use DashboardPAge queryParams instead of location.search parsing * Fix DashboardPage typing * Fix some tests weirdness * Bring back KeyboardSrv * Fixes typescript issues * Team pages now use router match params * Get rid of from GrafanaRouteComponent props * Removed unnessary calls to getSearchObject when calling locationService.partial * Updated DashboardPage tests after queryParams was added * Fixing dashboard settings back * GrafanaRoute: Adding tests and remove use of global locationService * Fixing tests and typescript errors * Bring back kiosk modes and add tests * Fix TimeSrv tests * Fix typecheck errors * Fixing tests * Updated SideMenu test to react-testing and wrapped component in Router, and fixed issue importing createMemoryHistory * Get rid of routeChange event from TimeSrv from * Fixed TopSectionItem test * Trying to make basename work but failing * Update TopSectionItem snapshot * Fix TopSectionItem snapshot test * Fix API keys creation * Remove Angular dependencies from KeybindingSrv (#31617) * Remove Angular dependency from KeybindingsSrv * Fix tests and typecheck issues * basename is starting to work * Make dashboard save work * KeybindingSrv: Remove as angular service and no usage angular scope * So long bridge_srv, we won't miss you * Update snapshots * Dashboard: Refactoring ChangeTracker to use History api and no angular (#31653) * Dashboard: Refactoring ChangeTracker to use History api and no angular * Updated * Removed logging * fixed unit tests * updated snapshots * Mechanism for force reloading routes (#31683) * e2e: Fixes various things in e2e scenarios after router migration (#31685) * Explore: Update reading query params from router props and updating location via locationService (ReactRouter) (#31688) * RoutingNG: Initial explore redux location to router location migration * Updated explore Wrapper tests * Fixing more tests * remove loggin * rename back to make naming consistent * Fixing return to dashboard button * fixing navigation to explore from dashboard * updated routeProps * Updated tests * Make DashboardListPage work * Fixing navigation after add new data source, and fixes explore e2e * Fixing solo panel page * PluginsPage now works * RoutingNG: When parsing and rendering url search/query params preseve old logic of handling booleans and arrays (#31725) * RoutingNG: When parsing and rendering url search/query params preserve old logic of handling booleans and arrays * Fixed test * Make snapshots list work * fixed alert notification channel edit page * Simplify LocationService, did not need special handling for login or forceLogin as target _self on link already handles that * fixed UserAdminPage * fixed edit orgs page * Fixing LdapPage * fixing dashboard import * Fixed new folder page * Fixed data source dashboards page * fixing Folder permissions and folder settings page * fixing snapshot list page nav model * remove unused file * Added placeholder page for playlist * Moved browser compatability to index-template * Restored 404/default page * Fixed reset password page * Fixed SignUpInvited page * Fixing CreateTeam, Create user page, add panel widget * Restore browwser file to make tests happy * Fixed unit tests * Removed unused import * Replacing usage of updateLocation * Fixed test * Updating search filters to use history / location service for filters * remove unused file * AppRootPage fixed * Fixing test and search issue * Changes to support enterprise extensions * remove console.log * Removing more use of redux location * Fixed signup page * removed unused old angular controllers * Fixing bugs * one final bugfix * Removed location from redux state * Fixing ts issues and tests * Fixing test issue * fixing tests * Fixing tests * removed unused stuff * Fixed search test * Adding some doc comments * Routing NG: Angular location provider patch (#31773) * Patch Angulars $location provider * Update public/app/angular/bridgeReactAngularRouting.ts * Remove only test * Update tests, disable loggers in test env * Routing NG: remove $location provider usage (#31816) * Remove dashboard_loaders * Remove $location from Analytics service, track page views form GrafanaRoute * Remove NotificationsEditCtrl * Remove Angular dependencies from uploadDashboardDirective * Update public/app/features/dashboard/containers/DashboardPage.tsx Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com> * Update public/app/features/dashboard/containers/DashboardPage.tsx Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com> * Remove unused test helpers (#31831) * Playlist react (#31829) * playlist list in react * Playlist start * Things started to work * Updated * Handle empty list * Fix ts * Fixes and kiosk mode stuff * Removed unused events * fixing ts issue * Another ts issue * Fixing tests Co-authored-by: Dominik Prokop <dominik.prokop@grafana.com> * fixed test * Update public/app/AppWrapper.tsx Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com> * Update public/app/AppWrapper.tsx Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com> * Remove Angular dependency from DashboardLoaderSrv (#31863) Co-authored-by: Torkel Ödegaard <torkel@grafana.com> Co-authored-by: Torkel Ödegaard <torkel@grafana.org> Co-authored-by: Hugo Häggmark <hugo.haggmark@grafana.com> Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com>	4 years ago
Giordano Ricci	7e0b1f2619	Templating: use dashboard timerange when variables are set to refresh 'On Dashboard Load' (#31721) ... * Templating: use dashboard timerange when variables are set to load 'On Dashboard Load' * Add test	4 years ago
Hugo Häggmark	3c1f27b0e6	Chore: reduce strict errors for variables (#31241) ... * Chore: reduces a lot of variable errors * Chore: reduces variable Editor errors * Chore: reduces variable Picker errors * Chore: reduce error count * Chore: reduces errors for ChangeEvent instead of FormEvent * Chore: reduces errors with CombinedState * Chore: reduces ComponentType errors * Chore: reduce errors in reducers * Chore: reduces misc errors * Chore: reduce AdhocPicker errors * Chore: reduce error limit * Update public/app/features/variables/adhoc/picker/AdHocFilterValue.tsx Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com> * Chore: updates after PR comments * Chore: small refactor Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com>	4 years ago
Alex Khomenko	6f1a38cbe2	Variables: Extend option pickers to accept custom onChange callback (#30913) ... * Rename DashboardPicker props * Extend variable option pickers to allow providing custom onchage callback * Update public/app/features/variables/pickers/OptionsPicker/actions.ts Co-authored-by: Hugo Häggmark <hugo.haggmark@grafana.com> * Update public/app/features/variables/pickers/OptionsPicker/actions.ts Co-authored-by: Hugo Häggmark <hugo.haggmark@grafana.com> * Update public/app/features/variables/pickers/OptionsPicker/actions.ts Co-authored-by: Hugo Häggmark <hugo.haggmark@grafana.com> * Update public/app/features/variables/textbox/TextBoxVariablePicker.tsx Co-authored-by: Hugo Häggmark <hugo.haggmark@grafana.com> * Codeformat Co-authored-by: Hugo Häggmark <hugo.haggmark@grafana.com>	4 years ago
Hugo Häggmark	6994f19d1f	Variables: Clears drop down state when leaving dashboard (#30810)	5 years ago
Torkel Ödegaard	1d689888b0	Prettier: Upgrade to 2 (#30387) ... * Updated package json but not updated source files * Update eslint plugin * updated files	5 years ago
Hugo Häggmark	dd326d296e	Varibles: Fixes so clicking on Selected will not include All (#29844)	5 years ago
Chi-Hsuan Huang	73518bf1e7	Chore: Enable remaining eslint-plugin-react rules (#29519) ... * Chore: Enable eslint react/no-render-return-value rule Eanble the rule and remove the unused render return part of: #29201 * Chore: Enable eslint react/no-children-prop rule Not linting issues after turning on this. No other file changes requried part of: #29201 * Chore: Enable eslint react/no-unknown-property rule Correct enable-background to enableBackground part of: #29201 * Chore: Enable eslint react/no-unescaped-entities rule Replaced " with &quot; replaced ' with &apos; part of: #29201	5 years ago
Hugo Häggmark	04d857dfe6	Variables: Adds description field (#29332) ... * Variables: Adds description field * Refactor: Adds new Form components * Refactor: Fixes aria labels * Refactor: removes skipped tests * Refactor: Breaks out smaller select components * Refactor: removes gf-form div * Refactor: Breaks up several more selects into smaller components * Chore: Fixes typings	5 years ago