grafana

Commit Graph

Author	SHA1	Message	Date
Matthew Jacobson	0ce1ccd6f9	Alerting: Fix inconsistent AM raw config when applied via sync vs API (#81655 ) AM config applied via API would use the PostableUserConfig as the AM raw config and also the hash used to decide when the AM config has changed. However, when applied via the periodic sync the PostableApiAlertingConfig would be used instead. This leads to two issues: - Inconsistent hash comparisons when modifying the AM causing redundant applies. - GetStatus assumed the raw config was PostableUserConfig causing the endpoint to return correctly after a new config is applied via API and then nothing once the periodic sync runs. Note: Technically, the upstream GrafanaAlertamanger GetStatus shouldn't be returning PostableUserConfig or PostableApiAlertingConfig, but instead GettableStatus. However, this issue required changes elsewhere and is out of scope.	2 years ago
George Robinson	85b9edcd28	Alerting: Fix incorrect initialization of logger (#81099 )	2 years ago
Santiago	3afd94185c	Alerting: Add metric to check for default AM configurations (#80225 ) * Alerting: Add metric to check for default AM configurations * Use a gauge for the config hash * don't go out of bounds when converting uint64 to float64 * expose metric for config hash * update metrics after applying config	2 years ago
Santiago	a77ba40ed4	Alerting: Use the forked Alertmanager for remote secondary mode (#79646 ) * (WIP) Alerting: Use the forked Alertmanager for remote secondary mode * fall back to using internal AM in case of error * remove TODOs, clean up .ini file, add orgId as part of remote AM config struct * log warnings and errors, fall back to remoteSecondary, fall back to internal AM only * extract logic to decide remote Alertmanager mode to a separate function, switch on mode * tests * make linter happy * remove func to decide remote Alertmanager mode * refactor factory function and options * add default case to switch statement * remove ineffectual assignment	2 years ago
Santiago	73776f37eb	Alerting: Send state to the remote Alertmanager (#78538 ) * Alerting: Introduce a Mimir client as part of the Remote Alertmanager Mimir client that understands the new APIs developed for mimir. Very much a WIP still. * more wip * appease the linter * more linting * add more code * get state from kvstore, encode, send * send state to the remote Alertmanager, extract fullstate logic into its own function * pass kvstore to remote.NewAlertmanager() * refactor * add fake kvstore to tests * tests * use FileStore to get state * always log 'completed state upload' * refactor compareRemoteConfig * base64-encode the state in the file store * export silences and nflog filenames, refactor * log 'completed state/config upload...' regardless of outcome * add values to the state store in tests * address code review comments * log error from filestore --------- Co-authored-by: gotjosh <josue.abreu@gmail.com>	2 years ago
Santiago	a6b9b27673	Alerting: Remove OrgID() from the Alertmanager interface (#77398 )	2 years ago
Santiago	f9fc2e4568	Alerting: Remove ConfigHash() from the Alertmanager interface (#77134 )	2 years ago
Santiago	322a9c0b15	Alerting: Replace FileStore() for CleanUp() in the Alertmanager interface (#77126 ) Alerting: Remplace FileStore() for CleanUp() in the Alertmanager interface	2 years ago
Santiago	61cb26711e	Alerting: Fetch alerts from a remote Alertmanager (#75844 ) * Alerting: post alerts to the remote Alertmanager and fetch them * fix broken tests * Alerting: Add Mimir Backend image to devenv (blocks) * add alerting as code owner for mimir_backend block * Alerting: Use Mimir image to run integration tests for the remote Alertmanager * skip integration test when running all tests * skipping integration test when no Alertmanager URL is provided * fix bad host for mimir_backend * remove basic auth testing until we have an nginx image in our CI * add integration tests for alerts * fix tests * change SendCtx -> Send, add context.Context to Send, fix CI * add reover() for functions from the Prometheus Alertmanager HTTP client that could panic * add TODO to implement PutAlerts in a way that mimicks what Prometheus does * fix log format	2 years ago
Santiago	93b9f9b537	Alerting: Use interfaces for the Alertmanager (#73900 )	2 years ago
Santiago	ff9eff49bd	Alerting: Bump grafana/alerting and refactor the ImageStore/Provider to provide image URL/bytes (#70182 ) * implement alerting.images.Provider interface in our ImageStore * add URLExists() method to fakeConfigStore * make linter happy * update integration tests	3 years ago
George Robinson	f085e99d3c	Alerting: Add matchers metrics to Alertmanager (#69855 )	3 years ago
Matthew Jacobson	c16f1f5e99	Alerting: Fix provisioned templates being ignored by alertmanager (#69485 ) * Alerting: Fix provisioned templates being ignored by alertmanager Template provisioning sets the template in cfg.TemplateFiles while a recent change made it so that alertmanager reads cfg.AlertmanagerConfig.Templates instead. This change fixes the issue on both ends, by having provisioning set boths fields and reverts the change on the alertmanager side so that it uses cfg.TemplateFiles.	3 years ago
Alexander Weaver	0ed5d3bdf2	Revert "Alerting: Refactor the ImageStore/Provider to provide image URL/bytes" (#69265 ) Revert "Alerting: Refactor the ImageStore/Provider to provide image URL/bytes (#67693)" This reverts commit `72a187b0be`.	3 years ago
Santiago	72a187b0be	Alerting: Refactor the ImageStore/Provider to provide image URL/bytes (#67693 ) * (WIP) Refactor the ImageStore interface to work with our latest alerting repository * update alerting package * refactor, new URLExists method in ImageProvider * tests for the new methods * fix linter warnings * use alertingImages as an alias for grafana/alerting/images * logs about image uris and not found images * nerf image not found logs * extract duplicated code to getImageFromURI() method * refactor getImageFromURI() * add index on url * add comment about migration log * sync generated files	3 years ago
Sladyn	a06a5a7393	Alerting: Improve log messages (#67688 ) * Rename base logger and capatilize messages * Remove cflogger from config.go	3 years ago
Matthew Jacobson	91471ac7ae	Alerting: Template Testing API (#67450 )	3 years ago
Yuri Tseretyan	a8b4a4bb45	Alerting: Update alerting module to 20230418161049-5f374e58cb32 + refactoring (#66622 ) * update to alerting 20230418161049-5f374e58cb32 * rename renamed structs in https://github.com/grafana/alerting/pull/73 * update ValidateContactPoint to use BuildReceiverConfiguration * update logger factory according to changes * rewrite integration builder Co-authored-by: Santiago <santiagohernandez.1997@gmail.com>	3 years ago
Yuri Tseretyan	afd52d0866	Alerting: use alerting GrafanaReceiver and BuildReceiverConfiguration in Grafana (#65224 ) * replace receiver errors with one from alerting * add the converter to alerting models * update buildReceiverIntegration to accept GrafanaReceiver --------- Co-authored-by: George Robinson <george.robinson@grafana.com>	3 years ago
Yuri Tseretyan	e760f22402	Alerting: Use background context for maintenance function (#64065 )	3 years ago
Yuri Tseretyan	f066e8cdcd	Alerting: Update to alerting 20230203015918-0e4e2675d7aa (after refactoring) (#62823 ) * add alerting prefix to some packages from alerting that have similar names in prometheus alertmanager	3 years ago
Santiago	ba731f7865	Alerting: Mark AM configuration as applied (#61330 ) * Mark AM configuration as applied * add missing checks, make linter happy * fix deadlock, mark as valid on save and on load * mark configurations only if needed * check error after applyConfig() * code review comments * code review changes * more code review changes * clean HistoricConfigFromAlertConfig function	3 years ago
Serge Zaitsev	d6d4097567	Chore: Fix goimports grouping in alerting (#62424 ) * fix goimports * fix goimports order	3 years ago
gotjosh	0be920e61c	Alerting: Remove unused code after importing from grafana/alerting (#61869 ) * Alerting: Remove unused code after importing from grafana/alerting	3 years ago
Denis Limarev	e6dee8a723	Perfomance: Preallocate slices (#61580 )	3 years ago
gotjosh	e7cd6eb13c	Alerting: Use `alerting.GrafanaAlertmanager` instead of initialising Alertmanager components directly (#61230 ) * Alerting: Use `alerting.GrafanaAlertmanager` instead of initialising Alertmanager components directly	3 years ago
gotjosh	ddb85ad6ad	Use the `ClusterPeer` interface from grafana/alerting (#61409 ) * Use the Cluster interface from grafana/alerting	3 years ago
gotjosh	2d1faae0b5	Alerting Unification: Use `alerting.MaintenanceOptions` to configure silences and nflog (#61384 )	3 years ago
Denis Limarev	90badc8729	Performance: Add preallocation for some slices (#59593 )	3 years ago
George Robinson	2a291afbae	Alerting: Use consts from alerting package (#61241 )	3 years ago
George Robinson	d19d8c6625	Alerting: Update Alerting and Alertmanager to v0.25.1 (#61233 ) Update Alerting and Alertmanager to v0.25.1	3 years ago
Yuri Tseretyan	f990be58cb	Alerting: Use all notifiers from alerting repository (#60655 )	3 years ago
Yuri Tseretyan	35090c376c	Alerting: Replace VictorOps receiver with the one from alerting repository (#60543 ) * replace victorops with one from alerting * update other usages	3 years ago
Yuri Tseretyan	f0cabe14d5	Alerting: import Grafana alerting package and update usages (#60490 ) * update remaining notifiers to use alerting package	3 years ago
Yuri Tseretyan	9ad45aedcf	Alerting: replace usage of simplejson to json.RawMessage in NotificationChannelConfig (#60423 ) * introduce alias for json.RawMessage with name RawMessage. This is needed to keep raw JSON and implement a marshaler for YAML, which does not seem to be used but there are tests that fail. * replace usage of simplejson with RawMessage in NotificationChannelConfig * remove usage of simplejson in tests * change migration code to convert simplejson to raw message	3 years ago
Yuri Tseretyan	6637333748	Alerting: refactor notifiers to use package specific Logger interface (#60361 ) * introduce Logger interface local to channles + implementaton that wraps the Grafana logger * make NewFactoryConfig accept LoggerFactory * add logger field to FactoryConfig * update usages of log.Logger to internal interface	3 years ago
Yuri Tseretyan	de008005ce	Alerting: isolate ImageStore in notify package (#60353 )	3 years ago
Yuri Tseretyan	7c3ab4a715	Alerting: Remove dependency on Grafana notifications package in alerting notifiers (#60271 ) * create sender service interface and bridge to grafana notifier service * update notifiers to use local sender interface	3 years ago
Alexander Weaver	3ddb28bad9	Find-and-replace 'err' logs to 'error' to match log search conventions (#57309 )	3 years ago
Santiago	3c56fd8da0	Fix duplicated receivers in API response (#56829 )	3 years ago
Santiago	09f8e026a1	Alerting: Expose info about notification delivery errors in a new /receivers endpoint (#55429 ) * (WIP) switch to fork AM, first implementation of the API, generate spec * get receivers avoiding race conditions * use latest version of our forked AM, tests * make linter happy, delete TODO comment * update number of expected paths to += 2 * delete unused endpoint code, code review comments, tests * Update pkg/services/ngalert/notifier/alertmanager.go Co-authored-by: Matthew Jacobson <matthew.jacobson@grafana.com> * remove call to fmt.Println * clear naming for fields * shorter variable names in GetReceivers Co-authored-by: Matthew Jacobson <matthew.jacobson@grafana.com>	3 years ago
Joe Blubaugh	9e8efaa459	Alerting: Add stored screenshot utilities to the channels package. (#49470 ) Adds three functions: `withStoredImages` iterates over a list of models.Alerts, extracting a stored image's data from storage, if available, and executing a user-provided function. `withStoredImage` does this for an image attached to a specific alert. `openImage` finds and opens an image file on disk. Moves `store.Image` to `models.Image` Simplifies `channels.ImageStore` interface and updates notifiers that use it to use the simpler methods. Updates all pkg/alert/notifier/channels to use withStoredImage routines.	4 years ago
Joe Blubaugh	12c25759da	Alerting: Attach screenshot data to Slack notifications. (#49374 ) This change extracts screenshot data from alert messages via a private annotation `__alertScreenshotToken__` and attaches a URL to a Slack message or uploads the data to an image upload endpoint if needed. This change also implements a few foundational functions for use in other notifiers.	4 years ago
Joe Blubaugh	481a68cbf5	Unified Alerting: Make log message follow codebase convention. (#46881 ) 1. Keep log lines lower case. 2. The key-value pair arguments are not format argument for the string. 3. Always use the "err" key.	4 years ago
Joe Blubaugh	c5b39dd3cd	Unified Alerting, Issue 41156: Clean up expired silences. (#46740 ) Expired silences older than the retention period were not being cleaned up. The root problem was that notifier.Alertmanager overrides the Prometheus alert manager's silence maintenance function and was not calling Silences.GC() in the overriden function.	4 years ago
Jean-Philippe Quéméner	e135b8531a	Alerting: refactor receiver validation to be reusable (#46103 )	4 years ago
George Robinson	4e3a72fc2a	Add context.Context to AlertingStore (#45069 )	4 years ago
Serge Zaitsev	84a5910e56	Chore: Remove bus from ngalert (#44465 ) * pass notification service down to the notifiers * add ns to all notifiers * remove bus from ngalert notifiers * use smaller interfaces for notificationservice * attempt to fix the tests * remove unused struct field * simplify notification service mock * trying to resolve issues in the tests * make linter happy * make linter even happier * linter, you are annoying	4 years ago
Yuriy Tseretyan	ea478dec22	Alerting: Remove bridge between log15 and go-kit logger (#43769 ) * remove bridge between log15 and go-kit logger. * fix tests	4 years ago
idafurjes	56c3875bb9	Chore: Remove context.TODO (#43458 ) * Remove context.TODO() from services * Fix live test	4 years ago

1 2 3

124 Commits (ff916d9c15d38eead1ed93c4da2d7fc0c5e3b081)