From 3285d647e6b5092b018cfdcadde87c98c5e92597 Mon Sep 17 00:00:00 2001 From: virtuacoplenny Date: Wed, 11 Apr 2018 11:31:03 -0700 Subject: [PATCH] feat(feedback): tweak styling (#2791) - Green stars - Label for feedback box - Adjust margins/padding --- css/_variables.scss | 4 ---- css/modals/feedback/_feedback.scss | 10 +++------- lang/main.json | 3 ++- .../features/feedback/components/FeedbackDialog.web.js | 3 +-- 4 files changed, 6 insertions(+), 14 deletions(-) diff --git a/css/_variables.scss b/css/_variables.scss index 630e8df5f7..663ca52c5d 100644 --- a/css/_variables.scss +++ b/css/_variables.scss @@ -80,10 +80,6 @@ $feedbackInputBg: #fff; $feedbackTextColor: #000; $feedbackInputTextColor: #333; $feedbackInputPlaceholderColor: #777; -$rateStarLabelColor: #333; -$rateStarDefault: #ccc; -$rateStarActivity: #165ecc; -$rateStarSize: 34px; /** * Modals diff --git a/css/modals/feedback/_feedback.scss b/css/modals/feedback/_feedback.scss index 83773a3908..29977fe886 100644 --- a/css/modals/feedback/_feedback.scss +++ b/css/modals/feedback/_feedback.scss @@ -47,10 +47,6 @@ .feedback-dialog { .details { - margin-top: 20px; - padding-left: 60px; - padding-right: 60px; - textarea { min-height: 100px; } @@ -82,10 +78,10 @@ } .star-btn { - color: $rateStarDefault; + color: inherit; cursor: pointer; display: inline-block; - font-size: $rateStarSize; + font-size: 34px; outline: none; position: relative; text-decoration: none; @@ -94,7 +90,7 @@ &.active, &:hover, &.starHover { - color: $rateStarActivity; + color: #36B37E; }; } diff --git a/lang/main.json b/lang/main.json index 6600e6a674..9e98921926 100644 --- a/lang/main.json +++ b/lang/main.json @@ -506,7 +506,8 @@ "average": "Average", "bad": "Bad", "good": "Good", - "rateExperience": "Please rate your meeting experience.", + "detailsLabel": "Tell us more about it.", + "rateExperience": "Rate your meeting experience", "veryBad": "Very Bad", "veryGood": "Very Good" }, diff --git a/react/features/feedback/components/FeedbackDialog.web.js b/react/features/feedback/components/FeedbackDialog.web.js index e929dd0bdf..e8d4133016 100644 --- a/react/features/feedback/components/FeedbackDialog.web.js +++ b/react/features/feedback/components/FeedbackDialog.web.js @@ -224,9 +224,8 @@ class FeedbackDialog extends Component { autoFocus = { true } className = 'input-control' id = 'feedbackTextArea' - isLabelHidden = { true } + label = { t('feedback.detailsLabel') } onChange = { this._onMessageChange } - placeholder = { t('dialog.feedbackHelp') } shouldFitContainer = { true } value = { message } />