From 4eacbd9f61a2ab0baceb2359e7114b23252924d7 Mon Sep 17 00:00:00 2001 From: Leonard Kim Date: Wed, 12 Jul 2017 15:49:11 -0700 Subject: [PATCH] fix(tracks): remove mute and videotype listeners on track remove Listeners were set for when a track muted or changed its video type, but the listeners were never removed. This would could cause events to keep firing on the removed tracks, which would cause redux to fire and error because the tracks were no longer known. That the tracks still fire events after removal is another issue... --- react/features/base/tracks/actions.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/react/features/base/tracks/actions.js b/react/features/base/tracks/actions.js index 92df5eb7cd..6abd28decf 100644 --- a/react/features/base/tracks/actions.js +++ b/react/features/base/tracks/actions.js @@ -179,6 +179,9 @@ export function trackMutedChanged(track) { * @returns {{ type: TRACK_REMOVED, track: Track }} */ export function trackRemoved(track) { + track.removeAllListeners(JitsiTrackEvents.TRACK_MUTE_CHANGED); + track.removeAllListeners(JitsiTrackEvents.TRACK_VIDEOTYPE_CHANGED); + return { type: TRACK_REMOVED, track: {