Merge branch 'kkrisstoff-add/tip-randomiser'

9 years ago · 66fbc28385
parent 9a0d28720d 4bcd75f15c
commit 66fbc28385
3 changed files with 54 additions and 24 deletions
--- a/close.html
+++ b/close.html
@ -3,20 +3,12 @@
    <link rel="stylesheet" href="css/all.css"/>
    <!--#include virtual="title.html" -->
    <script><!--#include virtual="/interface_config.js" --></script>
-    <script>function translateStr(id, msg) {
-        var div = document.getElementById(id);
-        div.innerHTML = msg;
-    }
-    function translate() {
-        translateStr('hintMessage',
-            'You can pin participants by clicking on their thumbnails');
-    }
-    </script>
+    <script src="close.js"></script>
 </head>
-<body onload="translate();">
+<body>
 <div class="redirectPageMessage">
    <div class="thanks-msg">
-        <p id="thanksMessage">Thank you for your feedback!</p>
+        <p>Thank you for your feedback!</p>
    </div>
    <div class="hint-msg">
        <p>
@ -27,4 +19,4 @@
    </div>
 </div>
 </body>
-</html>
+</html>
--- a/close.js
+++ b/close.js
@ -0,0 +1,48 @@
+/* global interfaceConfig */
+//list of tips
+var hints = [
+    "You can pin participants by clicking on their thumbnails.",// jshint ignore:line
+    "You can tell others you have something to say by using the \"Raise Hand\" feature",// jshint ignore:line
+    "You can learn about key shortcuts by pressing Shift+?",// jshint ignore:line
+    "You can learn more about the state of everyone's connection by hovering on the bars in their thumbnail",// jshint ignore:line
+    "You can hide all thumbnails by using the button in the bottom right corner"// jshint ignore:line
+];
+
+/**
+ * Get a random hint meessage from hint array.
+ *
+ * @return {string} the hint message.
+ */
+function getHint(){
+    var l = hints.length - 1;
+    var n = Math.round(Math.random() * l);
+
+    return hints[n];
+}
+
+/**
+ * Inserts text message
+ * into DOM element
+ *
+ * @param id {string} element identificator
+ * @param msg {string} text message
+ */
+// eslint-disable-next-line no-unused-vars
+function insertTextMsg(id, msg){
+    var el = document.getElementById(id);
+
+    if (el)
+        el.innerText = msg;
+}
+
+/**
+ * Sets the hint and thanks messages. Will be executed on load event.
+ */
+function onLoad() {
+    //Works only for close2.html because close.html doesn't have this element.
+    insertTextMsg('thanksMessage',
+        'Thank you for using ' + interfaceConfig.APP_NAME);
+    insertTextMsg('hintMessage', getHint());
+}
+
+window.onload = onLoad;
--- a/close2.html
+++ b/close2.html
@ -3,19 +3,9 @@
    <link rel="stylesheet" href="css/all.css"/>
    <!--#include virtual="title.html" -->
    <script><!--#include virtual="/interface_config.js" --></script>
-    <script>function translateStr(id, msg) {
-        var div = document.getElementById(id);
-        div.innerHTML = msg;
-    }
-    function translate() {
-        translateStr('thanksMessage',
-            'Thank you for using ' + interfaceConfig.APP_NAME);
-        translateStr('hintMessage',
-            'You can pin participants by clicking on their thumbnails');
-    }
-    </script>
+    <script src="close.js"></script>
 </head>
-<body onload="translate();">
+<body>
    <div class="redirectPageMessage">
        <div class="thanks-msg">
            <p id="thanksMessage"></p>