From ba7ed83d48d42d1b3b58da6edb59f7029b682927 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sa=C3=BAl=20Ibarra=20Corretg=C3=A9?= Date: Fri, 26 Jan 2024 14:00:50 +0100 Subject: [PATCH] feat(recording) stop transcription when recording is stopped --- .../recording/components/Recording/AbstractRecordButton.ts | 3 ++- .../components/Recording/AbstractStopRecordingDialog.ts | 4 ++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/react/features/recording/components/Recording/AbstractRecordButton.ts b/react/features/recording/components/Recording/AbstractRecordButton.ts index 2c55d83e42..0f7a0f08d2 100644 --- a/react/features/recording/components/Recording/AbstractRecordButton.ts +++ b/react/features/recording/components/Recording/AbstractRecordButton.ts @@ -125,6 +125,7 @@ export default class AbstractRecordButton

extends AbstractButt * }} */ export function _mapStateToProps(state: IReduxState) { + const _isTranscribing = state['features/transcribing'].isTranscribing; const { disabled: _disabled, tooltip: _tooltip, @@ -134,7 +135,7 @@ export function _mapStateToProps(state: IReduxState) { return { _disabled, _isRecordingRunning: Boolean(getActiveSession(state, JitsiRecordingConstants.mode.FILE)) - || LocalRecordingManager.isRecordingLocally(), + || LocalRecordingManager.isRecordingLocally() || _isTranscribing, _tooltip, visible }; diff --git a/react/features/recording/components/Recording/AbstractStopRecordingDialog.ts b/react/features/recording/components/Recording/AbstractStopRecordingDialog.ts index e66551f760..dc8f029548 100644 --- a/react/features/recording/components/Recording/AbstractStopRecordingDialog.ts +++ b/react/features/recording/components/Recording/AbstractStopRecordingDialog.ts @@ -7,6 +7,7 @@ import { IReduxState, IStore } from '../../../app/types'; import { IJitsiConference } from '../../../base/conference/reducer'; import { JitsiRecordingConstants } from '../../../base/lib-jitsi-meet'; import { setVideoMuted } from '../../../base/media/actions'; +import { setRequestingSubtitles } from '../../../subtitles/actions.any'; import { stopLocalVideoRecording } from '../../actions'; import { getActiveSession } from '../../functions'; import { ISessionData } from '../../reducer'; @@ -89,6 +90,9 @@ export default class AbstractStopRecordingDialog

} } + // TODO: this should be an action in transcribing. -saghul + this.props.dispatch(setRequestingSubtitles(false, false, null)); + return true; }