From d2c85ada1b175fc9fc657d821d74fd005ea53d12 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sa=C3=BAl=20Ibarra=20Corretg=C3=A9?= Date: Wed, 3 Jul 2019 13:09:49 +0200 Subject: [PATCH] android: fix deadlock in uncaught exception handler The app is about to crash at that stage so it was a moot point to try to leave the conference anyway. Stopping ConnectionServers is still a good idea though, since a crash may leave the device in a bad state otherwise. --- .../jitsi/meet/sdk/JitsiMeetUncaughtExceptionHandler.java | 7 ------- 1 file changed, 7 deletions(-) diff --git a/android/sdk/src/main/java/org/jitsi/meet/sdk/JitsiMeetUncaughtExceptionHandler.java b/android/sdk/src/main/java/org/jitsi/meet/sdk/JitsiMeetUncaughtExceptionHandler.java index d1298cd1ca..77cfc8f6db 100644 --- a/android/sdk/src/main/java/org/jitsi/meet/sdk/JitsiMeetUncaughtExceptionHandler.java +++ b/android/sdk/src/main/java/org/jitsi/meet/sdk/JitsiMeetUncaughtExceptionHandler.java @@ -39,13 +39,6 @@ class JitsiMeetUncaughtExceptionHandler implements Thread.UncaughtExceptionHandl public void uncaughtException(Thread t, Throwable e) { Log.e(this.getClass().getSimpleName(), "FATAL ERROR", e); - // Terminate all conferences - for (BaseReactView view: BaseReactView.getViews()) { - if (view instanceof JitsiMeetView) { - ((JitsiMeetView) view).leave(); - } - } - // Abort all ConnectionService ongoing calls if (AudioModeModule.useConnectionService()) { ConnectionService.abortConnections();