585 Commits (0817482b9c0883fac45ca8df3113a2e5f3963a96)

Author	SHA1	Message	Date
Saúl Ibarra Corretgé	0817482b9c	flow: tame the beast	7 years ago
Saúl Ibarra Corretgé	9ac5aafe10	react: remove custom Fragment ... Fragment now works on both React and React Native, so use it.	7 years ago
Lyubo Marinov	efc9cc9f50	[RN] Update react-native to 0.55.4 (continued)	7 years ago
Leonard Kim	57f7abc6dd	ref(video-layout): get dominant speaker state from redux ... Instead of keeping dominant speaker locally, get it from redux and be updated when the dominant speaker changes. This is in an attempt to mimic the video layout being reactified and connected to redux.	7 years ago
Bettenbuk Zoltan	6a1e9e256d	[RN] Make the calendar the default tab when there are calendar entries fetched.	7 years ago
paweldomas	dbd1091364	ref: use getCurrentConference ... Try to use the getCurrentConference function wherever the indention is to check for the current conference.	7 years ago
Guus der Kinderen	acc41e6d0b	feat(toolbar): add 'always-visibile' config option ... The visibility of the toolbar can be toggled by interacting with the main screen. This change allows the toolbar to be configured to be 'always visible'. This voids the 'toggle' functionality.	7 years ago
Saúl Ibarra Corretgé	4d21c28421	feat(conference): don't add hidden participants to redux ... This includes recording agents, for example.	7 years ago
Bettenbuk Zoltan	118250750a	[RN] Add VideoQualityLabel indicator for mobile	7 years ago
Bettenbuk Zoltan	9eb9306e87	[RN] Implement web's CircularLabel component for mobile	7 years ago
Bettenbuk Zoltan	5579464951	[RN] WelcomeScreen post-merge changes	7 years ago
Lyubo Marinov	693b1c392f	Fix joining a locked room	7 years ago
Saúl Ibarra Corretgé	bbf505c076	ref(base/conference): simplify code ... Simplify parts of the logic introduced in 11b7144ad0. Specificaly, using all the state change avoiding functions doesn't give us much since we need to copy the state for sure.	7 years ago
paweldomas	7186a9c79c	fix(base/participants): ensure default local id outside of conference ... Makes sure that whenever a conference is left or switched, the local participant's id will be equal to the default value. The problem fixed by this commit is a situation where the local participant may end up sharing the same ID with it's "ghost" when rejoining a disconnected conference. The most important and easiest to hit case is when the conference is left after the CONFERENCE_FAILED event. Another rare and harder to encounter in the real world issue is where CONFERENCE_LEFT may come with the delay due to it's asynchronous nature. The step by step scenario is as follows: trying to leave a conference, but the network is not doing well, so it takes time, requests are timing out. After getting back to the welcome page the the CONFERENCE_LEFT has not arrived yet. The same conference is joined again and the load config may timeout, but it will be read from the cache. Now the network gets better and conference is joining which results in our ghost participant added to the redux state. At this point there's the root issue: two participants with the same id, because the local one was neither cleared nor set to the new one yet (PARTICIPANT_JOINED come, before CONFERENCE_JOINED where we adjust the id). Then comes CONFERENCE_JOINED and we try to update our local id. We're updating the ID of both ghost and local participant. It could be also that the delayed CONFERENCE_LEFT comes for the old conference, but it's too late and it would update the id for both participants. The approach here reasons that the ID of the local participant may be reset as soon as the local participant and, respectively, her ID is no longer involved in a recoverable JitsiConference of interest to the user and, consequently, the app. Co-authored-by: Pawel Domas <pawel.domas@jitsi.org> Co-authored-by: Lyubo Marinov <lmarinov@atlassian.com>	7 years ago
Lyubo Marinov	c672ffd435	Refine PARTICIPANT_LEFT for ID collisions ... If the ID of a remote participant was the same as the ID of the local participant (across multiple conferences), removing the remote participant on PARTICIPANT_LEFT would remove the local participant. Like the preceding commit "ref(base/conference): clear the 'conference' field on WILL_LEAVE", this commit is part of the story how we are to deal with conferences which take noticeable time to leave.	7 years ago
Lyubo Marinov	8cfc83f18c	Protect against late PARTICIPANT_JOINED ... Like the preceding commit "ref(base/conference): clear the 'conference' field on WILL_LEAVE", this commit is part of the story how we are to deal with conferences which take noticeable time to leave. If a leave is delayed and the leaving JitsiConference manages to sneak a PARTICIPANT_JOINED in, it may create a remote participant who even collides with the local participant.	7 years ago
Lyubo Marinov	fa9549582f	Fix JitsiConference access ... With so many abstractions called conference, I'm not surprised I made a mistake and my reviewer didn't catch it. As we are transitioning from remote participants identified by ID alone to an ID-conference pair, the subsequent commits "Protect against late PARTICIPANT_JOINED" and "Refine PARTICIPANT_LEFT for ID collisions" caught the error.	7 years ago
paweldomas	11b7144ad0	ref(base/conference): clear the 'conference' field on WILL_LEAVE ... Pawel Domas said: The conference state field is referring to the current conference in progress, so it feels like this field should be cleared as soon as we declare that the conference is being left and the asynchronous process of leaving the conference starts (which happens on CONFERENCE_WILL_LEAVE). Lyubo Marinov said: Merely setting conference to undefined is incomplete because there are other redux state properties associated with conference. What we're doing here is redefining the redux action CONFERENCE_WILL_LEAVE: The redux action CONFERENCE_WILL_LEAVE represents the order of the user to leave a JitsiConference instance. From the user's perspective, there's no going back (with respect to the instance itself). The app will perform due clean-up like leaving the associated room, but the instance is no longer the focus of the attention of the user and, consequently, the app. Now CONFERENCE_LEFT and CONFERENCE_WILL_LEAVE have more in common than before and we can do a much better job by expressing the common parts in source code. Additionally, our source code can be rewritten to better express the meaning of any of these two actions. Co-authored-by: Pawel Domas <pawel.domas@jitsi.org> Co-authored-by: Lyubo Marinov <lmarinov@atlassian.com>	7 years ago
Lyubo Marinov	92fee790f2	Fix jsdoc	7 years ago
Daniel Ornelas	72487fa7c7	[iOS] Custom CallKit display name ... Add ability to provide a display name in the configOverwrite object that when available it will be used to customize the name of the meeting in callkit screen and recent call list. Co-authored-by: Daniel Ornelas <daniel.ob64@gmail.com> Co-authored-by: Lyubo Marinov <lmarinov@atlassian.com>	7 years ago
hristoterezov	3dbb663922	feat(call-flows): Add config property for enabling call flows. (#3031)	7 years ago
Lyubo Marinov	592305df74	[RN] Fix processing outdated loadConfig requests (continued) ... Co-authored-by: Lyubo Marinov <lmarinov@atlassian.com> Co-authored-by: Paweł Domas <pawel.domas@jitsi.org>	7 years ago
Saúl Ibarra Corretgé	357b206831	[RN] Fix processing outdated loadConfig requests ... This fix is based on storing the location URL object we are loading the configuration for in the redux store. Once the config has been loaded (or it has failed, for that matter!) we'll check if the current "config URL" is the same we set, and discard the old one if they don't match.	7 years ago
Saúl Ibarra Corretgé	d557a6505d	[RN] Fix handling XMPP connection failures ... After the connection is established, it can either be properly disconnected or fail. We need to make sure to be listening for events for either.	7 years ago
hristoterezov	8b91afd80d	fix(invite-sounds): Don't play joined sound for the poltergeist.	7 years ago
hristoterezov	d89227829f	feat(invite-sounds): Add expired and rejected sounds.	7 years ago
Lyubo Marinov	ee9fcbb735	Remove remote participants who are no longer of interest ... The Jitsi Meet app always has at most 1 conference of primary interest. It may have to juggle with 2 JitsiConference instances at the same time if 1 is in the process of being left and one is joining/joined. But the one which is joining or joined (which we call conference in the features/base/conference redux state) is the one "of interest", the other one is "clean up". Consequently, the remote participants of the conference "of interest" are the remote participants "of interest" and the others are "clean up". In order to reduce the time during which there may be multiplying remote thumbnails, clean the remote participants who are no longer "of interest" up.	7 years ago
Lyubo Marinov	db21e97c19	StateListenerRegistry ... "Middleware" redux state changes, not actions.	7 years ago
Lyubo Marinov	8cd2bd272b	Reduce direct read access to the features/base/participants redux state ... As part of the work on fixing the problem with the multiplying thumbnails, we've associated remote participant w/ JitsiConference. However, there are periods of time when multiple JitsiConferences are in the redux state (and that period is going to be shorted by StateListenerRegistry). In order to give more control to the feature base/participants, reduce the occurrences of direct access to the features/base/participants redux state and utilize the feature's existing read access functions. Which will allow us in the future to enhance these functions to access participants which are relevant to the current conference of interest to the user only.	7 years ago
Lyubo Marinov	771d60f954	Associate remote participant w/ JitsiConference (_UPDATED) ... The commit message of "Associate remote participant w/ JitsiConference (_JOINED)" explains the motivation for this commit. Practically, _JOINED and _LEFT combined with "Remove remote participants who are no longer of interest" should alleviate the problem with multiplying remote participants to an acceptable level of annoyance. Technically though, a remote participant cannot be identified by an ID only. The ID is (somewhat) "unique" in the context of a single JitsiConference instance. So in order to not have to scratch our heads over an obscure corner, racing case, it's better to always identify remote participants by the pair id-conference. Unfortunately, that's a bit of a high order given the existing source code. So I've implemented the cases which are the easiest so that new source code written with participantUpdated is more likely to identify a remote participant with the pair id-conference. Additionally, the commit "Reduce direct read access to the features/base/participants redux state" brings more control back to the functions of the feature base/participants so that one day we can (if we choose to) do something like, for example: If getParticipants is called with a conference, it returns the participants from features/base/participants who are associated with the specified conference. If no conference is specified in the function call, then default to the conference which is the primary focus of the app at the time of the function call. Added to the above, this should allow us to further reduce the cases in which we're identifying remote participants by id only and get us even closer to a more "predictable" behavior in corner, racing cases.	7 years ago
Lyubo Marinov	37cd5bb5b9	Associate remote participant w/ JitsiConference (_LEFT) ... The commit message of "Associate remote participant w/ JitsiConference (_JOINED)" explains the motivation for this commit.	7 years ago
Lyubo Marinov	983e62ffe9	Associate remote participant w/ JitsiConference (_JOINED) ... The plan set in motion here is to associate remote participants with the JitsiConference instances that created them in order to be able to remove remote participants when a JitsiConference is no longer the primary focus of the jitsi-meet app. And that's supposed to alleviate a problem with multiplying remote thumbnails. Doing all of the above in a single commit is a bit of a high order. So I'm splitting the whole into multiple successive commits for the purposes of observability, comprehension. Each commit is supposed to be safe even if subsequent commits are not accepted, are reverted, whatever. Obviously, without the successive commits, a commit may be "unused". One of the important pieces of the multiplying remote thumbnails "fix" offered is removing remote participants who are no longer of interest i.e. PARTICIPANT_LEFT. But in order for _LEFT to be implemented, _JOINED must be implemented first.	7 years ago
Lyubo Marinov	fcca15c827	Coding style	7 years ago
Saúl Ibarra Corretgé	bbb1dce42a	[RN] Simplify styles which fill the parent view ... Turns out React Native offers an object with the following definition: { bottom: 0, left: 0, position: 'absolute', right: 0, top: 0 }	7 years ago
Saúl Ibarra Corretgé	83ede66037	feat(toolbox): add disabledStyles to AbstractButton ... It allows for specifying an override style collection which is applied when the button is disabled.	7 years ago
Saúl Ibarra Corretgé	2128c84212	[RN] Add utility function to combine 2 sets of styles	7 years ago
Saúl Ibarra Corretgé	7012c77fe9	feat(toolbox): add ability to specify a toggled label on AbstractButton	7 years ago
Saúl Ibarra Corretgé	99b5a41269	feat(toolbox): add ability to run a handler after click to AbstractButton	7 years ago
Lyubo Marinov	22ce001f14	Coding style: commends, formatting, sorting order	7 years ago
paweldomas	9650404099	fix(base/conference): leave a failed conference ... Because a conference can fail before or after it's joined it must be "left" in order to release any allocated resources like peerconnections, tracks and all the other things.	7 years ago
paweldomas	7704809c4c	feat(base/connection): log leave failure reason ... Because there are multiple reasons on why a conference.leave() may fail it's helpful to know if and why it happened.	7 years ago
hristoterezov	9131d2448d	ref(i18next): Remove the base/config dependancy.	7 years ago
Zoltan Bettenbuk	b57dad576a	feat(participants): add isLocalParticipantModerator utility method	7 years ago
Saúl Ibarra Corretgé	494e8eb8d9	[RN] Set the local user ID on CONFERENCE_WILL_JOIN ... Doing so in CONFERENCE_JOINED is too late because if we are moderators that event will come first and we won't know what ID to match it with. This is safe because our local ID is created early.	7 years ago
hristoterezov	add89e2488	fix(dial-in-info): Qiuck fix of JitsiMeetJS undefined error.	7 years ago
Lyubo Marinov	df8eb36d0e	Coding style: comments	7 years ago
Saúl Ibarra Corretgé	f54f5df428	[RN] Implement a new UI for the Toolbox ... - 5 buttons in the (now single) toolbar - Overflow menu in the form of a BottomSheet - Filmstrip on the right when in wide mode	7 years ago
hristoterezov	c344a83376	Outgoing call ringtones (#2949) ... * fix(PresenceLabel): Use translated strings for the presence label. * feat(sounds): Implements loop and stop functionality. * feat(invite): Add ringtones. * fix(invite): Code style issues.	7 years ago
virtuacoplenny	ee74f11c3d	feat(recording): frontend logic can support live streaming and recording (#2952) ... * feat(recording): frontend logic can support live streaming and recording Instead of either live streaming or recording, now both can live together. The changes to facilitate such include the following: - Killing the state storing in Recording.js. Instead state is stored in the lib and updated in redux for labels to display the necessary state updates. - Creating a new container, Labels, for recording labels. Previously labels were manually created and positioned. The container can create a reasonable number of labels and only the container itself needs to be positioned with CSS. The VideoQualityLabel has been shoved into the container as well because it moves along with the recording labels. - The action for updating recording state has been modified to enable updating an array of recording sessions to support having multiple sessions. - Confirmation dialogs for stopping and starting a file recording session have been created, as they previously were jquery modals opened by Recording.js. - Toolbox.web displays live streaming and recording buttons based on configuration instead of recording availability. - VideoQualityLabel and RecordingLabel have been simplified to remove any positioning logic, as the Labels container handles such. - Previous recording state update logic has been moved into the RecordingLabel component. Each RecordingLabel is in charge of displaying state for a recording session. The display UX has been left alone. - Sipgw availability is no longer broadcast so remove logic depending on its state. Some moving around of code was necessary to get around linting errors about the existing code being too deeply nested (even though I didn't touch it). * work around lib-jitsi-meet circular dependency issues * refactor labels to use html base * pass in translation keys to video quality label * add video quality classnames for torture tests * break up, rearrange recorder session update listener * add comment about disabling startup resize animation * rename session to sessionData * chore(deps): update to latest lib for recording changes	7 years ago
Saúl Ibarra Corretgé	bce2438471	feat(toolbox): rename label / tooltip getters in ToolboxItem	7 years ago