60 Commits (5e01abf6fbefe882448e5e133f3a7055438546ac)

Author	SHA1	Message	Date
Lyubo Marinov	003eb68e28	Flow, coding style	8 years ago
Lyubo Marinov	f53c79ab24	Flow, coding style	8 years ago
Lyubo Marinov	dfebd692f3	eslint 4.8.0 ... ESLint 4.8.0 discovers a lot of error related to formatting. While I tried to fix as many of them as possible, a portion of them actually go against our coding style. In such a case, I've disabled the indent rule which effectively leaves it as it was before ESLint 4.8.0. Additionally, remove jshint because it's becoming a nuisance with its lack of understanding of ES2015+.	8 years ago
Lyubo Marinov	4bf19d73fd	[RN] Fix documentation comments ... * Javadoc introduced @code as a replacement of <code> and <tt> which is better aligned with other javadoc tags such as @link. Use it in the Java source code. If we switch to Kotlin, then we'll definitely use Markdown. * There are more uses of @code in the JavaScript source code than <tt> so use @code for the sake of consistency. Eventually, I'd rather we switch to Markdown because it's easier on my eyes. * Xcode is plain confused by @code and @link. The Internet says that Xcode supports the backquote character to denote the beginning and end of a string of characters which should be formatted for display as code but it doesn't work for me. <tt> is not rendered at all. So use the backquote which is rendered itself. Hopefully, if we switch to Markdown, then it'll be common between JavaScript and Objective-C source code.	8 years ago
Lyubo Marinov	1ea62215f6	[RN] Increase contrast and consistency in LoadingIndicator use cases	8 years ago
Saúl Ibarra Corretgé	ca13a9b914	[RN] LoadingIndicator on WelcomePage ... It will replace the "Join" text button while appNavigate lasts. Note about the implementation: when appNavigate completes the component may have been unmounted and thus we cannot touch its state. In order to avoid this problem I added a 'mounted' instance variable which gets set and reset in componentWillMount / Unmount respectively. This is to avoid using isMounted, which is highly discouraged.	8 years ago
Saúl Ibarra Corretgé	35da39becf	[RN] NetworkActivityIndicator ... The basic indicator is extracted into a LoadingIndicator component, which then NetworkActivityIndicator displays (or not) based on network activity.	8 years ago
Lyubo Marinov	ed53f54628	[RN] Fix the visibility of the local video on the WelcomePage	8 years ago
Lyubo Marinov	a7ee632f43	[RN] LocalVideoTrackUnderlay ... Implement a React Component which displays children as an overlay of local video. The WelcomePage implemented such a component inside of it among other WelcomePage-specific logic so I split LocalVideoTrackUnderlay out of it. The new Component is used on the BlankPage which may be displayed in the future not only when the WelcomePage is disabled but also when there are long running network requests, for example.	8 years ago
Lyubo Marinov	b304ad5808	[RN] Weaken the coupling between WelcomePage and AbstractWelcomePage	8 years ago
Lyubo Marinov	45a1ae26ca	[RN] Prepare to display BlankPage more ... For example, while config.js and other files are being loaded before the navigation to Conference is feasible.	8 years ago
Lyubo Marinov	7f8e8177d0	[RN] Refactor "Keep track of ongoing network requests" and "Show a progress indicator in the BlankPage" ... I'm not saying that the two commits in question were wrong or worse than what I'm offering. Anyway, I think what I'm offering brings: * Compliance with expectations i.e. the middleware doesn't compute the next state from the current state, the reducer does; * Clarity and/or simplicity i.e. there's no global variable (reqIndex), there's no need for the term "index" (a.k.a "reqIndex") in the redux store. * By renaming net-interceptor to network-activity feels like it's preparing the feature to implement a NetworkActivityIndicator React Component which will take on more of the knowledge about the specifics of what is the network activity redux state exactly, is it maintained by interception or some other mechanism, and abstracts it in the feature itself allowing outsiders to merely render a React Component.	8 years ago
Saúl Ibarra Corretgé	e33030582f	[RN] Show a progress indicator in the BlankPage ... It will only be shown when there are ongoing network requests.	8 years ago
Lyubo Marinov	0b8c12de0e	Simplify route navigation ... I see it as the first step in simplifying the route navigate of the JavaScript app by removing BlankWelcomePage from _getRouteToRender. From a faraway point of view, the app is at the route at which it is not in a conference. Historically, the route was known as the Welcome page. But mobile complicated the route by saying that actually it may not want to see the room name input and join button. Additionally, I renamed BlankWelcomePage to BlankPage because I don't think of it as a WelcomePage alternative but rather as a more generic BlankPage which may be utilized elsewhere in the future. I plan for the next steps to: * Merge Entryway, _interceptComponent, and _getRouteToRender in one React Component rendered by AbstractApp so that the whole logic is in one file; * Get rid of RouteRegistry and routes.	8 years ago
Lyubo Marinov	cb5b93fb6e	Switch to prop-types	8 years ago
Lyubo Marinov	7114614697	Remove obsolete workaround	8 years ago
Saúl Ibarra Corretgé	9bca0e3b3d	[RN] Create tracks right when they are required ... When do we need tracks? - Welcome page (only the video track) - Conference (depends if starting with audio / video muted is requested) When do we need to destroy the tracks? - When we are not in a conference and there is no welcome page In order to accommodate all the above use cases, a new component is introduced: BlankWelcomePage. Its purpose is to take the place of the welcome page when it is disabled. When this component is mounted local tracks are destroyed. Analogously, a video track is created when the (real) welcome page is created, and all the desired tracks are created then the Conference component is created. What are desired tracks? These are the tracks we'd like to use for the conference that is about to happen. By default both audio and video are desired. It's possible, however, the user requested to start the call with no video/audio, in which case it's muted in base/media and a track is not created. The first time the app starts (with the welcome page) it will request permission for video only, since there is no need for audio in the welcome page. Later, when a conference is joined permission for audio will be requested when an audio track is to be created. The audio track is not destroyed when the conference ends. Yours truly thinks this is not needed since it's a stopped track which is not using system resources.	8 years ago
Lyubo Marinov	e7fc4739c4	Fixes jsdocs	8 years ago
Lyubo Marinov	25ec8ac6a7	Prepare for eslint 4	8 years ago
Lyubo Marinov	ca94563c51	[RN] Coding style ... The files styles.js are used (pretty much) on React Native only and each of them exports 1 name. Export it as default to cut down on source code.	8 years ago
Lyubo Marinov	409255f056	[React] Cross-platform Components ... Introduce certain React Components which may be used to write cross-platform source code such as Audio like Web's audio, Container like Web's div, Text like Web's p, etc.	8 years ago
Lyubo Marinov	4dc658c270	Fix 'Missing JSDoc comment  require-jsdoc'	8 years ago
Lyubo Marinov	69f8cf7836	Fix the disabling of the Welcome page	8 years ago
Lyubo Marinov	3db557e2c9	Move roomnameGenerator.js out of features/base/util ... Over time features/base/util became a bucket where people seemed to dump just about anything they couldn't think of a better place for. That's a trend I don't like encouraging. Given that roomnameGenerator.js is currently used in features/welcome only, I'm fine with moving it there for the greater good.	8 years ago
Saúl Ibarra Corretgé	9c544c0a4b	eslint: remove no longer needed comment ... jsdocs were added, remove old comment which no longer applies.	8 years ago
Lyubo Marinov	18368fefaa	Comply w/ coding style	8 years ago
damencho	c361e1e31a	Translate react strings. ... Split language detectors to be web/native dependent. Take care of strings that contain html.	8 years ago
Saúl Ibarra Corretgé	2f388dfb6a	Fix warning about missing key prop ... When rendering using a for loop each child whould have a key prop.	8 years ago
Lyubomir Marinov	e599491583	Remove duplication	8 years ago
Saúl Ibarra Corretgé	573ca97b6c	[RN] Add workaround for Android view clipping ... Looks like Android gets confused as to what surface to blit when we hide or show toolbars. Setting a border on the container, seems to force the entire area to blit properly. Other attempted approaches, with no success: - zIndex of -100 - width and height of 0 - opacity of 0 and setting 'disabled' on touch containers This patch applies the workaround in the welcome page and conference containers.	8 years ago
Lyubomir Marinov	8509efc8af	Make the Web app aware of its context root	8 years ago
Lyubomir Marinov	fdc96044ad	[RN] App-specific URL scheme	8 years ago
Lyubomir Marinov	366b2f1374	Simplify: Remove react/features/base/navigator	8 years ago
Lyubomir Marinov	2189ab7ee6	Consistent naming of react-redux's mapStateToProps ... Until we make a decision on access modifier hints and adopt a respective coding style, consistency is king.	8 years ago
Lyubomir Marinov	3aff812ee2	Consistent naming of Component props mapped from the Redux state ... Until we make a decision on access modifier hints and adopt a respective coding style, consistency is king.	8 years ago
Lyubomir Marinov	b8a6eb4768	Fix the checkbox to disable the Welcome page ... Recently, we reimplemented the Welcome page in React. Unfortunately, we broke the checkbox that enables/disables the Welcome page and it would allow checking but wouldn't allow unchecking.	8 years ago
Lyubomir Marinov	6efad1348a	Fix the display of watermarks in film strip-only mode ... Recently, we reimplemented the watermarks in React. Unfortunately, we didn't take into account film strip-only mode. Additionally, we duplicated watermark-related source code on the Welcome and Conference pages.	8 years ago
Lyubomir Marinov	0912dbf130	Remove duplication, simplify, comply with coding style	8 years ago
Lyubomir Marinov	2f01746c55	Remove duplication, simplify, comply with coding style	8 years ago
Saúl Ibarra Corretgé	8a30d44042	[RN] Disable autofocus on the welcome screen ... This prevents the keyboard from showing up right when the app opens.	9 years ago
Ilya Daynatovich	ed1aa700d0	remove asterisk symbol from jsdoc	9 years ago
Ilya Daynatovich	58b5e1748f	editions after rebase	9 years ago
Ilya Daynatovich	c570b80d7b	moved app initialization to react app	9 years ago
damencho	2c5a5816c4	Adds some accessibilityLabels that can be used for testing.	9 years ago
yanas	8d90a7d091	Fix(react): Fixes black border on text input in welcome page	9 years ago
yanas	5e377d3694	Fix underlining on welcom text input on android	9 years ago
Lyubomir Marinov	4810249301	Simplify. Comply w/ coding style.	9 years ago
Ilya Daynatovich	984a6519fc	Move welcome page logic from jquery to react	9 years ago
Lyubomir Marinov	a5773f1d0b	[RN] Links to Send feedback and Privacy (policy)	9 years ago
Lyubomir Marinov	96a18ab2d5	[RN] Change 'Privacy Policty' and 'Terms of Service' to 'Terms and Conditions'	9 years ago