jitsi-meet

Commit Graph

Author	SHA1	Message	Date
Lyubo Marinov	e5cc8cd32b	[RN] locationURL instead of inviteURL The value of inviteURL is derived from locationURL by removing the hash and query/search params in order to make it fit for display and/or public purposes. The Jitsi Meet SDK consumers do not fall into that category and our intention is to provide them with the URL they used with JitsiMeetView.openURL(URL) anyway. Also rewrites to remove repetition. I'm not saying the new source code is better really but at least I got to examine it and comment on some of its weaknesses.	9 years ago
Saúl Ibarra Corretgé	a075f24000	[RN] Add conference events to native SDKs The current implementation doesn't use the API and Transport modules. This is due to the fact that they are too tied to APP at the moment, which is web only. Once API is refactored and moved into the Redux store this will be adjusted, though it's unlikely that the lowest level React Native module (ExternalAPI) changes drastically. This commit also introduces a stopgap limitation of only allowing a single instance for JitsiMeetView objects on both Android and iOS. React Native doesn't really play well with having multiple instances of the same modules on the same bridge, since they behave a bit like singletons. Even if we were to use multiple bridges, some features depend on system-level global state, such as the AVAudioSession mode or Android's immersive mode. Further attempts will be made at lifting this limitation in the future, though.	9 years ago

Author

SHA1

Message

Date

Lyubo Marinov

e5cc8cd32b

[RN] locationURL instead of inviteURL

The value of inviteURL is derived from locationURL by removing the hash
and query/search params in order to make it fit for display and/or
public purposes. The Jitsi Meet SDK consumers do not fall into that
category and our intention is to provide them with the URL they used
with JitsiMeetView.openURL(URL) anyway.

Also rewrites to remove repetition. I'm not saying the new source code
is better really but at least I got to examine it and comment on some of
its weaknesses.

9 years ago

Saúl Ibarra Corretgé

a075f24000

[RN] Add conference events to native SDKs

The current implementation doesn't use the API and Transport modules. This is
due to the fact that they are too tied to APP at the moment, which is web only.

Once API is refactored and moved into the Redux store this will be adjusted,
though it's unlikely that the lowest level React Native module (ExternalAPI)
changes drastically.

This commit also introduces a stopgap limitation of only allowing a single
instance for JitsiMeetView objects on both Android and iOS. React Native doesn't
really play well with having multiple instances of the same modules on the same
bridge, since they behave a bit like singletons. Even if we were to use multiple
bridges, some features depend on system-level global state, such as the
AVAudioSession mode or Android's immersive mode. Further attempts will be made
at lifting this limitation in the future, though.

9 years ago

2 Commits (5f64ccb97d3b8579b64a2c7cc00ef6502744f7db)