jitsi-meet

Commit Graph

Author	SHA1	Message	Date
Leonard Kim	929bc8b8b9	fix(device-selection): do not reuse tracks in previews Device selection has live previews that reuse the current local audio and video tracks for the sake of internet explorer. This means when the local video was muted, device selection would show a muted message. It is preferred to show a live preview even when muted. The changes include: - Passing device ids into DeviceSelectionDialog, not tracks. - Setting default selected devices to use for live previews. - Removing all checks in DeviceSelectionDialog involving local tracks. - Catching and displaying errors when creating a live video preview.	9 years ago
Leonard Kim	3e518e8040	feat: convert device selection modal to use AtlasKit Dropdown Instead of using AtlasKit Single-Select, use Dropdown. Dropdown differs in that an icon can be specified for the trigger element, whereas Single-Select currently supports icons for all elements, and Dropdown can show all options incuding the already-selected option. This change does introduce the issue of the trigger element not taking up 100% width of the parent. Supporting such would involve overriding AtlasKit CSS. The compromise made here was to do a generic override of max-width so the trigger elements at least stay within the parent and aligning the trigger elements to the right.	9 years ago
Leonard Kim	2f994b1227	feat: new device selection modal with previews The Device Selection modal consists of: - DeviceSelection, an overly smart component responsible for triggering stream creation and cleanup. - DeviceSelector for selector elements. - VideoInputPreview for displaying a video preview. - AudioInputPreview for displaying a volume meter. - AudioOutputPreview for a test sound output link. Store changes include is primarily storing the list of available devices in redux. Other app state has been left alone for future refactoring.	9 years ago

Author

SHA1

Message

Date

Leonard Kim

929bc8b8b9

fix(device-selection): do not reuse tracks in previews

Device selection has live previews that reuse the current local
audio and video tracks for the sake of internet explorer. This
means when the local video was muted, device selection would
show a muted message. It is preferred to show a live preview
even when muted.

The changes include:
- Passing device ids into DeviceSelectionDialog, not tracks.
- Setting default selected devices to use for live previews.
- Removing all checks in DeviceSelectionDialog involving local tracks.
- Catching and displaying errors when creating a live video preview.

9 years ago

Leonard Kim

3e518e8040

feat: convert device selection modal to use AtlasKit Dropdown

Instead of using AtlasKit Single-Select, use Dropdown. Dropdown
differs in that an icon can be specified for the trigger element,
whereas Single-Select currently supports icons for all elements,
and Dropdown can show all options incuding the already-selected
option.

This change does introduce the issue of the trigger element not
taking up 100% width of the parent. Supporting such would involve
overriding AtlasKit CSS. The compromise made here was to do a
generic override of max-width so the trigger elements at least
stay within the parent and aligning the trigger elements to the
right.

9 years ago

Leonard Kim

2f994b1227

feat: new device selection modal with previews

The Device Selection modal consists of:
- DeviceSelection, an overly smart component responsible for
  triggering stream creation and cleanup.
- DeviceSelector for selector elements.
- VideoInputPreview for displaying a video preview.
- AudioInputPreview for displaying a volume meter.
- AudioOutputPreview for a test sound output link.

Store changes include is primarily storing the list of
available devices in redux. Other app state has been left
alone for future refactoring.

9 years ago

3 Commits (a5d8b4a933425243cbfa3ba202895697a557f724)