45 Commits (bce2a9fba9ace4066a12aabba471f15c94136fed)

Author	SHA1	Message	Date
virtuacoplenny	510334fa7f	ref(notifications): convert some dialogs to error or warning notifica… (#1991) ... * ref(notifications): convert some dialogs to error or warning notifications - Expand the configurability of the Notification component so warnings and errors can be displayed. - Allow Notification to take in arbitrary text for the body. - Rename defaultTitleKey to titleKey for consistency with descriptionKey. * ref(notifications): remove openReportDialog method openReportDialog is a wrapper around showError that adds a logger statement. It is being called in one place only so remove the method and have that one place call logger. * ref(notifications): UI.showTrackNotWorkingDialog takes a boolean Change UI.showTrackNotWorkingDialog so it takes a boolean arguments instead of the entire track. A small refactor so the method needs to know less. * [squash] Fixes eslint errors * WiP: Fixes desktop sharing error strings and adds support button * [squash] Fix icons appearances * [squash] Fix translate titles and messages * [squash] fix(translation): Fixes incorrect password string * [squash] fix(recording): Fixes recording message * [squash] fix(warning): Turns some warnings to errors and makes support link optional. * [squash] fix(translation): Addressing language comments * [squash] Fixes jsdoc and formatting * [squash] fix(noopener): Fixes window.open noopener * [squash] fix(constants): Extract constants and refactor NotificationWithToggle * [squash] fix(lang): Fixes camera and mic error titles * [squash] fix(supportLink): Renames addSupportLink to hideErrorSupportLink	8 years ago
virtuacoplenny	2d9ce2486e	feat(1080p): pass new-style constraints to createLocalTracks (#2087) ... The lib will accept new style constraints and use those to capture audio/video. By defining the constraints in config, there is greater flexibility for defining and changing constraints.	8 years ago
damencho	ade5290013	Fixes changing device unmutes you in a conference.	8 years ago
hristoterezov	0b50578de9	style(analytics): sendEvent -> sendAnalyticsEvent	8 years ago
hristoterezov	0eddef4d62	feat(mute): Add analytics and console logs for audio/video mutes	8 years ago
Lyubo Marinov	4bf19d73fd	[RN] Fix documentation comments ... * Javadoc introduced @code as a replacement of <code> and <tt> which is better aligned with other javadoc tags such as @link. Use it in the Java source code. If we switch to Kotlin, then we'll definitely use Markdown. * There are more uses of @code in the JavaScript source code than <tt> so use @code for the sake of consistency. Eventually, I'd rather we switch to Markdown because it's easier on my eyes. * Xcode is plain confused by @code and @link. The Internet says that Xcode supports the backquote character to denote the beginning and end of a string of characters which should be formatted for display as code but it doesn't work for me. <tt> is not rendered at all. So use the backquote which is rendered itself. Hopefully, if we switch to Markdown, then it'll be common between JavaScript and Objective-C source code.	8 years ago
Lyubo Marinov	b304ad5808	[RN] Weaken the coupling between WelcomePage and AbstractWelcomePage	8 years ago
Lyubo Marinov	24db52ef0f	[RN] Remove denied permission alert from WelcomePage	8 years ago
Saúl Ibarra Corretgé	26f0f7f89c	[RN] Alert the user when they need to manually grant a permission	8 years ago
Saúl Ibarra Corretgé	9bca0e3b3d	[RN] Create tracks right when they are required ... When do we need tracks? - Welcome page (only the video track) - Conference (depends if starting with audio / video muted is requested) When do we need to destroy the tracks? - When we are not in a conference and there is no welcome page In order to accommodate all the above use cases, a new component is introduced: BlankWelcomePage. Its purpose is to take the place of the welcome page when it is disabled. When this component is mounted local tracks are destroyed. Analogously, a video track is created when the (real) welcome page is created, and all the desired tracks are created then the Conference component is created. What are desired tracks? These are the tracks we'd like to use for the conference that is about to happen. By default both audio and video are desired. It's possible, however, the user requested to start the call with no video/audio, in which case it's muted in base/media and a track is not created. The first time the app starts (with the welcome page) it will request permission for video only, since there is no need for audio in the welcome page. Later, when a conference is joined permission for audio will be requested when an audio track is to be created. The audio track is not destroyed when the conference ends. Yours truly thinks this is not needed since it's a stopped track which is not using system resources.	8 years ago
Saúl Ibarra Corretgé	3102ea6818	[RN] Try to create local tracks when unmuting, if track is missing ... This is only desired when the unmuting action took place due to a manual user intervention or the audio-only mode being disengaged.	8 years ago
Saúl Ibarra Corretgé	c42f1704ff	[RN] Rename createInitialLocalTracks to createLocalTracks ... The name better suits its purpose, since it can be called at any time.	8 years ago
Paweł Domas	99ce46cfa8	feat(conference, toolbox, API) get rid of {audio,video}Muted' flags ... * ref: video muted state Get rid of 'videoMuted' flag in conference.js * ref: audio muted state Get rid of 'audioMuted' flag in conference.js * fix(conference.js|API): early audio/video muted updates * ref(conference.js): rename isVideoMuted Rename isVideoMuted to isLocalVideoMuted to be consistent with isLocalAudioMuted. * doc|style(conference.js): comments and space after if * ref: move 'setTrackMuted' to functions * fix(tracks/middleware): no-lonely-if * ref(features/toolbox): get rid of last argument * ref(defaultToolbarButtons): rename var	8 years ago
hristoterezov	1782030936	feat(alwaysontop): Toolbar.	8 years ago
Lyubo Marinov	85a168d51b	[RN] base/media is intent, base/tracks is reality	8 years ago
Saúl Ibarra Corretgé	d600504d85	[RN] Refactor video muting ... Simplify the code by using a bitfied instead of a couple of boolean flags. This allows us to mute the video from multiple places and only make the unmute effective once they have all unmuted. Alas, this cannot be applied to the web without a massive refactor, because it uses the track muted state as the source of truth instead of the media state.	8 years ago
Lyubo Marinov	dcc6ce025f	Convert a function to an asynchronous redux action creator	8 years ago
paweldomas	40c9f583fa	ref(tracks): remove duplication in mute/unmute	8 years ago
paweldomas	122a7f6346	fix(AudioOnly+web): crash when untoggle audio only ... Because on web video track is stored both in redux and in 'localVideo' field, video is attempted to be unmuted twice when turning off the audio only mode. This will crash the app with 'unmute operation is already in progress'. This commit will prevent from taking action from the web world if the video track already exists and will make the redux side rollback unmuted status in case unmute fails.	8 years ago
Saúl Ibarra Corretgé	8225600b61	[RN] Don't open the camera on startup when there is no welcome page ... The end goal of this patch was to avoid opening the camera when there is no welcome page. In order to achieve this, the logic for creating the local tracks was refactored: Before this patch local tracks were created when lib-jitsi-meet was initialized, and destroyed when it was deinitialized. As a side note, this meant that when a conference in a non-default domain was joined, local tracks were destroyed and recreated in quick succession. Now, local trans are created and destroyed based on what the next route will be, and this happens when the target room has been decided. This allows us to create local tracks the moment we need to render any route, and destroy them when there is no route to be rendered. As an interesting byproduct, this refactor also avoids the destruction + recreation of local tracks when a conference in a non-default domain was left.	8 years ago
Lyubo Marinov	b62b296080	Fix typos. Apply consistent formatting	8 years ago
Lyubo Marinov	a690b9d5e1	[RN] Handle denied getUserMedia permissions	8 years ago
Leonard Kim	4eacbd9f61	fix(tracks): remove mute and videotype listeners on track remove ... Listeners were set for when a track muted or changed its video type, but the listeners were never removed. This would could cause events to keep firing on the removed tracks, which would cause redux to fire and error because the tracks were no longer known. That the tracks still fire events after removal is another issue...	8 years ago
Leonard Kim	fe4de31e57	feat(tracks): place local tracks in the redux store ... - Add tracks to the redux store by intercepting where the tracks actually get used via conference.replaceTrack - While the replace call is unique to web, the _dispose and _addTracks calls use existing native code implementations - Between _dispose and addTracks is a call to update mute state. Without it, when changing devices or videoType while muted, the user will stay muted (whereas existing web behavior causes unmute). This is due to middelware calling _syncTrackMutedState to make the track mute if the user is currently muted. - Move the rest of ConferenceEvents.TRACK_MUTE_CHANGED into middleware so the event is no longer used - Note: This change does not guarantee the track state in the redux store will be 100% accurate, specifically the attribute videoStarted. Muted and videoType should be accurate.	8 years ago
Leonard Kim	2a446b8799	feat(tracks): place remote tracks into the redux store ... - Use actions trackAdded and trackRemoved to add and remove remote tracks from the redux store - Emit out to non-react components on track added and removed in the track middleware - Emit out to existing non-react components on track mute and video type changes	8 years ago
Saúl Ibarra Corretgé	5304660e14	[RN] Polyfill Symbol	8 years ago
Saúl Ibarra Corretgé	bac191f96c	[RN] Rename jitsi-meet-react to jitsi-meet	8 years ago
Saúl Ibarra Corretgé	37157dc9e2	[RN] Use _switchCameras provided by lib-jitsi-meet ... The functionality to use the react-native-webrtc custom API for fast switching cameras was moved to JitsiLocalTrack in lib-jitsi-meet. Use that. Ref: https://github.com/jitsi/lib-jitsi-meet/pull/444	8 years ago
Saúl Ibarra Corretgé	7c76f124bf	[RN] Use native API for toggling cameras ... Use the curstom _switchCamera API provided by react-native-webrtc to toggle the camera instead of destroying the current track and creating a new one. _switchCamera is implemented at a low level, so the track perceives no changes, thus being a lot faster and less involved since the capturer doesn't need to be destroyed and re-created. In addition, don't mirror the video for the back camera. Ref: https://github.com/oney/react-native-webrtc/pull/235	8 years ago
Saúl Ibarra Corretgé	f5973e0eee	[RN] Fix toggling camera ... When a new local video track is created an associated video capturer is created for it. The cause for the freezes seems to be creating mutliple tracks (which come with a video capturer each). Fix this by first disposing of the previous video track before creating the new one. Ref: https://github.com/oney/react-native-webrtc/issues/209#issuecomment-281482869	8 years ago
Lyubo Marinov	32634356a6	Simplify naming	8 years ago
Lyubo Marinov	6d0a07a4cd	Remove unnecessary source code ... Lib-jitsi-meet does not really implement isScreenSharing. Besides, getCameraFacingMode will already make sure that the video track does not represent a desktop stream.	8 years ago
Lyubo Marinov	c1b9b7a623	Prevent undefined JitsiMeetJS	8 years ago
Lyubo Marinov	0b9160fb75	LIB_DID_DISPOSE, LIB_DID_INIT, LIB_WILL_DISPOSE, LIB_WILL_INIT	8 years ago
Lyubomir Marinov	55a8b44224	Consistent middleware and reducer imports	8 years ago
Lyubomir Marinov	b50f858556	[flow] Expand the coverage of flow-monitored files	8 years ago
Lyubomir Marinov	349c04d8d1	Consistent naming of functions ... Until we make a decision on access modifier hints and adopt a respective coding style, consistency is king.	8 years ago
Lyubomir Marinov	4f8b7a934c	Comply w/ coding style	8 years ago
Saúl Ibarra Corretgé	e71e6c5b79	Name Redux actions consistently ... Redux actions which represent "commands" should be imperative, and those representing events should use the past tense.	8 years ago
Lyubomir Marinov	daf56455a5	Use Symbol for Redux action types to prevent conflicts	9 years ago
Lyubomir Marinov	02e3f6b3a2	Reduce the complexity of the source code	9 years ago
Lyubomir Marinov	4997ae79e3	Fix toolbar's mute buttons when starting muted ... The toolbar's mute buttons depict respective features/base/media states. However, (un)muting is practically carried out by features/base/tracks. When the mobile app enters a conference configured to invite the joining participant to mute themselves, the tracks would be muted but the toolbar's mute buttons would not reflect that.	9 years ago
Lyubomir Marinov	a91deca6cd	Remove source code duplication ... An error was discovered and fixed by GitHub user blackneck in jitsi/jitsi-meet PR #1017. The faulty source code was a piece of duplication though. Remove the source code duplication there to reduce the risks of bugs.	9 years ago
Alexander Chernoshej	60eb76355b	fix tiny mistake on removing local tracks	9 years ago
Lyubomir Marinov	d55e0f70d9	Import jitsi/jitsi-meet-react#2f23d98 ... As an intermediate step on the path to merging jitsi-meet and jitsi-meet-react, import the whole source code of jitsi-meet-react as it stands at 2f23d98424 i.e. the lastest master at the time of this import. No modifications are applied to the imported source code in order to preserve a complete snapshot of it in the repository of jitsi-meet and, thus, facilitate comparison later on. Consequently, the source code of jitsi-meet and/or jitsi-meet-react may not work. For example, jitsi-meet's jshint may be unable to parse jitsi-meet-react's source code.	9 years ago