chore: remove build container from lint (#19361)

pull/19390/head^2
Trevor Whitney 7 months ago committed by GitHub
parent 2e418b13fd
commit 0538d0e233
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
  1. 18
      Makefile

@ -388,17 +388,18 @@ publish: packages
########
# Lint #
########
# To run this efficiently on your workstation, run this from the root dir:
# docker run --rm --tty -i -v $(pwd)/.cache:/go/cache -v $(pwd)/.pkg:/go/pkg -v $(pwd):/src/loki grafana/loki-build-image:0.24.1 lint
lint: ## run linters
ifeq ($(BUILD_IN_CONTAINER),true)
$(run_in_container)
ifeq ($(UNAME_S),Linux)
LINT_FLAGS="--timeout=15m --build-tags=linux,promtail_journal_enabled"
GOFLAGS="-tags=linux,promtail_journal_enabled"
else
LINT_FLAGS="--timeout=15m"
GOFLAGS=""
endif
lint: ## run linters
go version
golangci-lint version
GO111MODULE=on golangci-lint run -v --timeout 15m --build-tags linux,promtail_journal_enabled
GOFLAGS="-tags=linux,promtail_journal_enabled" faillint -paths \
golangci-lint run -v $(LINT_FLAGS)
GOFLAGS=$(GOFLAGS) faillint -paths \
"sync/atomic=go.uber.org/atomic" \
./...
@ -411,7 +412,6 @@ else
faillint -paths \
"github.com/opentracing/opentracing-go,github.com/opentracing/opentracing-go/log,github.com/uber/jaeger-client-go,github.com/opentracing-contrib/go-stdlib/nethttp" \
./...
endif
########
# Test #

Loading…
Cancel
Save