Revert high cardinality metric in scheduler (#8946)

**What this PR does / why we need it**:

The metrics was useful for initial testing of the new scheduler queue implementation but yields high cardinality metrics, which is not desired. Also, the metric does not add additional value beyond the initial testing phase.

**Special notes for your reviewer**:

The metric was introduced with commit cba31024d4

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
pull/8955/head
Christian Haudum 3 years ago committed by GitHub
parent 89996c9714
commit 0adedfa689
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 8
      pkg/scheduler/queue/metrics.go
  2. 1
      pkg/scheduler/queue/queue.go

@ -9,7 +9,6 @@ type Metrics struct {
queueLength *prometheus.GaugeVec // Per tenant
discardedRequests *prometheus.CounterVec // Per tenant
enqueueCount *prometheus.CounterVec // Per tenant and level
dequeueCount *prometheus.CounterVec // Per tenant and querier
}
func NewMetrics(subsystem string, registerer prometheus.Registerer) *Metrics {
@ -32,12 +31,6 @@ func NewMetrics(subsystem string, registerer prometheus.Registerer) *Metrics {
Name: "enqueue_count",
Help: "Total number of enqueued (sub-)queries.",
}, []string{"user", "level"}),
dequeueCount: promauto.With(registerer).NewCounterVec(prometheus.CounterOpts{
Namespace: "loki",
Subsystem: subsystem,
Name: "dequeue_count",
Help: "Total number of dequeued (sub-)queries.",
}, []string{"user", "querier"}),
}
}
@ -45,5 +38,4 @@ func (m *Metrics) Cleanup(user string) {
m.queueLength.DeleteLabelValues(user)
m.discardedRequests.DeleteLabelValues(user)
m.enqueueCount.DeletePartialMatch(prometheus.Labels{"user": user})
m.dequeueCount.DeletePartialMatch(prometheus.Labels{"user": user})
}

@ -148,7 +148,6 @@ FindQueue:
}
q.metrics.queueLength.WithLabelValues(tenant).Dec()
q.metrics.dequeueCount.WithLabelValues(tenant, querierID).Inc()
// Tell close() we've processed a request.
q.cond.Broadcast()

Loading…
Cancel
Save