From 1036f00a5a24240cf1d797da6d2e9e5892fcffe8 Mon Sep 17 00:00:00 2001 From: Owen Diehl Date: Mon, 22 Feb 2021 08:26:17 -0500 Subject: [PATCH] Libsonnet/better sharding parallelism defaults (#3357) * increases read path parallelism limits to be in line with global parallelism controls. * noop: shard-factor -> 16 when sharding disabled * 2048 sharded queue size --- production/ksonnet/loki/config.libsonnet | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/production/ksonnet/loki/config.libsonnet b/production/ksonnet/loki/config.libsonnet index 79172bf973..38f6c7df89 100644 --- a/production/ksonnet/loki/config.libsonnet +++ b/production/ksonnet/loki/config.libsonnet @@ -140,7 +140,7 @@ frontend: { compress_responses: true, log_queries_longer_than: '5s', - max_outstanding_per_tenant: 300, + max_outstanding_per_tenant: if !$._config.queryFrontend.sharded_queries_enabled then 256 else 2048, }, frontend_worker: { frontend_address: 'query-frontend.%s.svc.cluster.local:9095' % $._config.namespace, @@ -176,7 +176,9 @@ limits_config: { enforce_metric_name: false, // align middleware parallelism with shard factor to optimize one-legged sharded queries. - max_query_parallelism: $._config.queryFrontend.shard_factor, + max_query_parallelism: if !$._config.queryFrontend.sharded_queries_enabled then + 16 // default to 16x parallelism + else $._config.queryFrontend.shard_factor << 4, // For a sharding factor of 16 (default), this is 256, or enough for 16 sharded queries. reject_old_samples: true, reject_old_samples_max_age: '168h', max_query_length: '12000h', // 500 days