Review feedback.

Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
pull/559/head
Tom Wilkie 7 years ago committed by Tom Wilkie
parent d1b873165a
commit 1319b622c4
  1. 3
      pkg/logql/parser.go
  2. 6
      pkg/logql/parser_test.go

@ -17,11 +17,10 @@ func init() {
// ParseExpr parses a string and returns an Expr.
func ParseExpr(input string) (Expr, error) {
var l = lexer{
l := lexer{
parser: exprNewParser().(*exprParserImpl),
}
l.Init(strings.NewReader(input))
//l.Scanner.Mode = scanner.SkipComments | scanner.ScanStrings | scanner.ScanInts
l.Scanner.Error = func(_ *scanner.Scanner, msg string) {
l.Error(msg)
}

@ -54,12 +54,6 @@ func TestParse(t *testing.T) {
in: `{foo="bar"}`,
exp: &matchersExpr{matchers: []*labels.Matcher{mustNewMatcher(labels.MatchEqual, "foo", "bar")}},
},
/*
{
in: `{http.url=~"^/admin"}`,
exp: &matchersExpr{matchers: []*labels.Matcher{mustNewMatcher(labels.MatchRegexp, "http.url", "^/admin")}},
},
*/
{
in: `{ foo = "bar" }`,
exp: &matchersExpr{matchers: []*labels.Matcher{mustNewMatcher(labels.MatchEqual, "foo", "bar")}},

Loading…
Cancel
Save