From 21f69643b3cc99c85ea48c983c1967916139b95e Mon Sep 17 00:00:00 2001 From: Tristan Colgate-McFarlane Date: Thu, 16 Jun 2022 08:55:19 +0100 Subject: [PATCH] promtail: fix infinite loop in file target (fixes #5350) (#6135) --- clients/pkg/promtail/targets/file/filetarget.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/clients/pkg/promtail/targets/file/filetarget.go b/clients/pkg/promtail/targets/file/filetarget.go index e8f4a5d515..b212d72421 100644 --- a/clients/pkg/promtail/targets/file/filetarget.go +++ b/clients/pkg/promtail/targets/file/filetarget.go @@ -168,7 +168,11 @@ func (t *FileTarget) run() { for { select { - case event := <-t.fileEventWatcher: + case event, ok := <-t.fileEventWatcher: + if !ok { + // fileEventWatcher has been closed + return + } switch event.Op { case fsnotify.Create: t.startTailing([]string{event.Name})