diff --git a/cmd/logcli/main.go b/cmd/logcli/main.go index e812dc2452..61e6b0e905 100644 --- a/cmd/logcli/main.go +++ b/cmd/logcli/main.go @@ -1,7 +1,7 @@ package main import ( - "context" + "encoding/json" "fmt" "log" "net/http" @@ -9,7 +9,6 @@ import ( "os" "github.com/grafana/logish/pkg/logproto" - "github.com/weaveworks/cortex/pkg/util" ) var defaultAddr = "https://log-us.grafana.net/api/prom/query" @@ -41,9 +40,8 @@ func main() { defer resp.Body.Close() var queryResponse logproto.QueryResponse - if bs, err := util.ParseProtoReader(context.Background(), resp.Body, &queryResponse, util.RawSnappy); err != nil { - log.Printf("Error decoding response: %v", err) - log.Fatal(string(bs)) + if err := json.NewDecoder(resp.Body).Decode(&queryResponse); err != nil { + log.Fatalf("Error decoding response: %v", err) } fmt.Println(queryResponse.String()) diff --git a/pkg/ingester/client/client.go b/pkg/ingester/client/client.go index 6db6bdb17c..d3c7a8dead 100644 --- a/pkg/ingester/client/client.go +++ b/pkg/ingester/client/client.go @@ -39,9 +39,11 @@ func New(cfg Config, addr string) (grpc_health_v1.HealthClient, error) { } return struct { logproto.PusherClient + logproto.QuerierClient io.Closer }{ - PusherClient: logproto.NewPusherClient(conn), - Closer: conn, + PusherClient: logproto.NewPusherClient(conn), + QuerierClient: logproto.NewQuerierClient(conn), + Closer: conn, }, nil } diff --git a/pkg/logproto/logproto.proto b/pkg/logproto/logproto.proto index 15180b32cc..3178d8aedf 100644 --- a/pkg/logproto/logproto.proto +++ b/pkg/logproto/logproto.proto @@ -13,7 +13,6 @@ service Pusher { service Querier { rpc Query(QueryRequest) returns (stream QueryResponse) {}; - rpc Check(grpc.health.v1.HealthCheckRequest) returns (grpc.health.v1.HealthCheckResponse); } message PushRequest { diff --git a/pkg/querier/iterator.go b/pkg/querier/iterator.go index c9815325af..d4d7e25535 100644 --- a/pkg/querier/iterator.go +++ b/pkg/querier/iterator.go @@ -121,7 +121,10 @@ func (i *heapIterator) Labels() string { } func (i *heapIterator) Error() error { - return i.curr.Error() + if i.curr != nil { + return i.curr.Error() + } + return nil } func (i *heapIterator) Close() error {