fix: always write detected_level when enabled, even if unknown (#14464)

Co-authored-by: shantanualshi <shantanu.alshi@grafana.com>
pull/14482/head^2
Trevor Whitney 7 months ago committed by GitHub
parent e2a209c076
commit 41c6b6c2c2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
  1. 2
      pkg/distributor/distributor.go
  2. 2
      pkg/distributor/distributor_test.go

@ -502,7 +502,7 @@ func (d *Distributor) Push(ctx context.Context, req *logproto.PushRequest) (*log
} else {
logLevel = detectLogLevelFromLogEntry(entry, structuredMetadata)
}
if logLevel != constants.LogLevelUnknown && logLevel != "" {
if logLevel != "" {
entry.StructuredMetadata = append(entry.StructuredMetadata, logproto.LabelAdapter{
Name: constants.LevelLabel,
Value: logLevel,

@ -1640,7 +1640,7 @@ func Test_DetectLogLevels(t *testing.T) {
require.NoError(t, err)
topVal := ingester.Peek()
require.Equal(t, `{foo="bar"}`, topVal.Streams[0].Labels)
require.Len(t, topVal.Streams[0].Entries[0].StructuredMetadata, 0)
require.Len(t, topVal.Streams[0].Entries[0].StructuredMetadata, 1)
})
t.Run("log level detection enabled and warn logs", func(t *testing.T) {

Loading…
Cancel
Save