From 66b2721cfa27f892abae0b8d024490cbeb77afa6 Mon Sep 17 00:00:00 2001 From: Robert Fratto Date: Tue, 4 Feb 2025 11:42:03 -0500 Subject: [PATCH] chore(dataobj): do not panic on unrecognized compression type (#16088) --- pkg/dataobj/internal/dataset/page.go | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/pkg/dataobj/internal/dataset/page.go b/pkg/dataobj/internal/dataset/page.go index c0b2653bbc..e1dff653b4 100644 --- a/pkg/dataobj/internal/dataset/page.go +++ b/pkg/dataobj/internal/dataset/page.go @@ -112,9 +112,12 @@ func (p *MemPage) reader(compression datasetmd.CompressionType) (presence io.Rea case datasetmd.COMPRESSION_TYPE_ZSTD: zr := &fixedZstdReader{page: p, data: compressedValuesData} return bitmapReader, zr, nil - } - panic(fmt.Sprintf("dataset.MemPage.reader: unknown compression type %q", compression.String())) + default: + // We do *not* want to panic here, as we may be trying to read a page from + // a newer format. + return nil, nil, fmt.Errorf("unknown compression type %q", compression.String()) + } } var snappyPool = sync.Pool{