From 6c8fdd68aa9812a8d31b41cdadbe52334e0814f3 Mon Sep 17 00:00:00 2001 From: Gregory Brzeski Date: Tue, 9 Feb 2021 14:31:00 +0100 Subject: [PATCH] fix typo in config variable name: BookmarkPath (#3298) --- pkg/promtail/scrapeconfig/scrapeconfig.go | 4 ++-- pkg/promtail/targets/windows/target.go | 4 ++-- pkg/promtail/targets/windows/target_test.go | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/pkg/promtail/scrapeconfig/scrapeconfig.go b/pkg/promtail/scrapeconfig/scrapeconfig.go index 4ab3f2f82b..b9cff0a25c 100644 --- a/pkg/promtail/scrapeconfig/scrapeconfig.go +++ b/pkg/promtail/scrapeconfig/scrapeconfig.go @@ -190,11 +190,11 @@ type WindowsEventsTargetConfig struct { // timestamp if it's set. UseIncomingTimestamp bool `yaml:"use_incoming_timestamp"` - // BoorkmarkPath sets the bookmark location on the filesystem. + // BookmarkPath sets the bookmark location on the filesystem. // The bookmark contains the current position of the target in XML. // When restarting or rollingout promtail, the target will continue to scrape events where it left off based on the bookmark position. // The position is updated after each entry processed. - BoorkmarkPath string `yaml:"bookmark_path"` + BookmarkPath string `yaml:"bookmark_path"` // PollInterval is the interval at which we're looking if new events are available. By default the target will check every 3seconds. PollInterval time.Duration `yaml:"poll_interval"` diff --git a/pkg/promtail/targets/windows/target.go b/pkg/promtail/targets/windows/target.go index 0048a378d7..1bc119fc2b 100755 --- a/pkg/promtail/targets/windows/target.go +++ b/pkg/promtail/targets/windows/target.go @@ -54,9 +54,9 @@ func New( } defer windows.CloseHandle(sigEvent) - bm, err := newBookMark(cfg.BoorkmarkPath) + bm, err := newBookMark(cfg.BookmarkPath) if err != nil { - return nil, fmt.Errorf("failed to create bookmark using path=%s: %w", cfg.BoorkmarkPath, err) + return nil, fmt.Errorf("failed to create bookmark using path=%s: %w", cfg.BookmarkPath, err) } t := &Target{ diff --git a/pkg/promtail/targets/windows/target_test.go b/pkg/promtail/targets/windows/target_test.go index be857c7314..05d07a70ca 100755 --- a/pkg/promtail/targets/windows/target_test.go +++ b/pkg/promtail/targets/windows/target_test.go @@ -58,7 +58,7 @@ func Test_GetCreateBookrmark(t *testing.T) { client := fake.New(func() {}) defer client.Stop() ta, err := New(util_log.Logger, client, nil, &scrapeconfig.WindowsEventsTargetConfig{ - BoorkmarkPath: "c:foo.xml", + BookmarkPath: "c:foo.xml", PollInterval: time.Microsecond, Query: ` @@ -92,7 +92,7 @@ func Test_GetCreateBookrmark(t *testing.T) { client = fake.New(func() {}) defer client.Stop() ta, err = New(util_log.Logger, client, nil, &scrapeconfig.WindowsEventsTargetConfig{ - BoorkmarkPath: "c:foo.xml", + BookmarkPath: "c:foo.xml", PollInterval: time.Microsecond, Query: `