fixes batch metrics help text & corrects bucketing (#2552)

pull/2458/head
Owen Diehl 5 years ago committed by GitHub
parent 766b08078e
commit 750ab36bc1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 4
      pkg/storage/batch.go

@ -59,7 +59,7 @@ func NewChunkMetrics(r prometheus.Registerer, maxBatchSize int) *ChunkMetrics {
Namespace: "loki",
Subsystem: "store",
Name: "chunks_downloaded_total",
Help: "Number of chunks downloaded, partitioned by if they satisfy matchers.",
Help: "Number of chunks referenced or downloaded, partitioned by if they satisfy matchers.",
}, []string{"status"}),
batches: promauto.With(r).NewHistogramVec(prometheus.HistogramOpts{
Namespace: "loki",
@ -68,7 +68,7 @@ func NewChunkMetrics(r prometheus.Registerer, maxBatchSize int) *ChunkMetrics {
Help: "The chunk batch size, partitioned by if they satisfy matchers.",
// split buckets evenly across 0->maxBatchSize
Buckets: prometheus.LinearBuckets(0, float64(maxBatchSize/buckets), buckets),
Buckets: prometheus.LinearBuckets(0, float64(maxBatchSize/buckets), buckets+1), // increment buckets by one to ensure upper bound bucket exists.
}, []string{"status"}),
}
}

Loading…
Cancel
Save