Extended test query to expose broken query. Parsed logql correctly in validate (#1044)

Signed-off-by: Joe Elliott <number101010@gmail.com>
pull/1046/head
Joe Elliott 6 years ago committed by Cyril Tovena
parent 9614b021d1
commit 7794d15b6a
  1. 3
      pkg/querier/querier.go
  2. 2
      pkg/querier/querier_test.go

@ -378,10 +378,11 @@ func (q *Querier) validateQueryRequest(ctx context.Context, req *logproto.QueryR
return err
}
matchers, err := logql.ParseMatchers(req.Selector)
selector, err := logql.ParseLogSelector(req.Selector)
if err != nil {
return err
}
matchers := selector.Matchers()
maxStreamMatchersPerQuery := q.limits.MaxStreamsMatchersPerQuery(userID)
if len(matchers) > maxStreamMatchersPerQuery {

@ -250,7 +250,7 @@ func defaultLimitsTestConfig() validation.Limits {
func TestQuerier_validateQueryRequest(t *testing.T) {
request := logproto.QueryRequest{
Selector: "{type=\"test\", fail=\"yes\"}",
Selector: "{type=\"test\", fail=\"yes\"} |= \"foo\"",
Limit: 10,
Start: time.Now().Add(-1 * time.Minute),
End: time.Now(),

Loading…
Cancel
Save