From 8976709f24dc9baa603d030fa23484382f7ba767 Mon Sep 17 00:00:00 2001 From: Cyril Tovena Date: Wed, 26 Feb 2025 12:58:52 +0100 Subject: [PATCH] fix(ruler): ensure test service shutdown is properly awaited (#16468) --- pkg/ruler/base/api_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/ruler/base/api_test.go b/pkg/ruler/base/api_test.go index f61f2fe3f0..fc440c0b54 100644 --- a/pkg/ruler/base/api_test.go +++ b/pkg/ruler/base/api_test.go @@ -559,7 +559,7 @@ func TestRuler_PrometheusAlerts(t *testing.T) { cfg := defaultRulerConfig(t, newMockRuleStore(mockRules)) r := newTestRuler(t, cfg) - defer r.StopAsync() + defer services.StopAndAwaitTerminated(context.Background(), r) //nolint:errcheck a := NewAPI(r, r.store, log.NewNopLogger()) @@ -593,7 +593,7 @@ func TestRuler_GetRulesLabelFilter(t *testing.T) { cfg := defaultRulerConfig(t, newMockRuleStore(mockRules)) r := newTestRuler(t, cfg) - defer r.StopAsync() + defer services.StopAndAwaitTerminated(context.Background(), r) //nolint:errcheck a := NewAPI(r, r.store, log.NewNopLogger())