Remove timeout parameter (#11102)

**What this PR does / why we need it**:

The `helm-extra-args` causes an error with the new version of ct lint.
This change removes the timeout parameter specified in there and adds a
timeout in the CI step configuration.

**Special notes for your reviewer**:

**Checklist**
- [X] Reviewed the
[`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md)
guide (**required**)
- [ ] Documentation added
- [ ] Tests updated
- [ ] `CHANGELOG.md` updated
- [ ] If the change is worth mentioning in the release notes, add
`add-to-release-notes` label
- [ ] Changes that require user attention or interaction to upgrade are
documented in `docs/sources/setup/upgrade/_index.md`
- [ ] For Helm chart changes bump the Helm chart version in
`production/helm/loki/Chart.yaml` and update
`production/helm/loki/CHANGELOG.md` and
`production/helm/loki/README.md`. [Example
PR](d10549e3ec)
- [ ] If the change is deprecating or removing a configuration option,
update the `deprecated-config.yaml` and `deleted-config.yaml` files
respectively in the `tools/deprecated-config-checker` directory.
[Example
PR](0d4416a4b0)

Signed-off-by: Michel Hollands <michel.hollands@gmail.com>
pull/11086/head
Michel Hollands 2 years ago committed by GitHub
parent dda698ea9d
commit 92fa3e3e5c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 1
      .github/workflows/helm-ci.yml
  2. 1
      production/helm/ct.yaml

@ -72,6 +72,7 @@ jobs:
- name: Run chart-testing (lint)
run: ct lint --config "${CT_CONFIGFILE}" --check-version-increment=false
timeout-minutes: 10
- name: Create kind cluster
uses: helm/kind-action@v1.8.0

@ -7,6 +7,5 @@ chart-repos:
- grafana=https://grafana.github.io/helm-charts
- minio=https://charts.min.io
- prometheus-community=https://prometheus-community.github.io/helm-charts
helm-extra-args: --timeout 600s
check-version-increment: false
validate-maintainers: false

Loading…
Cancel
Save