chore: log the query from the request when we're unable to get a result from the results cache (#13915)

Signed-off-by: Callum Styan <callumstyan@gmail.com>
pull/13930/head
Callum Styan 9 months ago committed by GitHub
parent 40f4f14791
commit b1802971c2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
  1. 4
      pkg/querier/queryrange/queryrangebase/results_cache.go

@ -224,7 +224,7 @@ func (s resultsCache) shouldCacheResponse(ctx context.Context, req Request, r Re
s.metrics.versionComparisons.Inc()
if len(genNumbersFromResp) == 0 && genNumberFromCtx != "" {
level.Debug(logger).Log("msg", fmt.Sprintf("we found results cache gen number %s set in store but none in headers", genNumberFromCtx))
level.Debug(logger).Log("msg", fmt.Sprintf("we found results cache gen number %s set in store but none in headers", genNumberFromCtx), "query", req.GetQuery())
// NB(owen-d):
// If the queriers aren't returning cache numbers, something is likely broken
@ -235,7 +235,7 @@ func (s resultsCache) shouldCacheResponse(ctx context.Context, req Request, r Re
for _, gen := range genNumbersFromResp {
if gen != genNumberFromCtx {
level.Debug(logger).Log("msg", fmt.Sprintf("inconsistency in results cache gen numbers %s (GEN-FROM-RESPONSE) != %s (GEN-FROM-STORE), not caching the response", gen, genNumberFromCtx))
level.Debug(logger).Log("msg", fmt.Sprintf("inconsistency in results cache gen numbers %s (GEN-FROM-RESPONSE) != %s (GEN-FROM-STORE), not caching the response", gen, genNumberFromCtx), "query", req.GetQuery())
s.metrics.versionComparisonFailures.WithLabelValues(reasonMismatch).Inc()
return false
}

Loading…
Cancel
Save