mirror of https://github.com/grafana/loki
Improve case insensitive search to avoid allocations. (#4394)
* Improve case sensitive search to avoid allocations. ``` ❯ benchcmp before.txt after.txt benchmark old ns/op new ns/op delta Benchmark_LineFilter/default_true_(?i)foo-16 2400 2233 -6.96% Benchmark_LineFilter/simplified_true_(?i)foo-16 201 228 +13.13% Benchmark_LineFilter/default_false_(?i)foo-16 2443 2376 -2.74% Benchmark_LineFilter/simplified_false_(?i)foo-16 185 231 +24.96% benchmark old allocs new allocs delta Benchmark_LineFilter/default_true_(?i)foo-16 0 0 +0.00% Benchmark_LineFilter/simplified_true_(?i)foo-16 1 0 -100.00% Benchmark_LineFilter/default_false_(?i)foo-16 0 0 +0.00% Benchmark_LineFilter/simplified_false_(?i)foo-16 1 0 -100.00% benchmark old bytes new bytes delta Benchmark_LineFilter/default_true_(?i)foo-16 0 0 +0.00% Benchmark_LineFilter/simplified_true_(?i)foo-16 128 0 -100.00% Benchmark_LineFilter/default_false_(?i)foo-16 0 0 +0.00% Benchmark_LineFilter/simplified_false_(?i)foo-16 128 0 -100.00% ``` It's not much but for a billions line it makes a big difference. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com> * typo Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com> * Simplified version Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com> * Cleanup Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>pull/4803/head
parent
8a914b5c2f
commit
dc222dc98d
Loading…
Reference in new issue