Remove __name__ from label calls (#6229)

pull/6099/head^2
Travis Patterson 3 years ago committed by GitHub
parent 67e7285bf5
commit e313d8a873
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 2
      integration/loki_micro_services_test.go
  2. 2
      integration/loki_single_binary_test.go
  3. 1
      pkg/storage/stores/series/series_index_store.go
  4. 4
      pkg/storage/stores/series/series_store_test.go
  5. 4
      pkg/storage/stores/series/series_store_utils.go

@ -95,7 +95,7 @@ func TestMicroServicesIngestQuery(t *testing.T) {
t.Run("label-names", func(t *testing.T) {
resp, err := cliQueryFrontend.LabelNames()
require.NoError(t, err)
assert.ElementsMatch(t, []string{"__name__", "job"}, resp)
assert.ElementsMatch(t, []string{"job"}, resp)
})
t.Run("label-values", func(t *testing.T) {

@ -62,7 +62,7 @@ func TestSingleBinaryIngestQuery(t *testing.T) {
t.Run("label-names", func(t *testing.T) {
resp, err := cli.LabelNames()
require.NoError(t, err)
assert.ElementsMatch(t, []string{"__name__", "job"}, resp)
assert.ElementsMatch(t, []string{"job"}, resp)
})
t.Run("label-values", func(t *testing.T) {

@ -551,7 +551,6 @@ func (c *indexStore) lookupLabelNamesBySeries(ctx context.Context, from, through
level.Debug(log).Log("entries", len(entries))
var result util.UniqueStrings
result.Add(model.MetricNameLabel)
for _, entry := range entries {
lbs := []string{}
err := jsoniter.ConfigFastest.Unmarshal(entry.Value, &lbs)

@ -252,11 +252,11 @@ func TestChunkStore_LabelNamesForMetricName(t *testing.T) {
}{
{
`foo`,
[]string{labels.MetricName, "bar", "flip", "toms"},
[]string{"bar", "flip", "toms"},
},
{
`bar`,
[]string{labels.MetricName, "bar", "toms"},
[]string{"bar", "toms"},
},
} {
for _, schema := range schemas {

@ -38,6 +38,10 @@ func labelNamesFromChunks(chunks []chunk.Chunk) []string {
var result util.UniqueStrings
for _, c := range chunks {
for _, l := range c.Metric {
if l.Name == model.MetricNameLabel {
continue
}
result.Add(l.Name)
}
}

Loading…
Cancel
Save