From eeb8b40eaa0ada017fd6d9be929dee4c69dfb145 Mon Sep 17 00:00:00 2001 From: Bryan Boreham Date: Fri, 8 Apr 2022 16:02:45 +0100 Subject: [PATCH] usagestats tests: don't check unpredictable number (#5840) If this test is run alongside a number of other tests then the number of goroutines can change between when the report is generated and when the result is checked, which will cause the test to fail. --- pkg/usagestats/stats_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/usagestats/stats_test.go b/pkg/usagestats/stats_test.go index ec37a8f8ce..093c890234 100644 --- a/pkg/usagestats/stats_test.go +++ b/pkg/usagestats/stats_test.go @@ -50,7 +50,7 @@ func Test_BuildReport(t *testing.T) { require.Equal(t, r.Edition, "OSS") require.Equal(t, r.Target, "compactor") require.Equal(t, r.Metrics["num_cpu"], runtime.NumCPU()) - require.Equal(t, r.Metrics["num_goroutine"], runtime.NumGoroutine()) + // Don't check num_goroutine because it could have changed since the report was created. require.Equal(t, r.Metrics["compression"], "lz4") require.Equal(t, r.Metrics["compression_ratio"], int64(100)) require.Equal(t, r.Metrics["size_mb"], 200.1)