535 Commits (2b422dafa9b76632397ebfe6984148777add6ce8)

Author	SHA1	Message	Date
Ashwanth	82fb2f0ae2	fix(label_format): renamed label should use ParsedLabel category (#14515) ... Signed-off-by: Ashwanth Goli <iamashwanth@gmail.com>	7 months ago
Vladyslav Diachenko	08b1a9080b	fix(logql): updated JSONExpressionParser not to unescape extracted values if it is JSON object. (#14499) ... Signed-off-by: Vladyslav Diachenko <vlad.diachenko@grafana.com>	7 months ago
Trevor Whitney	b5462b6639	chore: remove copied loop vars (#14383)	8 months ago
Christian Haudum	833bf0def6	fix(logql): Fix panic in json parsing when using empty array index (#14393) ... This commit fixes a panic that occurs with the following json parser expression: ``` | json keys[""] ``` when the log line is the following: ```json {"keys": ["a", "b", "c"]} ``` Signed-off-by: Christian Haudum <christian.haudum@gmail.com>	8 months ago
Callum Styan	4d6992982d	feat: add query user and query source to "executing query" log lines (#14320) ... Signed-off-by: Callum Styan <callumstyan@gmail.com>	8 months ago
Ravishankar	2d4792a54f	fix: allow rename of structuremetadata labels (#13955) ... Co-authored-by: Christian Haudum <christian.haudum@gmail.com>	8 months ago
Paul Rogers	04f87ca933	chore: Lint in prep for golangci compatible with Go 1.23 (#14289)	8 months ago
Christian Haudum	14b468b236	chore: Add `has_labelfilter_before_parser` to metrics.go log line (#14244) ... The value of this field indicates that the query could potentially benefit from bloom filters on structured metadata, if the queried field is a structured metadata field. Signed-off-by: Christian Haudum <christian.haudum@gmail.com>	8 months ago
Ashwanth	900751c3bb	fix: report correct status code for metric and log queries in metrics.go (#12102)	8 months ago
Karsten Jeschkies	48e4a346b8	chore: Remove unused quantile merge step evaluator. (#14160)	8 months ago
benclive	78b275bf10	fix: Propagate query stats from quantile & topk queries (#13831) ... Signed-off-by: Callum Styan <callumstyan@gmail.com> Co-authored-by: Callum Styan <callumstyan@gmail.com>	8 months ago
Sven Grossmann	63e84b476a	fix(aggregated-metrics): correctly create logfmt string (#14124)	8 months ago
Robert Fratto	53cfef3bca	chore(storage/bloom/v1): add ExtractTestableLabelMatchers (#14119) ... Signed-off-by: Robert Fratto <robertfratto@gmail.com>	8 months ago
Paul Rogers	f226b598a4	chore: Final batch of linting cleanup for Go 1.23 and newer golangci (#14120)	8 months ago
Kason Braley	c5083c7f1f	perf(logql): Micro-optimizations for IP filter (#14072) ... Co-authored-by: Cyril Tovena <cyril.tovena@gmail.com>	8 months ago
Ravishankar	55e374e85e	fix: skipping label if it contains special symbol (#14068) ... Co-authored-by: Vladyslav Diachenko <82767850+vlad-diachenko@users.noreply.github.com>	8 months ago
Paul Rogers	18cef217fc	chore: Linting updates in prep for Go 1.23 (#14071)	9 months ago
Paul Rogers	02205f480e	chore: Remove call to deprecated rand.Seed() (#14041)	9 months ago
benclive	a0c75987a2	fix: Propagate headers/warnings/stats from quantile downstreams (#13881)	9 months ago
Travis Patterson	3bf7fa9f15	fix: sanatize structured metadata at query time (#13983)	9 months ago
Ashwanth	ae938d06d9	fix: record datasample queries are limited query type (#13930)	9 months ago
Johan Lindvall	40f4f14791	fix: Improve execution speed for queries with label filters (#13922) ... Co-authored-by: Travis Patterson <travis.patterson@grafana.com>	9 months ago
Trevor Whitney	c6ab6b31e8	chore: remove initial metric aggregation experiment (#13729)	9 months ago
Ned Andreev	5ef83a741b	fix: panic when parsing and extracting JSON key values (#13790)	10 months ago
Marco Pracucci	b88583da7d	feat: upgrade prometheus (#13671) ... Signed-off-by: Marco Pracucci <marco@pracucci.com> Signed-off-by: Vladyslav Diachenko <vlad.diachenko@grafana.com> Co-authored-by: Vladyslav Diachenko <vlad.diachenko@grafana.com>	10 months ago
jackyin	6dd6b65139	fix: ast left cycular reference result in oom (#13501) ... Co-authored-by: Travis Patterson <travis.patterson@grafana.com>	10 months ago
Kaviraj Kanagaraj	94bd3a042a	chore(lint-error): remove unused `stepCount` in `engine.go` (#13709) ... Signed-off-by: Kaviraj Kanagaraj <kavirajkanagaraj@gmail.com>	10 months ago
Callum Styan	29a37d5dcd	fix: special case the return values from a sharded first/last_over_time query (#13578) ... Signed-off-by: Callum Styan <callumstyan@gmail.com>	10 months ago
Ashwanth	65697676e6	chore: do not shard log queries with empty filter (#13568)	10 months ago
Karsten Jeschkies	08615bf751	fix: Return empty vector instead of nil for empty evaluator. (#13485)	10 months ago
Christian Haudum	e0ca67dd45	fix(query engine): Include lines with ts equal to end timestamp of the query range when executing range aggregations (#13448) ... **Background** When performing range vector aggregations, such as `count_over_time({env="dev"}[1h])`, the query range is divided into multiple steps at which the aggregation operation (e.g. counting the log lines) is evaluated. Each step starts at `current step - step interval` and ends at `current step`, as depicted in the following chart. The select range for the logs is extended by the `step interval` into the past, in order to select logs for calculating the first step.  However, the select range for logs is `start` inclusive and `end` exclusive (written as `[start, end)`), but the evaluation of the steps for the range aggregation is `start` exclusive and `end` inclusive (written as `(start, end]`). This leads to the problem that the very first timestamp at the beginning of the select range and the very last timestamp at the end of the select range are not included in the range aggregation. The "missing" last timestamp is not a problem, because a) in an instant query it is not supposed to be included anyway because of the `[start, end)` inclusivity of the query range and b) in a range query the last point of the previous step will be part of the next step evaluation. **Issue** The missing first timestamp, however, gets problematic when executing an instant query and the log timestamps are exactly at the start of the query range. This can happen when the query is split in the query frontend into multiple smaller time ranges, e.g. `1h`, `30m`, ... Since the sub queries are executed independently on the queriers, all logs that have a timestamp exactly a multiple of the split interval, e.g. 00:00, 01:00, 02:00, ... for a 1h interval, are dismissed and therefore missing in the query result over the full time range of the original query. **Fix** In order to avoid the missing logs that have a timestamp a multiple of the split interval in instant queries, we need to adjust the query range for logs to also include the `end` timestamp (written as `[start, end]`). This is done by adding a "leap nanosecond" to the `end` timestamp of the log select range. This ensures that the included `end` timestamp of the step evaluation is also included in the log selection. --- Signed-off-by: Christian Haudum <christian.haudum@gmail.com>	10 months ago
Christian Haudum	845359d4ab	test: Add range aggregation test for instant queries (#13447) ... This PR adds test coverage for the `streamRangeVectorIterator`, which is used by instant queries to evaluate the single step of the query. Signed-off-by: Christian Haudum <christian.haudum@gmail.com> Co-authored-by: Ashwanth <iamashwanth@gmail.com>	11 months ago
Christian Haudum	d8cc1cea83	chore: Make dedicated iterator package (#13273) ... Iterators of various types are widely used throughout the Loki code base. With the recent code additions of the bloom filters, a new set of utility functions for iterators emerged in `github.com/grafana/loki/v3/pkg/storage/bloom/v1`. The package defines interfaces for various common types, but also provides implementations to create and compose new iterators that implement these interfaces. This new package uses Go Generics. - However, at the current state, there are multiple iterator interfaces and implementations, which adds cognitive overhead in understanding how they work and which ones should be used. The idea is to unify them into a single iterator lib for Loki. - As a first step towards a single iterator library for the Loki code base, this PR moves the utilities from the `pkg/storage/bloom/v1` package to the `pkg/iter/v2` package. - Second, it changes the existing `EntryIterator` and `SampleIterator` iterators to "inherit" `v2.CloseIterator` in order to expose the same function names. - And lastly, naming conventions of iterator interfaces and structs are unified. The basic iterator interface (defined in `pkg/iter/v2/interface.go`) looks like so: ```go // Usage: // // for it.Next() { // curr := it.At() // // do something // } // if it.Err() != nil { // // do something // } type Iterator[T any] interface { Next() bool Err() error At() T } ``` --- Signed-off-by: Christian Haudum <christian.haudum@gmail.com>	11 months ago
Ashwanth	eb8a363066	fix(sharding): use without() grouping when merging `avg_over_time` shard results (#12176)	11 months ago
Dylan Guedes	4eb45cc588	refactor: Introduce context cause to our code (#13224) ... Introduce the usage of Go new `WithCause` functions to make our context cancellation errors more descriptive.	11 months ago
Dylan Guedes	c1fada9af0	refactor: Remove unnecessary spanlogger usage (#13255) ... Historically, we've been using `spanlogger` to enrich our spans. That isn't the right usage for it (as of now), as they'll be emitting log lines. Our current usage is causing: - Noisy/important log lines less visible - Unnecessary logging volume - Spread of the bad practice. With this PR I'm moving away from `spanlogger` all places where the log message is too bad or nonexistent. That's because these cases are indicating we don't care about that log line at all, and only about the data injected in the span.	11 months ago
Trevor Whitney	467eb1bb1b	feat: collect and serve pre-aggregated bytes and counts (#13020) ... Co-authored-by: Cyril Tovena <cyril.tovena@gmail.com>	11 months ago
Sven Grossmann	9981e9e40d	fix(orFilters): fix multiple or filters would get wrong filtertype (#13169)	12 months ago
benclive	6df81db978	feat: Support negative numbers in LogQL (#13091)	12 months ago
benclive	f6f8babf83	feat: Add utf8 support to Pattern Lexer to support utf8 chars (#13085)	12 months ago
Karsten Jeschkies	6e4555010e	fix: Introduce feature flag for [last|first]_over_time sharding. (#13067)	12 months ago
Kaviraj Kanagaraj	88e545fc95	feat(cache): Add `Cache-Control: no-cache` support for Loki instant queries. (#12896) ... Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>	1 year ago
Karsten Jeschkies	f66172eed1	feat: improve performance of `first_over_time` and `last_over_time` queries by sharding them (#11605) ... Signed-off-by: Callum Styan <callumstyan@gmail.com> Co-authored-by: Callum Styan <callumstyan@gmail.com>	1 year ago
Owen Diehl	5a643c7115	chore: reduces span footprint + double recording (#12864) ... Trying to remove some cruft from traces.	1 year ago
Owen Diehl	bc78d13d9b	feat(blooms): compute chunks once (#12664) ... Signed-off-by: Owen Diehl <ow.diehl@gmail.com>	1 year ago
Shantanu Alshi	587a6d20e9	feat: Detected labels from store (#12441)	1 year ago
Owen Diehl	9c25985b97	feat(blooms): record time spent resolving shards (#12636)	1 year ago
Travis Patterson	11e768726f	fix(query sharding): Generalize avg -> sum/count sharding using existing binop mapper (#12599)	1 year ago
Cyril Tovena	48dae4417c	feat: improve syntax parser for pattern (#12489)	1 year ago
Kaviraj Kanagaraj	e9b6ce9de4	fix(logql): Linefilter behaviour with chained `or` (#12463) ... Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>	1 year ago