apitech/loki - loki - Gitea: Git with a cup of tea

Commit Graph

Author	SHA1	Message	Date
Andre Ziviani	ec735f08d6	chore: Add contributing and versioning docs on helm chart (#14339 )	1 year ago
Callum Styan	5900417e4d	chore: Add notes about promtail being feature complete (#12827 ) Signed-off-by: Callum Styan <callumstyan@gmail.com> Co-authored-by: J Stickler <julie.stickler@grafana.com>	2 years ago
Callum Styan	1f653f02ed	chore: Minor changes to contributing doc and pr template for conventional commits (#12439 ) Signed-off-by: Callum Styan <callumstyan@gmail.com>	2 years ago
Ashwanth	a118e994d8	Remove shared_store and shared_store_key_prefix from shipper and compactor (#10840 ) What this PR does / why we need it: #### Removes `shared_store` and `shared_store_key_prefix` from index shipper and compactor configs and their corresponding CLI flags. - `-tsdb.shipper.shared-store` - `-boltdb.shipper.shared-store` - `-tsdb.shipper.shared-store.key-prefix` - `-boltdb.shipper.shared-store.key-prefix` - `-boltdb.shipper.compactor.shared-store` - `-boltdb.shipper.compactor.shared-store.key-prefix` `shared_store` has been a confusing option allowing users to easily misconfigure Loki. Going forward `object_store` setting in the [period_config](https://grafana.com/docs/loki/latest/configure/#period_config) (which already configured the store for chunks) will be used to configure store for the index. And the newly added `path_prefix` option under the `index` key in `period_config` will configure the path under which index tables are stored. This change enforces chunks and index files for a given period reside together in the same storage bucket. More details in the upgrade guide. --- `-compactor.delete-request-store` has to be explicitly configured going forward. Without setting this, loki wouldn't know which object store to use for storing delete requests. Path prefix for storing deletes is decided by `-compactor.delete-request-store.key-prefix` which defaults to `index/`. Checklist - [X] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [X] Documentation added - [X] Tests updated - [x] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [X] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`)	2 years ago
Salva Corts	cb39952309	Deprecated/Deleted Config Checker tool (#10977 ) What this PR does / why we need it: This PR adds a new _deprecated/deleted config checker_ tool to allow users upgrading from previous Loki versions to check their Loki config and runtime config for deprecated and deleted options, as well as providing them with alternatives and reasons why those configs were deprecated/deleted. Mimir provides a [tool][1] that allows users to migrate their old configs to new ones. Having that is our future goal but the new tool in this PR is a good middle ground for the short-mid term. We also update the checklist in the PR template to ask contributors to update the tool source of truth if the contributor is deprecating or deleting a config. Here's an example for how to use the tool: ```bash go run tools/deprecated-config-checker/main.go \ -config.file tools/deprecated-config-checker/test-fixtures/config.yaml \ -runtime-config.file tools/deprecated-config-checker/test-fixtures/runtime-config.yaml ``` And this is an example output: ![image](https://github.com/grafana/loki/assets/8354290/a86c0815-9875-4086-a267-9bbe06a6ee0e) ### Notes I think I've gone through all the deprecated and deleted configs. I cannot find the config pointed by the deprecated `ruler.storage`. It states ``` ruler: ... # Deprecated: Use -ruler-storage. CLI flags and their respective YAML config # options instead. storage: ... ``` I couldn't find that `-ruler-storage` cli flag nor the YAML definition. [1]: https://grafana.com/docs/mimir/latest/manage/tools/mimirtool/#convert	2 years ago
J Stickler	aae92b9840	[Docs] Create top-level Setup section (#9974 ) Which issue(s) this PR fixes: Fixes #8712 Special notes for your reviewer: Move the following files under a new Setup section (with three subsections: Install, Migrate, and Upgrade). - ./sources/installation/sizing/index.md - ./sources/installation/_index.md - ./sources/installation/docker.md - ./sources/installation/helm/_index.md - ./sources/installation/helm/concepts.md - ./sources/installation/helm/configure-storage/index.md - ./sources/installation/helm/install-monolithic/index.md - ./sources/installation/helm/install-scalable/index.md - ./sources/installation/helm/migrate-from-distributed/index.md - ./sources/installation/helm/migrate-to-three-scalable-targets/index.md - ./sources/installation/helm/monitor-and-alert/index.md - ./sources/installation/helm/reference.md - ./sources/installation/helm/upgrade-from-2.x/index.md - ./sources/installation/install-from-source.md - ./sources/installation/istio.md - ./sources/installation/local.md - ./sources/installation/tanka.md Updates cross-references broken by the move, Updates file metadata (descriptions, weights) and adds aliases for redirects to avoid 404s. Probably fixes a couple of typos too.	2 years ago
Trevor Whitney	7696938928	Update PR template to include add to release notes label (#9691 ) What this PR does / why we need it: Includes a checklist option to the PR template about the `add-to-release-notes` label. Special notes for your reviewer: Checklist - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`)	3 years ago
Michel Hollands	89b786fe51	Add instructions for Helm chart updates in the pull request template (#9514 ) What this PR does / why we need it: Add additional instructions for Helm charts in the pull request template. Special notes for your reviewer: Checklist - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` --------- Signed-off-by: Michel Hollands <michel.hollands@grafana.com>	3 years ago
Dimitar Dimitrov	723f524e3b	Fix link to CONTRIUTING.md in PR template (#8156 ) The previous link lead to https://github.com/grafana/loki/CONTRIBUTING.md which doesn't exist.	3 years ago
Danny Kopping	9cab63d921	Loki Improvement Documents (LIDs) (#8056 ) What this PR does / why we need it: This PR adds a _Loki Improvement Document_ process to engage contributors and the community on major changes to Loki, _before_ large amounts of work is done. The aim here is to have a lightweight documented history of our decisions which the community can view in perpetuity. Signed-off-by: Danny Kopping <danny.kopping@grafana.com>	3 years ago
Dylan Guedes	bf1b5a5ced	Project: Change PR template and CONTRIBUTING guide (#7116 ) What this PR does / why we need it: - Move contributing instructions from the PR template to the CONTRIBUTING guide - Rewrite the contributing guide - Make the PR template slim by getting rid of sections that are optional but often left blank by most contributors/maintainers - We're making the PR template slim as we're using the merged PR body as the merge commit message. Because the comments are often left there by contributors, they're prone to be merged by maintainers, hence making our commit log history dirty with a lot of undesired comments.	3 years ago
Ed Welch	f62b4ae190	Other: Update pr template (#5885 ) * update pr template * Add some more notes about upgrade guide	4 years ago
Kaviraj	cf2dacf70f	Update PR template to include `changelog` update in the checklist (#4604 ) Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>	4 years ago
Calle Pettersson	0f0ff7d949	Fix branch reference in PR template (#4535 )	4 years ago
Diana Payton	9ea59f2062	Create pull_request_template.md (#3913 )	4 years ago
Steven Sheehy	9b91580365	Add a pull request template (#517 )	7 years ago

16 Commits (3e415aca3d904fa6fa3cbedfdc7a2bdfd7fb6d41)