2083 Commits (478510a1bbb73ca930622401e910138327aeae3d)

Author	SHA1	Message	Date
Michel Hollands	478510a1bb	Fix Grouping String function and usage so it prints "without ()" (#9515) ... **What this PR does / why we need it**: The changes rangemapper made to LogQL expressions created invalid LogQL. It added a `without` clause instead of `without ()`. This PR changes the String function of the Grouping struct. This is then used in the rangemapper. This caused the following panic: ``` panic: error cloning query: count without (rate({namespace="apps"}[15s])): parse error at line 1, col 16: syntax error: unexpected RATE, expecting IDENTIFIER or ) ``` **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [ ] Documentation added - [x] Tests updated - [x] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](d10549e3ec) --------- Signed-off-by: Michel Hollands <michel.hollands@grafana.com>	2 years ago
Travis Patterson	a4ef06890b	revert count unflused chunks (#9504) ... revert this commit: aeba51ab0f We seem to be dramatically overcounting bytes now which is causing oversharding This is the same query before and after: Before: ~20 GB  After: ~8 EB 	2 years ago
Travis Patterson	7ff8463def	Fix query behavior in Single Binary and SSD deployments (#9476) ... To keep ingesters from calling themselves, the AsyncStore was only being used when the module was `Querier`, `Ruler`, or `Read`. This means that, for some operations, ingesters were never queries when the deployment mode was single-binary or `Backend` (where the ruler now lives). This change scopes the async store to just the querier rather than all storage access and always includes in it queriers. Because the `AsyncStore` isn't automatically instantiated, now, I've also moved `IngesterQuerier` to be a dependency to the store. That way anything that wants to make an `AsyncStore` is guaranteed to have what it needs.	2 years ago
Travis Patterson	aeba51ab0f	Count unflushed chunks in instance stats (#9479) ... The instance wasn't counting unflushed chunks in the stats. This change checks that the chunk's `flushed time` is 0 which means it hasn't been flushed yet.	2 years ago
Owen Diehl	64c6f6b8cc	Better combines stats in ingesters (#9474) ... * Reduces double counting streams when possible * proportionally add stats based on chunk overlap range * code reuse	2 years ago
Dylan Guedes	358b8965c4	Distributor: Add org_id to log error (#9475) ... **What this PR does / why we need it**: Add `org_id` to push error when the error is "max active streams limit exceeded". Apparently all other push errors correctly report the `org_id`, but not this one. **Which issue(s) this PR fixes**: N/A	2 years ago
Owen Diehl	2efd059b49	Slight improvements to `GetFactorOfTime` (#9473) ... * correctly returns zero for non-overlapping data * adds tests	2 years ago
Dylan Guedes	8e8dcdf7d2	Gateway: Log file size (#9465) ... **What this PR does / why we need it**: Modifies gateway log message to report the file size. **Which issue(s) this PR fixes**: N/A	2 years ago
Totalus	01f0ded7fc	Update swift_object_client.go : Fetch all objects in List() function (#9463) ... **What this PR does / why we need it**: Allow the Swift Client `List()` function to return all objects that match the query. **Which issue(s) this PR fixes**: Fixes #9360 **Special notes for your reviewer**: **Checklist** - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [ ] Documentation added - [ ] Tests updated - [x] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
Ed Welch	d07a9e7dfc	Loki: also store the bytes we de-duplicate alongside the count (#9449) ... **What this PR does / why we need it**: We have a metric which stores a count of de-duplicated chunks, this PR creates a metric to also show bytes de-duplicated **Which issue(s) this PR fixes**: Fixes #<issue number> **Special notes for your reviewer**: **Checklist** - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` Signed-off-by: Edward Welch <edward.welch@grafana.com>	2 years ago
Christian Haudum	4bffed22e4	Reuse string/InstanceDesc buffers in index gateway clients (#9341) ... **What this PR does / why we need it**: When running the IndexGateway in ring mode, `ring.MakeBuffersForGet()` in the index gateway client allocated fixed size `[]string`/`[]InstanceDesc` slices with a capacity of 5 for each and every request. By using a `sync.Pool` the client can reduce the amount of allocations. Additionally, since we run the index gateway ring with a high replication factor to be able to scale them better horizontally, an initial capacity of 5 is most of the time too low, leading to extra allocations when growing the capacity of the slice. **Checklist** - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` --------- Signed-off-by: Christian Haudum <christian.haudum@gmail.com>	2 years ago
Nick Moore	2f87acd284	Fix case insensitive label filter (#9404) ... **What this PR does / why we need it**: When comparing a case insensitive regular expression to a label value, Loki was only matching values that were in upper case. This was caused by compiling a case insensitive regular expression (such as `(?i)hello`), which produced an upper case `prefix` that was then used in `containsLower` as the `substr` value - but that function was written in such a way that only allowed matches of exact case or where the `line` value was upper case and the `substr` value was lower case. This PR added a some additional test cases to demonstrate/understand the issue, and adds two additional checks to the `containsLower` function to enable it to work correctly when either input is in either case. **Which issue(s) this PR fixes**: Fixes #9294 **Special notes for your reviewer**: Given the importance of this code path, I used `BenchmarkLineLabelFilters` to validate that the performance of this code was not affected. Overall, [the differences appeared negligible](https://docs.google.com/spreadsheets/d/1BRKkCzO0i11AObC6ADguDNa7cfG93hB7JLtqYWmnfW0/edit?usp=sharing) on my device (Intel(R) Core(TM) i7-12700H). **Checklist** - [X] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [ ] Documentation added - [X] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
Ashwanth	f08794d39a	docs: add memberlist section to the configuration page (#9452) ... **What this PR does / why we need it**: `memberlist_config` section is not present in 2.8.x release, must have gotten removed by mistake when we moved to the doc generation tool. This PR adds it back. **Which issue(s) this PR fixes**: Fixes #9423 Signed-off-by: Ashwanth Goli <iamashwanth@gmail.com>	2 years ago
Danny Kopping	6141347b79	Adding more buckets to loki_memcache_request_duration_seconds histogram (#9431) ... **What this PR does / why we need it**: Users using extstore (with NVMe drives) may experience latencies higher than the ~250ms max as previously defined. --------- Signed-off-by: Danny Kopping <danny.kopping@grafana.com>	2 years ago
Dylan Guedes	20567f9ed8	Ingester: Avoid repeating `streamName` on error message (#9419) ... **What this PR does / why we need it**: Modify how our ingesters build the final error message to not append the streamName for every single entry. All entries are already part of the same stream, so repeating it is unnecessary.	2 years ago
Paul Rogers	14370bb8ce	Revert "Augment statistics.." PR 9400. (#9430) ... **What this PR does / why we need it**: This PR reverts PR 9400. The data collected within that PR was not sufficient. When queries are done, they are filtered before the merge iterator, resulting in an inability to collect an accurate count of duplicated data. **Which issue(s) this PR fixes**: **Special notes for your reviewer**: **Checklist** - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
Danny Kopping	22d56524ad	Log when memcached servers are updated (#9426) ... **What this PR does / why we need it**: Currently we do not have any insight when memcached clients update their server list. Signed-off-by: Danny Kopping <danny.kopping@grafana.com>	2 years ago
Travis Patterson	fdc337692d	Stream Sharding amortize push payloads across the observed rate. (#9414) ... This should account for large payloads that come infrequently	2 years ago
Paul Rogers	1671751cbd	Augment statistics to note how many bytes are in duplicate lines due to replicas (#9400) ... **What this PR does / why we need it**: This PR is for counting the number of bytes of log lines that were marked as duplicates. This will be utilized to collect better statistics.	2 years ago
cui fliter	520e434446	fix function names in comments (#9415)	2 years ago
Travis Patterson	48ad068ce1	fix json expression parser (#9410) ... When the value parsed by the `JsonExpressionParser` is an escaped json string, the result still contains escape character and may not be valid json. This causes subsequent json parsing steps to fail. For example: `{app="foo"} | json message | line_format "{{.message}}" | json` fails when `message` remains escaped. This PR unescapes the results of extracted `JsonExpressions` so they can be parsed by subsequent json parsers	2 years ago
Dylan Guedes	f5a20e4e96	Avoid excessive gRPC logging (#9401) ... **What this PR does / why we need it**: Change the default value of `DisableRequestSuccessLog` to true. This way Loki won't log every successful gRPC call by default. The log line isn't useful either since it is redundant with existing gRPC metrics. **Which issue(s) this PR fixes**: N/A	2 years ago
Salva Corts	ca8a7accf0	Add query info to query.Exec span (#9320) ... **What this PR does / why we need it**: It's kinda difficult to see the query that is being run on a trace. The only place where I can see the query is in the `url` attribute of the `loki_api_v1_query_range` handler, but since it’s encoded it’s kinda difficult to read. If it's elsewhere it's not quite obvious. It’d make sense to have the query in the `query.Exec` span along with the stats of the query. **Checklist** - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
Owen Diehl	8bd3581b95	Revert "Revert "start writing tsdb v3"" (#9332) ... Reverts grafana/loki#9301 Should be good to start writing v3 again after https://github.com/grafana/loki/pull/9328 is merged and when we're ready to start using tsdbv3 as the default	2 years ago
Owen Diehl	f78ceec941	fixes bug during chunk iteration using markers (#9328) ... Tricky one to find, but this does the following * correctly subtracts remaining chunk count when skipping a page (this was previously using a zero-valued marker) * correctly set previous maxt on pages that are skipped. This is important because chunks themselves are delta-encoded against the previous chunk. * removes the markers pool from the chunk decoding which isn't needed. * adds a test * adds a bit more logging on which series resulted in a decoding error during chunk iteration	2 years ago
李国忠	38b298c3fe	LogQL: Introduce `distinct` (#8662) ... **What this PR does / why we need it**: Introduces `distinct` to LogQL. Usage: `{job="varlogs"} | distinct filename` It is similar to `distinct` in SQL and especially useful for sampling. Similar syntax exists in other log query languages. **Example** For the following log lines: ```json {"event": "access", "id": "1", "time": "2023-02-28 15:12:11"} {"event": "access", "id": "1", "time": "2023-02-28 15:13:11"} {"event": "access", "id": "2", "time": "2023-02-28 15:14:11"} {"event": "access", "id": "2", "time": "2023-02-28 15:15:11"} ``` The query below: ```logql {app="order"} | json | distinct id ``` Will return: ```json {"event": "access", `"id": "1",` "time": "2023-02-28 15:13:11"} {"event": "access", `"id": "2", `"time": "2023-02-28 15:15:11"} ``` **Example with multiple labels** ```logql {app="order"} | json | distinct id,time ``` **Which issue(s) this PR fixes**: Fixes #8649 --------- Co-authored-by: J Stickler <julie.stickler@grafana.com> Co-authored-by: Dylan Guedes <djmgguedes@gmail.com> Co-authored-by: Karsten Jeschkies <karsten.jeschkies@grafana.com>	2 years ago
Trevor Whitney	50bc1cee71	Rename usagestats to analytics (#9212) ... **What this PR does / why we need it**: Rename usagestats to analytics. The config section in the yaml is already called analytics, this makes things more consistent. **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [x] Documentation added - [ ] Tests updated - [x] `CHANGELOG.md` updated - [x] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
Dylan Guedes	1bd5a20595	Distributor: Modify `createShard` to create slice with more precise size (#9265) ... **What this PR does / why we need it**: Modify the `createShard` method to create the entries slice with the number of entries divided by the total number of shards instead of always creating it with len=1024.	2 years ago
Michel Hollands	475eb6a190	Remove shutdown marker file when shutting down (#9314) ... **What this PR does / why we need it**: This removes the shutdown marker file when actually shutting down. If the PVC is re-used then the marker file shouldn't be there. Signed-off-by: Michel Hollands <michel.hollands@grafana.com> Co-authored-by: Dylan Guedes <djmgguedes@gmail.com>	2 years ago
Dylan Guedes	98b5e35f94	HTTP: Reuse `buffer.Bytes()` when decompressing (#9266) ... **What this PR does / why we need it**: - Modifies `decompressFromBuffer` to call `buffer.Bytes()` a single time. - Adds a new Benchmark under `http_loki_test.go` file. This is in a separate file to differentiate from the original `http_test.go` forked from Cortex and because `http_test.go` uses package `http_test` which doesn't allow us to test private functions.	2 years ago
Owen Diehl	cc6f6b9171	Revert "start writing tsdb v3" (#9301) ... Reverts grafana/loki#9276 Update main to prevent writing v3 by default while I find a bug in it.	2 years ago
Ashwanth	52cd0a39b8	compactor: multi-store support (#7447) ... **What this PR does / why we need it**: This PR adds multi-store support for compactors. Since loki allows users to configure mutiple stores using schema_config, compactor should be able to operate on multiple object stores that contain index. Currently, it can perform compaction on indexes in a single store. To maintain backward compatibility: if `boltdb.shipper.compactor.shared-store` is set, compactor will only operate on that store, else compactor will be initialized to operate on all the object store indexes (`boltdb, tsdb`) defined in the schema config. This PR also adds a new config option to define where delete requests are to be stored - `boltdb.shipper.compactor.delete-request-store`. If it's not set, `boltdb.shipper.compactor.shared-store` is used for storing them, this is to ensure no config changes are required by the users when upgrading. Refer to [docs/sources/upgrading/_index.md](a85d01c9cd/docs/sources/upgrading/_index.md) for more details. **Which issue(s) this PR fixes:** Fixes https://github.com/grafana/loki/issues/7276 **Checklist** - [X] Reviewed the `CONTRIBUTING.md` guide - [X] Documentation added - [X] Tests updated - [X] `CHANGELOG.md` updated - [X] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` --------- Signed-off-by: Ashwanth Goli <iamashwanth@gmail.com>	2 years ago
Owen Diehl	08af8849ee	tsdb migrate versions (#9275) ... Update of https://github.com/grafana/loki/pull/9198 while @sandeepsukhani is on holiday :) --------- Co-authored-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>	2 years ago
Owen Diehl	03531f5013	start writing tsdb v3 (#9276)	2 years ago
Christian Haudum	81e32dd6d6	Re-organize store related interfaces for better composability (#9249) ... **What this PR does / why we need it**: I got confused by our store related interfaces, so I split them up into smaller ones and composed them. **Special notes for your reviewer**: What I also noticed is that we sometimes prefix interface method with `Get`, e.g. `GetChunkRefs`, and sometimes we don't, e.g. `Series`. I think that re-organizing the package structure of the `pkg/storage/` package would help to better understand the individual purposes of the interfaces. **Checklist** - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` Signed-off-by: Christian Haudum <christian.haudum@gmail.com>	2 years ago
Karsten Jeschkies	7109c56bdc	Use un-escaped regexp literal for string matching. (#9252) ... **What this PR does / why we need it**: The Regexp simplification would use the original string value instead of the escaped literal. E.g. ``` | logfmt | level =~ `foo\.bar` ``` would match the label `level` against `foo\.bar` and not `foo.bar`. That is why the un-escaped literalt should be used in the equal and not-equal matchers. **Which issue(s) this PR fixes**: Fixes #9111 **Special notes for your reviewer**: **Checklist** - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [ ] Documentation added - [x] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
Salva Corts	eba255c945	Do not use IPv6 when getting addr from ring (#9255) ... **What this PR does / why we need it**: https://github.com/grafana/loki/pull/9184 changed the signature of `ring.GetInstanceAddr`. That function is now used since https://github.com/grafana/loki/pull/8067 which was not updated to use the changed signature. This PR fixes this by passing a new config flag `EnableIPv6` to the new `enableInet6` argument of `ring.GetInstanceAddr`. Similar to how it's done for the ruler: 3abd260975/pkg/ruler/base/ruler_ring.go (L80) **Which issue(s) this PR fixes**: Fixes `main` **Special notes for your reviewer**: **Checklist** - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` [1]: https://grafana.com/docs/loki/latest/configuration/	2 years ago
Danny Kopping	4cd0aedc76	Fix output of limited response body when remote rule evaluation fails (#9253)	2 years ago
Dylan Guedes	24d426ce44	Distributor: Add AutoForget support (#8067) ... **What this PR does / why we need it**: - Add auto-forget capabilities to distributors - Change the distributor's ring implementation from Lifecycler to BasicLifecycler. That AutoForget delegate requires it.	2 years ago
Periklis Tsirakidis	3abd260975	Bump dskit from 528d8a7 to 1725bcc (#9184)	2 years ago
Mohamed-Amine Bouqsimi	62572b4f83	Change GeneratorURL to use configurable Grafana explore URL (#8500) ... **What this PR does / why we need it**: This PR changes the `GeneratorURL` associated with alerts generated by Loki. The new `GeneratorURL` uses a Grafana URL path.	2 years ago
Danny Kopping	af896eb5f6	Ruler: log rule evaluation detail (#9206) ... **What this PR does / why we need it**: This logs some extra detail around rule evaluation to enable more effective troubleshooting when a rule is not behaving as expected.	2 years ago
Peter Štibraný	90a1d4593e	Update Prometheus dependency (#9205)	2 years ago
李国忠	98936437a9	[opt] s3: add s3 client http timeout for GetObject or PutObject (#8951) ... **What this PR does / why we need it**: add s3 client http timeout for GetObject or PutObject, why？ The flush queue has been increasing. This is a difficult problem. We have been investigating this problem for half a year. When the querier has a large query, the load on the s3 server is too high and the number of connections is full. It will cause the flush queue of the ingester to increase continuously and cannot be reduced. When this problem occurs, after we restart the s3 server, the flush queue will quickly become 0. We checked with our s3 (object storage compatible with the s3 protocol) team and found that it was because we used the s3 v1 sdk. The v1 sdk did not configure timeout by default, and it would wait indefinitely without configuration. The s3 v2 sdk defaults to a timeout of 30s, which only causes write failures and does not cause loki to get stuck. **Which issue(s) this PR fixes**: Fixes #<issue number> At present, as long as there are large logql queries such as 30 days, I must restart the s3 server, otherwise our ingester queue will continue to increase. We hope that we can break the stuck go routine after the 5m timeout occurs. **Special notes for your reviewer**: ingester flush queue length up 🔝  big query, 30day logql or something happen  pprof goroutine list profile snapshot  **There are other alternatives**: ``` ingester: flush_op_timeout: 10m ``` This `flush_op_timeout` configuration is more about the timeout of loki, not the timeout of s3 client. We will also have various s3 operations such as delete and getObject. We should add an independent timeout for s3, just like the cassandra client has a separate The timeout period can be configured. And the parameter `flush_op_timeout` in the early version of loki represents the timeout of writing `a batch of chunks `to s3, not a timeout of s3. Now it is indeed changed to write to s3 one by one, but it is not ruled out that in the future, it will be changed back to write a batch of chunks to s3 sequentially. In this way, `flush_op_timeout: 5m` is far from enough to write a batch of chunks to s3. ``` cassandra: timeout: 5m ``` **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [x] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` --------- Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com>	2 years ago
Owen Diehl	ec516facaf	removes 20 user test from compaction; seems redundant and hits timeouts (#9201) ... just a little cleanup to make tests run faster -- the 20 user test doesn't seem to test any additional surface area and takes a long time.	2 years ago
Dylan Guedes	46f044fdb7	Loki: Fix wrong association of PSRL when sharding is enabled (#9176) ... Obs: PSRL stands for `per-stream rate limit` **What this PR does / why we need it**: - Fixes the scenario where all entries errors are accounted as PSRL if sharding is enabled - Fixes invalid/rejected entries being accounted as candidates to be inserted	2 years ago
Michel Hollands	abd6131bba	Update prepare shutdown (#9175) ... **What this PR does / why we need it**: This updates the PrepareShutdown method so it supports GET and DELETE methods as well. This makes it similar to Mimir: https://github.com/grafana/mimir/pull/4718. The status is now stored in a local file. A new config setting had to be added for this file as there is no obvious place to store it. **Checklist** - [X] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [X] Documentation added - [X] Tests updated - [x] `CHANGELOG.md` updated - [x] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` --------- Signed-off-by: Michel Hollands <michel.hollands@grafana.com> Co-authored-by: Dylan Guedes <djmgguedes@gmail.com>	2 years ago
Dylan Guedes	8580b8f8ad	Distributor: Reuse `time.Now()` for better performance (#9192) ... **What this PR does / why we need it**: Modifies `AggregateByShard` to reuse `time.Now()` to improve performance.	2 years ago
Salva Corts	56bbb43748	Logcli - Better logging when object cannot get loaded from object store (#9194) ... **What this PR does / why we need it**: This PR improves the error messaging for Logcli when an object cannot be downloaded from the store by printing the name of the object along with the error. **Which issue(s) this PR fixes**: Internal support escalation **Special notes for your reviewer**: There are other places where GetObject is called: - `indexStorageClient.GetFile` - `indexStorageClient.GetUserFile` Looks like both of them are used only by the compactor and the table manager. IIUC, these functions are not used by LogCLI. **Checklist** - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
Danny Kopping	52655706b8	Prevent redis client from incorrectly choosing cluster mode with local address (#9185)	2 years ago