7 Commits (4c88be0ef2310406206c02d7747bf73b51c95bda)

Author	SHA1	Message	Date
Ed Welch	4c88be0ef2	chore: update loki modules for 3.0 release (#12433) ... Signed-off-by: Edward Welch <edward.welch@grafana.com>	1 year ago
Robert Fratto	7bec727c6d	promtail: support configurable polling interval (#8874) ... Currently, Promtail always polls files every 250ms. This PR allows the polling period to be customized, starting at a minimum polling period and exponentially increasing the polling frequency to a bounded maximum if the file has no changes. When file changes are detected, the polling frequency resets to the minimum. The default behavior is the existing behavior; both the minimum and maximum polling intervals are set to 250ms. I'm opening this in draft to get early feedback. There's a few open questions: * Where can I add validations to ensure that the min/max polling intervals are configured properly? * Is this the right approach for implementation? Do I need to make any changes? * Does this need tests? I'll update the CHANGELOG and Documentation after we're agreed on an approach.	2 years ago
Ed Welch	f8e582a716	Promtail: Remove noisy error message when cleaning up filesystem watches which are already removed. (#8086) ... **What this PR does / why we need it**: Promtail will emit an error message when trying to remove filesystem watches which do not exist, this PR squelches those error messages thanks to some updates in the underlying fsnotify lib which allow checking for this exact error. **Which issue(s) this PR fixes**: Fixes #3874 **Special notes for your reviewer**: **Checklist** - [x] Reviewed the `CONTRIBUTING.md` guide - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` Signed-off-by: Edward Welch <edward.welch@grafana.com>	2 years ago
Chris Hodges	d1f42fff50	promtail: Fix issue with dropping logs when a file based SD target's labels are updated (#7016) ... <!-- Thanks for sending a pull request! Before submitting: 1. Read our CONTRIBUTING.md guide 2. Name your PR as `<Feature Area>: Describe your change`. a. Do not end the title with punctuation. It will be added in the changelog. b. Start with an imperative verb. Example: Fix the latency between System A and System B. c. Use sentence case, not title case. d. Use a complete phrase or sentence. The PR title will appear in a changelog, so help other people understand what your change will be. 3. Rebase your PR if it gets out of sync with main --> **What this PR does / why we need it**: Allows for modifying labels for a target and continuing to scrape logs afterwards. **Which issue(s) this PR fixes**: Fixes #7001 **Special notes for your reviewer**: <!-- Note about CHANGELOG entries, if a change adds: * an important feature * fixes an issue present in a previous release, * causes a change in operation that would be useful for an operator of Loki to know then please add a CHANGELOG entry. For documentation changes, build changes, simple fixes etc please skip this step. We are attempting to curate a changelog of the most relevant and important changes to be easier to ingest by end users of Loki. Note about the upgrade guide, if this changes: * default configuration values * metric names or label names * changes existing log lines such as the metrics.go query output line * configuration parameters * anything to do with any API * any other change that would require special attention or extra steps to upgrade Please document clearly what changed AND what needs to be done in the upgrade guide. --> **Checklist** - [ ] Documentation added - [x] Tests updated - [x] Is this an important fix or new feature? Add an entry in the `CHANGELOG.md`. - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	3 years ago
Christian Haudum	3fb572abda	Fix Promtail watching deadlock (#5283) ... * Reuse channel from fileEventWatcher map if already exists Signed-off-by: Christian Haudum <christian.haudum@gmail.com> * Remove sync() call in FileTarget constructor The constructor `NewFileTarget` is called from within a locked code block by the FileTargetManager. However, the constructor also calls `sync()` which starts and stops watching new directories. These methods `startWatching` and `stopWatching` both send to the `targetEventHandler` channel, causing the `FileTargetManager` to receive the event in a goroutine (`watch()` function) running in the background. Handling the event calls `sendFileCreateEvent` on the syncers, which subsequently tries to write to the `fileEventWatcher` channel which is never read because of the locked mutex. Signed-off-by: Christian Haudum <christian.haudum@gmail.com>	3 years ago
Christian Haudum	86ed98c1fa	Fix promtail deadlock (#5170) ... * Remove unused clientConfigs argument from NewTargetsManagers * Do not create targetScrapeConfigs if stdin target is used * fixup! Remove unused clientConfigs argument from NewTargetsManagers * Close file watcher when target is removed Signed-off-by: Christian Haudum <christian.haudum@gmail.com> * fixup! Close file watcher when target is removed Signed-off-by: Christian Haudum <christian.haudum@gmail.com> * fixup: add changelog entry Signed-off-by: Christian Haudum <christian.haudum@gmail.com> * fixup! fixup! Close file watcher when target is removed Signed-off-by: Christian Haudum <christian.haudum@gmail.com>	3 years ago
Hiroki Sakamoto	11bf736c90	Refactor tests of Promtail filetarget (#4802) ... * Refactor tests of Promtail filetarget * Move tests depend on inotify to filetargetmanager test * Add handling file creation event via channel case in filetarget test * Use Eventually function for waiting	4 years ago