apitech/loki - loki - Gitea: Git with a cup of tea

Commit Graph

Author	SHA1	Message	Date
Cyril Tovena	768bf914e0	Changes the encoding used for the benchmark in the store. (#1448 ) Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>	6 years ago
Peter Štibraný	4381b28c80	pkg/chunkenc: BenchmarkRead focuses on reading chunks (#1423 ) Previously BenchmarkRead asked for every single line from chunks to be returned. This causes a lot of unnnecessary allocations, which dominate the benchmark. Instead of counting bytes when reading, we now count size when generating data for logging speed. Another test was added to show that these two approaches are comparable. This change makes BenchmarkRead to report real time needed to decode chunks: name old time/op new time/op delta Read/none-4 86.2ms ± 0% 33.2ms ± 0% ~ (p=1.000 n=1+1) Read/gzip-4 255ms ± 0% 194ms ± 0% ~ (p=1.000 n=1+1) Read/lz4-4 121ms ± 0% 64ms ± 0% ~ (p=1.000 n=1+1) Read/snappy-4 119ms ± 0% 67ms ± 0% ~ (p=1.000 n=1+1) name old alloc/op new alloc/op delta Read/none-4 134MB ± 0% 0MB ± 0% ~ (p=1.000 n=1+1) Read/gzip-4 135MB ± 0% 0MB ± 0% ~ (p=1.000 n=1+1) Read/lz4-4 136MB ± 0% 1MB ± 0% ~ (p=1.000 n=1+1) Read/snappy-4 135MB ± 0% 0MB ± 0% ~ (p=1.000 n=1+1) name old allocs/op new allocs/op delta Read/none-4 491k ± 0% 3k ± 0% ~ (p=1.000 n=1+1) Read/gzip-4 491k ± 0% 3k ± 0% ~ (p=1.000 n=1+1) Read/lz4-4 491k ± 0% 3k ± 0% ~ (p=1.000 n=1+1) Read/snappy-4 491k ± 0% 3k ± 0% ~ (p=1.000 n=1+1) Decompression speed is now also more correct (esp. None is much higher than LZ4/Snappy) Before (/s) Now (/s) None 1.1 GB (n=1) 4.0 GB (n=1) None 1.5 GB (n=9) 3.8 GB (n=38) None 1.6 GB (n=13) Gzip 516 MB (n=1) 640 MB (n=1) Gzip 509 MB (n=3) 664 MB (n=4) Gzip 514 MB (n=4) 649 MB (n=6) LZ4 1.1 GB (n=1) 1.7 GB (n=1) LZ4 1.1 GB (n=9) 1.9 GB (n=15) Snappy 1.1 GB (n=1) 2.0 GB (n=1) Snappy 1.1 GB (n=9) 1.8 GB (n=16) Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>	6 years ago
wphan	d627cda848	Support microsecond timestamp format (#1426 ) Adds microsecond timestamp support. https://github.com/grafana/loki/issues/1407	6 years ago
Peter Štibraný	a2c2a90907	Lint: comments Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>	6 years ago
Peter Štibraný	06007c0ad1	Renamed LZ4 -> Lz4 to make lint happy. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>	6 years ago
Peter Štibraný	fb143fec02	Undo small change. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>	6 years ago
Peter Štibraný	9979321c2a	Don't pool LZ4 readers that read big blocks. Such readers must have allocated twice as many bytes as the block size, and we don't want to pool them and keep that memory allocated. This can happen when reading chunks that were compressed with high buffer size. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>	6 years ago
Peter Štibraný	b0a7cf8f9d	Change default LZ4 buffer size to 64k. Added more LZ4 buffer size options for testing. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>	6 years ago
Robert Fratto	874d016bd7	promtail: add support for passing through journal entries as JSON This commit adds an extra configuration field (`json`) to the journal target configuration schema. When set to true, messages from the journal target will be passed through as JSON, containing all of the fields from the entry as keys and their values as the value. For backwards compatibility, the value for `json` defaults to false. Closes #1288.	6 years ago
Peter Štibraný	dca244f7aa	pkg/ingester: added sync period flags SyncPeriod can be used to tell ingesters to cut chunks early (before they are full) to synchronize ingesters so that they put the same data into the new chunks. If they do, they generate fully equal chunks and then they don't need to store them. To avoid very small chunks, additional parameter is added: -ingester.sync-min-utilization. When set to eg. 0.5, chunk must be at least 50% full (utilization) in order to be cut early for sync purposes. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>	6 years ago
Peter Štibraný	93b85f92fa	pkg/ingester: Added possibility to disable transfers. (#1425 ) Previously, with -ingester.max-transfer-retries set to zero, transfers would never stop. Now zero means don't transfer at all. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>	6 years ago
Cyril Tovena	949126e75b	Add a line limit in case a chunk is corrupted to avoid OOM. Also when running out of memory we should just return an error and not keep going. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>	6 years ago
Owen Diehl	ccf9630c58	asserts encodings are nominally the same in chunks during roundtrips	6 years ago
Owen Diehl	245fe8e022	roundtrip v2 encoding tests	6 years ago
Cyril Tovena	549250c30d	Sets the chunk encoding correctly when creating chunk from bytes. Previously only the reader and writer for the encoding was set, on subsequent serialization the format would be missing, this only happens if the chunk is created from a chunk transfer. Because it uses NewBytesChunk to load and also write. I've also added a regression tests. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>	6 years ago
Cyril Tovena	7654c27c12	Adds configurable compression algorithms for chunks (#1411 ) * Adds L4Z encoding. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com> * Adds encoding benchmarks Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com> * Adds snappy encoding. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com> * Adds chunk size test Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com> * Adds snappy v2 Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com> * Improve benchmarks Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com> * Remove chunkenc Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com> * Update lz4 to latest master version. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Use temporary buffer in serialise method to avoid allocations when doing string -> byte conversion. It also makes code little more readable. We pool those buffers for reuse. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Added gzip -1 for comparison. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Initialize reader and buffered reader lazily. This helps with reader/buffered reader reuse. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Don't keep entries, extracted generateData function (mostly to get more understandable profile) Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Improve test and benchmark to cover all encodings. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com> * Adds support for a new chunk format with encoding info. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com> * Ingesters now support encoding config. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com> * Add support for no compression. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com> * Add docs Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com> * Remove default Gzip for ByteChunk. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com> * Removes none, snappyv2 and gzip-1 Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com> * Move log test lines to testdata and add supported encoding stringer Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com> * got linted Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>	6 years ago
Peter Štibraný	4fea713b1e	pkg/promtail/client: missing URL in client returns error (#1416 ) Previously it would just panic, because URL.Host is used to construct logger. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>	6 years ago
Peter Štibraný	f6be636e13	RangeQuery benchmark optimizations (#1413 ) * Added some duplicate streams. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Instead of using sort.Sort(), we keep tuples sorted already. Also just return first element if there is only one tuple. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Don't do time comparison twice, compare nanoseconds instead. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>	6 years ago
Sebastian Widmer	f0f6f24926	pkg/promtail: IETF Syslog (RFC5424) Support (#1275 ) * IETF syslog (rfc5254) support * Upgrade go-syslog to correctly released v2.0.1 * Incorporate feedback from new linter * Update documentation with relevant RFC sections. * Incorporate feedback from review * Use context to shutdown server. * Use util.Backoff from cortex * Do not embed mutex into TestLabeledClient * Use strings.HasPrefix * Better naming of connectionsClosed -> openConnections * Incorporate further feedback from review * Callback instead of channel in ParseStream. Removes one running Goroutine per connection. * Improve parse error log level. * Move mutex above field it protects. * Use backoff.Ongoing() * Switch to "nontransparent" parser * Further improvements to the documentation	6 years ago
Peter Štibraný	3aff4dfe2f	pkg/cfg: print help only when requested, and print it on stdout (#1396 ) When invalid parameter or value is provided, error is printed to stderr, together with message indicating how to get list of all parameters. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>	6 years ago
Ed Welch	f9b25968f7	change the chunk size histogram to allow for bigger buckets (#1409 ) * change the chunk size histogram to allow for bigger buckets Signed-off-by: Edward Welch <edward.welch@grafana.com> * changing buckets again Signed-off-by: Edward Welch <edward.welch@grafana.com>	6 years ago
Edward Welch	591905ed64	forgot to register the new metric Signed-off-by: Edward Welch <edward.welch@grafana.com>	6 years ago
Ed Welch	5aa82ba199	allow configuring a target chunk size in compressed bytes (#1406 ) * allow configuring a target chunk size in compressed bytes Signed-off-by: Edward Welch <edward.welch@grafana.com> * addressing feedback Signed-off-by: Edward Welch <edward.welch@grafana.com>	6 years ago
Peter Štibraný	7bb77ecdd8	Convert string to bytes once only when doing string filtering. (#1405 ) This makes it slightly faster: name old time/op new time/op delta ContainsFilter-4 18.2ns ± 2% 9.8ns ± 1% -46.20% (p=0.000 n=10+8) name old alloc/op new alloc/op delta ContainsFilter-4 0.00B 0.00B ~ (all equal) name old allocs/op new allocs/op delta ContainsFilter-4 0.00 0.00 ~ (all equal) Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>	6 years ago
Cyril Tovena	1fc0ffde8a	Logql benchmark and performance improvement. (#1371 ) * Add logql benchmark test. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com> * Fixes store benchmark limits. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com> * Add LogQL improvements. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com> * Add back logging in the storage benchmark Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>	6 years ago
Edward Welch	ea5eec2abf	respond to label queries at `loki/api/v1/labels` instead of `loki/api/v1/label`	6 years ago
Owen Diehl	5227f5bee0	application/x-www-form-urlencoded support (#1381 ) * application/x-www-form-urlencoded support * handler func instead of unnecessary struct	6 years ago
Peter Štibraný	dd96fa146c	pkg/ingester: check that ingester is in LEAVING state when transferring chunks and claiming tokens. Required when using memberlist client. (#1300 ) * On chunks transfer, verify that source ingester is LEAVING This is important when using gossiping ring. If source ingester is not leaving yet, than claiming its tokens will fail (merge function will not move ownership to the target ingester), and target ingester will end up with no tokens in the ring. * Register ring to prometheus. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Update check using latest version from Cortex. There is no direct usage of logging, which is consistent with the rest of this method. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Move import to group of imports with third-party packages. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>	6 years ago
Peter Štibraný	e0ec61f986	pkg/ingester: handle labels mapping to the same fast fingerprint. (#1247 ) * pkg/ingester: handle labels mapping to the same fast fingerprint. Uses slightly adapted fpMapper code from Cortex. Fixes issue #898 Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * empty commit to force new build Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Removed empty lines in imports. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Added test that pushes entries concurrently. To be run with -race. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Stream now keeps both original and mapped fingerprint Mapped fingerprint is used in streams map. Original ("rawFP") is preserved when saving chunks. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Vendoring Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Reverted previous commit (keep the test, with updated checks). Preserving raw fingerprints could lead to data loss when doing chunk deduplication while storing chunks. We don't want that. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * go mod vendor Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>	6 years ago
Cyril Tovena	f7ee1c753c	Supports same duration format in LogQL as Prometheus Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>	6 years ago
Daniel D'Abate	df89859369	HTTP API: Support duration and float formats for step parameter (#1355 ) * Support duration and float formats for step parameter in http api * Support Prometheus duration format and add missing tests * Fixes linter Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>	6 years ago
Cyril Tovena	b34c2b0bd3	Move to jsoniter instead of default json package (#1249 ) * Move to jsoniter instead of default json package Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com> * Removes jsoniter on the logcli output Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>	6 years ago
Peter Štibraný	49d0d0f0da	Makefile changes to allow easy builds with or without vendoring. Also fixes version bug for both cases. (#1095 ) * Extracted -mod=vendor into a variable * Use ?= to set variable only if not set yet. This enables "MOD_VENDOR= make all" use from command line * Enable/disable vendoring with VENDOR=true or false. Enabled by default * Make go generate use -mod=vendor depending on VENDOR flag * Use GOMOD to specify module version to use. GOMOD can be set to empty string, "vendor", "readonly" and in Go 1.14 to "mod". If not defined, defaults to "vendor". Non empty values are passed to -mod parameter to Go tools, and --modules-download-mode parameter for golangci-cli linting tool. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Fix versioning info when not using vendoring. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Updated build image to use Golintci-cli v1.21.0 and Go 1.13.4. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Updated build image to version 0.8.0. Changs: Golintci-cli v1.21.0, Go 1.13.4. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Renamed MOD_VENDOR to MOD_FLAG to better describe its function. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Fix version info in all command line tools. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Use loki-build-image:0.8.0 Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>	6 years ago
Cyril Tovena	27f17bc1de	Fixes linter warning from the yacc file. (#1328 ) * Fixes linter warning from the yacc file. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com> * Improves sed to work on POSIX Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>	6 years ago
Julien Pivotto	eb7b495565	Metrics: use Namespace everywhere when declaring metrics (#1320 ) Code linting to make things consistent. Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	6 years ago
Peter Štibraný	125cfbfd5b	pkg/promtail/client: Handle fingerprint hash collisions (#1254 ) * Handle fingerprint hash collisions Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Instead of using fingerprints, use label strings as map keys. Label strings are properly sorted key=value pairs. This solution produces more garbage, but doesn't reinvent its own hashing, and keeps code simple. This seems to be a good tradeoff for promtail. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>	6 years ago
Peter Štibraný	9956717383	Include positions filename in the error when YAML unmarshal fails. (#1311 ) * Include positions filename in the error when YAML unmarshal fails. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Include filename when parsing of YAML/JSON file fails. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>	6 years ago
Putra Sattvika, I Gusti Ngurah	c89df1a795	storage: fix missing logs with batched chunk iterator (#1299 ) * fix batched chunk iterator * fix expected series labels in iterator_test.go * add query range boundary check * add __name__ label matcher to test cases * trim __name__ without mutating chunks	6 years ago
Robert Fratto	822e94fe6a	Fix v1 label API to be Prometheus-compatible (#1322 ) The label and label values API will now return the expected form of: ```json { "status": "success", "data": [ "label1", "label2", "labeln" ] } ```	6 years ago
Robert Fratto	715f215c50	pkg/promtail: remove journal target forced path (#1298 ) * pkg/promtail: remove journal target forced path The forced default path for the journal target (/var/log/journal) did not apply to all Linux systems: systemd actually defaults to reading from _two_ default paths: /var/log/journal and /run/log/journal. Not setting an explicit default will enable both of those paths to be searched for journal logs. The comment mentioning the local machine ID was technically accurate, but is normally dealt with by bind mounting /etc/machine-id. That's the standard approach for running fluent-bit in a container, and should be the standard approach for Promtail as well. Fixes #1286.	6 years ago
Julien Pivotto	7ccd0ab8d0	Use tenant as label name for discarded_samples metrics discarded_samples should use the name labels as the other metrics. Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	6 years ago
Julien Pivotto	5d1fec514c	Expose discarded bytes metric (#1317 ) Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	6 years ago
Edward Welch	20bb95f75a	Removing this file used to trick dep into importing packages, the second import already exists in the logproto.pb.go file and the first import is already imported other places in our code. This should fix the anyone using the logproto.pb.go file from registering a bunch of cortex metrics.	6 years ago
Peter Štibraný	fd25e6d180	Write positions to new file first, move to target destination afterwards. (#1304 ) Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>	6 years ago
Robert Fratto	a5765b57bf	pkg/distributor: fix metric loki_discarded_samples_total (#1279 ) loki_discarded_samples_total is supposed to be the count of samples that were discarded, but was instead being reported as the total bytes discarded. The metric has been fixed and a new metric, loki_discarded_bytes_total, has been added to report the total discarded bytes. Fixes #1255.	6 years ago
Owen Diehl	b5c03b0802	Fix duplicate labels (update cortex) (#1280 ) * Update to latest cortex to fix duplicate labels Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com> * Start the licycler in the ingester Required since this cortex change in `00566f61af`\#diff-dcd65a4ff2de424be70a561f141e067bR180 Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com> * go mod tidy Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com> * Move cortex to a fork for ARM support Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com> * updates cortex to master Signed-off-by: Owen Diehl <ow.diehl@gmail.com> * go mod tidy/vendor Signed-off-by: Owen Diehl <ow.diehl@gmail.com>	6 years ago
Robert Fratto	a1901e274a	pkg/loki: unmarshal module name from YAML (#1260 ) The module name field in the config could not be unmarshalled from a string, causing parsing the config to crash. This commit also changes the error message when the config could not be parsed to print directly to stderr, as the logger won't be initialized at the point where parsing the config fails, leading to no output in the console. Fixes #1259.	6 years ago
Marco Pracucci	9ec3117245	Move ReservedLabelTenantID out from a dedicated file (#1239 )	6 years ago
Marco Pracucci	04f58c880f	promtail: add multi-tenant support (#1135 ) * promtail: added tenant_id support to promtail client * promtail: added tenant stage to dinamically override the tenant ID * promtail: documented client's batch struct and improved tenant stage config pointer usage * Added static value support to tenant stage	6 years ago
Srinidhi Kaushik	90b937c743	Update dependencies to use weaveworks/common upstream (#1226 )	6 years ago

1 2 3 4 5 ...

397 Commits (768bf914e00f008bc833b87da7fdbdb55152df35)