9 Commits (7c85dd9e2d2b463d8d362aecefecfb2be02adaaf)

Author	SHA1	Message	Date
Ned Andreev	e6d82b9253	fix: remove unsafe pkg usage from util.mempool (#15428)	1 year ago
Paul Rogers	f2c2a22bdc	chore: Preparation for incoming static code analysis CI check (#15164) ... Co-authored-by: Danny Cooper <danny.cooper@grafana.com>	1 year ago
Christian Haudum	b1adfce5d0	chore(mempool): Wait for buffer instead of returning error (#13298) ... Signed-off-by: Christian Haudum <christian.haudum@gmail.com>	2 years ago
Christian Haudum	61a9854eb1	perf(mempool): Replace `sync.Mutex` with `sync.Once` (#13293) ... `sync.Once` uses an atomic integer as gate to check if the slab is already initialized and therefore yields a ~9% performance improvement for `get` operations. ``` goos: linux goarch: amd64 pkg: github.com/grafana/loki/v3/pkg/util/mempool cpu: 11th Gen Intel(R) Core(TM) i7-1185G7 @ 3.00GHz │ bench.old │ bench.new │ │ sec/op │ sec/op vs base │ Slab/1KB-8 138.5n ± 2% 125.1n ± 2% -9.71% (p=0.000 n=10) Slab/1MB-8 140.5n ± 3% 128.1n ± 2% -8.83% (p=0.000 n=10) Slab/128MB-8 143.0n ± 3% 130.4n ± 3% -8.81% (p=0.000 n=10) geomean 140.7n 127.8n -9.12% ``` Signed-off-by: Christian Haudum <christian.haudum@gmail.com>	2 years ago
Owen Diehl	eb1cd4c855	perf(blooms): mempool no longer zeroes out buffers unnecessarily (#13282)	2 years ago
Owen Diehl	d36e1d580a	fix(blooms): improves mempool metrics (#13283)	2 years ago
Christian Haudum	4117b6ca98	perf: Re-introduce fixed size memory pool for bloom querier (#13172) ... This PR re-introduces the fixed size memory pool that was originally introduced with #13039 but reverted with #13162 Additionally, it removes the package-global variable to store the type of allocator that should be used. Instead, the allocator type is passed during the bloom store creation. Signed-off-by: Christian Haudum <christian.haudum@gmail.com>	2 years ago
Owen Diehl	41c5ee21fc	fix(regression): reverts grafana/loki#13039 to prevent use-after-free corruptions (#13162)	2 years ago
Christian Haudum	fc264310ce	perf: Introduce fixed size memory pool for bloom querier (#13039) ... This PR introduces a fixed size memory pool for bloom pages that are loaded in the block querier. The aim of a fixed size pool of `[]byte` buffers is to reduce the amount of allocations, as well as to control the maximum heap size to prevent OOMing of the bloom gateways. Also, with the current usage of a `sync.Pool`, the query parallelism (`bloom-gateway.worker-concurrency` and `bloom-gateway.block-query-concurrency`) was defined by the `bloom.max-query-page-size` (and vice versa), because the max page size could be loaded `workers * concurrency` times at the same time. Most of the time, though, smaller pages are loaded, and therefore concurrency is not optimized. With the new fixed size memory pool, this problem should be solved. The pool is divided into slabs of different sizes holding different amounts of buffers; a larger amount of small sized buffers and a smaller amount of large sized buffers. Signed-off-by: Christian Haudum <christian.haudum@gmail.com>	2 years ago