apitech/loki - loki - Gitea: Git with a cup of tea

Commit Graph

Author SHA1 Message Date

Author	SHA1	Message	Date
Cyril Tovena	4df8c60b6b	chore(querier): Refactor the store and querier interface. (#15969 )	12 months ago
Ed Welch	4c88be0ef2	chore: update loki modules for 3.0 release (#12433 ) Signed-off-by: Edward Welch <edward.welch@grafana.com>	2 years ago
Karsten Jeschkies	6948c4a179	Turn frontend Tripperware into a Middleware. (#10688 ) What this PR does / why we need it: Currently, a request to Loki's frontend API goes through these conversions: ``` http.Request ↓ limitedRoundTripper queryrangebase.Request ↓ queryrangebase.Middlware … ↓ queryrangebase.Request ↓ limitedRoundTripper http.Request ↓ grpcRoundTripperAdapter httpgrpc ↓ grpcRoundTripperAdapter http.Response ↓ limitedRoundTripper queryrangebase.Response ↓ limitedRoundtripper http.Response ``` Since `httgrpc` and `queryrangebase.Request` are Protobufs there's no good reason to encode and decode them to HTTP responses/requests. Furthermore, the encoding to HTTP makes it harder for us to encode query plans. Thus the conversions are changed to the following: ``` http.Request ↓ queryrangebase.Request ↓ queryrangebase.Middlware … ↓ queryrangebase.Request ↓ httpgrpc ↓ queryrangebase.Response ↓ http.Response ``` In order to achieve this the `http.RoundTripper` is pushed to the outside. Only the serialization layer from `http.Request` to `queryrangebase.Request` and `http.Response` to `queryrangebase.Response` will be an `http.RoundTripper`. Everything else is either a `queryrangebase.Handler` or `queryrangebase.Middleware`. Checklist - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [x] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`)	2 years ago

Cyril Tovena

4df8c60b6b

chore(querier): Refactor the store and querier interface. (#15969 )

12 months ago

Ed Welch

4c88be0ef2

chore: update loki modules for 3.0 release (#12433 )

Signed-off-by: Edward Welch <edward.welch@grafana.com>

2 years ago

Karsten Jeschkies

6948c4a179

Turn frontend Tripperware into a Middleware. (#10688 )

**What this PR does / why we need it**:
Currently, a request to Loki's frontend API goes through these
conversions:
```
        http.Request 
            ↓ limitedRoundTripper
        queryrangebase.Request
            ↓ queryrangebase.Middlware
        … 
            ↓
        queryrangebase.Request
            ↓ limitedRoundTripper  
        http.Request
            ↓ grpcRoundTripperAdapter
        httpgrpc
            ↓ grpcRoundTripperAdapter
        http.Response
            ↓ limitedRoundTripper
        queryrangebase.Response
            ↓ limitedRoundtripper
        http.Response
```

Since `httgrpc` and `queryrangebase.Request` are Protobufs there's no
good reason to encode and decode them to HTTP responses/requests.
Furthermore, the encoding to HTTP makes it harder for us to encode query
plans.

Thus the conversions are changed to the following:
```
        http.Request 
            ↓
        queryrangebase.Request
            ↓ queryrangebase.Middlware
        … 
            ↓
        queryrangebase.Request
            ↓
        httpgrpc
            ↓
        queryrangebase.Response
            ↓
        http.Response
```

In order to achieve this the `http.RoundTripper` is pushed to the
outside. Only the serialization layer from `http.Request` to
`queryrangebase.Request` and `http.Response` to
`queryrangebase.Response` will be an `http.RoundTripper`. Everything
else is either a `queryrangebase.Handler` or
`queryrangebase.Middleware`.

**Checklist**
- [ ] Reviewed the
[`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md)
guide (**required**)
- [ ] Documentation added
- [x] Tests updated
- [ ] `CHANGELOG.md` updated
- [ ] If the change is worth mentioning in the release notes, add
`add-to-release-notes` label
- [ ] Changes that require user attention or interaction to upgrade are
documented in `docs/sources/setup/upgrade/_index.md`
- [ ] For Helm chart changes bump the Helm chart version in
`production/helm/loki/Chart.yaml` and update
`production/helm/loki/CHANGELOG.md` and
`production/helm/loki/README.md`. [Example
PR](d10549e3ec)

2 years ago

3 Commits (8976709f24dc9baa603d030fa23484382f7ba767)