apitech/loki - loki - Gitea: Git with a cup of tea

Author SHA1 Message Date

Author	SHA1	Message	Date
Salva Corts	7e248e1e90	Support non-indexed labels in WAL (#10011 ) What this PR does / why we need it: In https://github.com/grafana/loki/pull/9700, we support encoding and decoding non-indexed labels for each entry into the chunks. This PR adds support for writing/reading the non-indexed labels to/from the WAL. Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [x] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`)	3 years ago
Bryan Boreham	08ac5336d5	WAL: store pointers in record pool (#8667 ) What this PR does / why we need it: Storing a slice in `sync.Pool` wastes 24 bytes every time it is returned to the heap; see https://staticcheck.io/docs/checks#SA6002 Storing a pointer to a slice allows the Pool to work without waste. This came up in discussion about the benchmark in #8489 - with this change the memory usage comes down: ``` name old time/op new time/op delta Writer_WriteEntries/1000_lines,_1_different_label_sets-4 7.37ms ±13% 7.45ms ± 9% ~ (p=0.841 n=5+5) name old alloc/op new alloc/op delta Writer_WriteEntries/1000_lines,_1_different_label_sets-4 727kB ± 0% 679kB ± 0% -6.63% (p=0.008 n=5+5) name old allocs/op new allocs/op delta Writer_WriteEntries/1000_lines,_1_different_label_sets-4 12.0k ± 0% 10.0k ± 0% -16.68% (p=0.000 n=5+4) ``` Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - NA Documentation added - [x] Tests updated - NA `CHANGELOG.md` updated - NA Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	3 years ago
Pablo	fda14ca156	Re-license and export `pkg/ingester` WAL code to be used in Promtail's WAL (#8315 )	3 years ago

Salva Corts

Support non-indexed labels in WAL (#10011 )

**What this PR does / why we need it**:
In https://github.com/grafana/loki/pull/9700, we support encoding and
decoding non-indexed labels for each entry into the chunks. This PR adds
support for writing/reading the non-indexed labels to/from the WAL.

**Checklist**
- [x] Reviewed the
[`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md)
guide (**required**)
- [ ] Documentation added
- [x] Tests updated
- [ ] `CHANGELOG.md` updated
- [ ] If the change is worth mentioning in the release notes, add
`add-to-release-notes` label
- [ ] Changes that require user attention or interaction to upgrade are
documented in `docs/sources/upgrading/_index.md`
- [ ] For Helm chart changes bump the Helm chart version in
`production/helm/loki/Chart.yaml` and update
`production/helm/loki/CHANGELOG.md` and
`production/helm/loki/README.md`. [Example
PR](d10549e3ec)

3 years ago

Bryan Boreham

08ac5336d5

WAL: store pointers in record pool (#8667 )

**What this PR does / why we need it**:

Storing a slice in `sync.Pool` wastes 24 bytes every time it is returned
to the heap; see https://staticcheck.io/docs/checks#SA6002

Storing a pointer to a slice allows the Pool to work without waste.

This came up in discussion about the benchmark in #8489 - with this
change the memory usage comes down:
```
name                                                      old time/op    new time/op    delta
Writer_WriteEntries/1000_lines,_1_different_label_sets-4    7.37ms ±13%    7.45ms ± 9%     ~     (p=0.841 n=5+5)

name                                                      old alloc/op   new alloc/op   delta
Writer_WriteEntries/1000_lines,_1_different_label_sets-4     727kB ± 0%     679kB ± 0%   -6.63%  (p=0.008 n=5+5)

name                                                      old allocs/op  new allocs/op  delta
Writer_WriteEntries/1000_lines,_1_different_label_sets-4     12.0k ± 0%     10.0k ± 0%  -16.68%  (p=0.000 n=5+4)
```

**Checklist**
- [x] Reviewed the
[`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md)
guide (**required**)
- NA Documentation added
- [x] Tests updated
- NA `CHANGELOG.md` updated
- NA Changes that require user attention or interaction to upgrade are
documented in `docs/sources/upgrading/_index.md`

3 years ago

Pablo

fda14ca156

Re-license and export `pkg/ingester` WAL code to be used in Promtail's WAL (#8315 )

3 years ago

3 Commits (89985399817dde28fe5b94de990133d904bc3e5b)