apitech/loki - loki - Gitea: Git with a cup of tea

Commit Graph

Author	SHA1	Message	Date
Tobias Wolf	79e0d96978	Helm: Decouple the Canary from self-monitoring (#7757 ) What this PR does / why we need it: The Canary has no dependency on the Grafana Agent-based self-monitoring. This PR decouples that dependency, allowing the canary to be deployed with the other self-monitoring features. Which issue(s) this PR fixes: Fixes #7364	2 years ago
Charlie N	9d5665e34a	[Jsonnet] Fix memberlist when using a stateful ruler (#6662 ) Signed-off-by: Whyeasy <Whyeasy@users.noreply.github.com> <!-- Thanks for sending a pull request! Before submitting: 1. Read our CONTRIBUTING.md guide 2. Name your PR as `<Feature Area>: Describe your change`. a. Do not end the title with punctuation. It will be added in the changelog. b. Start with an imperative verb. Example: Fix the latency between System A and System B. c. Use sentence case, not title case. d. Use a complete phrase or sentence. The PR title will appear in a changelog, so help other people understand what your change will be. 3. Rebase your PR if it gets out of sync with main --> What this PR does / why we need it: When using stateful rulers and the memberlist as its ring, generating the resources with jsonnet throws in an error regarding the `ruler_deployment`. The `ruler_statefulset` didn't receive the meberlist labels either. <!-- Note about CHANGELOG entries, if a change adds: * an important feature * fixes an issue present in a previous release, * causes a change in operation that would be useful for an operator of Loki to know then please add a CHANGELOG entry. For documentation changes, build changes, simple fixes etc please skip this step. We are attempting to curate a changelog of the most relevant and important changes to be easier to ingest by end users of Loki. Note about the upgrade guide, if this changes: * default configuration values * metric names or label names * changes existing log lines such as the metrics.go query output line * configuration parameters * anything to do with any API * any other change that would require special attention or extra steps to upgrade Please document clearly what changed AND what needs to be done in the upgrade guide. --> Checklist - [ ] Documentation added - [ ] Tests updated - [x] Is this an important fix or new feature? Add an entry in the `CHANGELOG.md`. - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` Signed-off-by: Whyeasy <Whyeasy@users.noreply.github.com>	3 years ago
Leonardo Taccari	74906222c6	[helm] Release 3.6.1 to reintroduce PrometheusRule alerts (#7873 ) Commit `30caf142b2` introduced a regression ending up in generating no PrometheusRule alerts. That was fixed in commit `433d883fcd` but no releases were done. Bump version to have a release about it. What this PR does / why we need it: Which issue(s) this PR fixes: Should hopefully fix a request done by @xinbinhuang - who spotted and fixed this problem, thanks! - in #7860. I think it is important to tag a release ASAP because stopping having alerts can be a regression in possible production environments. Special notes for your reviewer: I have no idea if that will force to release a 3.6.1 Helm release without doing any tag or similar, sorry! I have tried to skim documentation about that and I have skimmed `.github/workflows/helm-release.yaml` and `grafana/helm-charts/.github/workflows/update-helm-repo.yaml@main` and I think that this will create a tag... but I'm not super-sure about that! If I've missed anything please let me know! Thanks! Checklist - [x] Reviewed the `CONTRIBUTING.md` guide - [ ] Documentation added - [ ] Tests updated - [x] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	3 years ago
Xinbin Huang	433d883fcd	Fix broken canary loki alerts (#7860 )	3 years ago
Trevor Whitney	652e216a85	[helm] Bump helm Loki and GEL version (#7760 ) What this PR does / why we need it: Bumps Loki to 2.7.0 and GEL to 1.6.0 in the helm chart.	3 years ago
Anders Bennedsgaard	b5563cee08	[Helm] Remove unused value and set default values explicitly (#7576 ) What this PR does / why we need it: `monitoring.alerts` are not used in the Loki Helm chart. This removes it. Furthermore, some values are referenced in the templates, but not used in the values file. This adds the default values. Which issue(s) this PR fixes: Fixes #7575 Special notes for your reviewer: https://github.com/AndersBennedsgaard/loki/blob/main/production/helm/loki/templates/single-binary/pdb.yaml#L15 should probably also be updated since `podDisruptionBudget` is not referenced in the values file. However, I am unsure what default values should be used. https://github.com/AndersBennedsgaard/loki/blob/main/production/helm/loki/templates/networkpolicy.yaml#L124 should probably also be updated since the `loki.rulerSelectorLabels` is not a valid helper function. However, I am unsure which selector labels to use. Especially since it seems like `ruler` is not used. Perhaps any reference to `ruler` should be removed? Checklist - [x] Reviewed the `CONTRIBUTING.md` guide - [x] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	3 years ago
Jan-Otto Kröpke	5dc60567da	[Helm] Add support for azure blob storage (#7500 ) What this PR does / why we need it: Support Azure Blob Storage in helm chart. See https://grafana.com/docs/loki/latest/storage/#azure-storage-account-1 Which issue(s) this PR fixes: Special notes for your reviewer: Checklist - [ ] Reviewed the `CONTRIBUTING.md` guide - [x] Documentation added - [ ] Tests updated - [x] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` Signed-off-by: Jan-Otto Kröpke <jok@cloudeteer.de>	3 years ago
Karsten Jeschkies	691b8be6c7	Provide Terraform script for setting up S3 and document role based access. (#7656 ) What this PR does / why we need it: Role based access to S3 on an EKS cluster via service account annotation was not documented well and let to some confusion. This change documents how a role based accessis achieved with providing an AWS secret access key and access key id. Thus there is no change of accidentally leaking credentials. A Terraform module is provided under `production/terraform/modules/s3` that provisions and S3 bucket and IAM role and policy. Which issue(s) this PR fixes: Fixes #7279 Special notes for your reviewer: Checklist - [ ] Reviewed the `CONTRIBUTING.md` guide - [x] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` Co-authored-by: Pablo Angulo <pablo.angulo@grafana.com>	3 years ago
Teddy Andrieux	217a914f98	helm/loki: Allow to override default loki `target` (#7791 ) What this PR does / why we need it: Add the ability to change the Loki `target` argument. E.g. one might want to use the single-binary which has target `all` but also the `table-manager` which is not part of it. So one can override the target with `all,table-manager`. Which issue(s) this PR fixes: Fixes #7788 Special notes for your reviewer: Checklist - [x] Reviewed the `CONTRIBUTING.md` guide - [x] `CHANGELOG.md` updated	3 years ago
Alexandre de Sá	040c549845	[Docs] Fix helm loki examples links (#7779 ) Fixes links to Helm documentation.	3 years ago
Trevor Whitney	ea4a764143	[helm] Fix incorrect ingress paths when using single binary deployment (#7530 ) What this PR does / why we need it: The helm ingress template was copied over from the simple scalable chart and does not work when deploying the chart in single binary configuration. This fixes that by adding a set of single binary routes, and conditionally configuring the ingress resource based on deployment type. Which issue(s) this PR fixes: Fixes #7080 Special notes for your reviewer: Checklist - [ ] Reviewed the `CONTRIBUTING.md` guide - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	3 years ago
Christian Haudum	48c3fb4c7c	Fix label selector for gateway service in operational dashboard Use `job=~\"$namespace/cortex-gw(-internal)?\"` throughout the dashboard. This fixes the occurrence where a regex value was used in combination with an exact label match. Signed-off-by: Christian Haudum <christian.haudum@gmail.com>	3 years ago
Christian Haudum	6c7a4dcdbd	[loki-mixin] Make "Success Rate" panels in operational dashboard more accurate (#7756 )	3 years ago
Christian Haudum	fbd5bbb09d	Improve error logs query in operational dashboard Instead of parsing all lines and filtering on `level` label, just filter by `level=error` string. Signed-off-by: Christian Haudum <christian.haudum@gmail.com>	3 years ago
MiggL	a8c71d27a8	[helm] Fix read-only /tmp in single-binary mode (#7695 ) What this PR does / why we need it: When running in single-binary mode, these warnings may appear: `level=warn ts=2022-11-15T08:01:39.777179378Z caller=marker.go:214 msg="failed to process marks" path=/var/loki/compactor/retention/markers/1668476560013344947 err="open /tmp/marker-view-912253853: read-only file system"` This was previously fixed in the old chart: grafana/helm-charts#967 Which issue(s) this PR fixes: Fixes grafana/helm-charts#609, again. Checklist - [x] Reviewed the `CONTRIBUTING.md` guide	3 years ago
Teddy Andrieux	20d801a09d	helm/loki: Remove extra `/` if `registry` or `repository` is empty (#7746 ) What this PR does / why we need it: It removes the extra `/` when `registry` or `repository` is empty Which issue(s) this PR fixes: Fixes #7739 Special notes for your reviewer: Checklist - [x] Reviewed the `CONTRIBUTING.md` guide - [x] `CHANGELOG.md` updated	3 years ago
Teddy Andrieux	220770c693	helm/loki: Allow to provide selector for Loki persistence volume (#7743 )	3 years ago
Karsten Jeschkies	54320e827c	Correct Helm documentation aliases. (#7537 ) What this PR does / why we need it: #7034 introduced a regression in the documentation. This changes corrects the aliases of the Helm documentation pages. Checklist - [ ] Reviewed the `CONTRIBUTING.md` guide - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	3 years ago
Duc Tran	76e12529af	Just remove some spaces (#7681 ) What this PR does / why we need it: Which issue(s) this PR fixes: Fixes #<issue number> Special notes for your reviewer: Checklist - [ ] Reviewed the `CONTRIBUTING.md` guide - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	3 years ago
Jasper	706c22e9e4	Loki: Add querier config to loki helm (#7627 ) add the ability to update querier config using `values.yaml` file	3 years ago
Trevor Whitney	2997986ad3	[helm] Ignore single binary headless service from service-monitor (#7638 ) What this PR does / why we need it: Ignore the headless service from the Prometheus service-monitor as it was resulting in duplicate metrics. Replaces https://github.com/grafana/loki/pull/7049	3 years ago
Ryan Garcia	9c2da08ef5	[Helm] Updating tokgen job imagePullSecret templating (#7524 ) Signed-off-by: garcia.ryan <garcia.ryan@solute.us> What this PR does / why we need it: Updating `imagePullSecret` templating to correctly template in matching key from values. Which issue(s) this PR fixes: Fixes #7523 Co-authored-by: Trevor Whitney <trevorjwhitney@gmail.com>	3 years ago
Alexandru Gologan	726e4608d1	[Helm] Create metricsInstance only if available (#7535 ) What this PR does / why we need it: If you're using prometheus operator and not Grafana Agent a metricsInstance shouldn't be auto-created. Which issue(s) this PR fixes: #7529	3 years ago
Vladyslav Diachenko	15817eb14b	updated chart version to 3.3.2 to release merged changes (#7618 ) changes for 3.3.2 were merged today but the chart was not released because chart version was not bumped and docs were not re-generated fixes: https://github.com/grafana/loki/pull/7266	3 years ago
Max Vorobev	e537cb52d3	[Helm] fix typos in parameter descriptions (#7527 ) What this PR does / why we need it: Fixes typos in metrics-related Helm chart parameter descriptions. Which issue(s) this PR fixes: Fixes #<issue number> Special notes for your reviewer: Checklist - [x] Reviewed the `CONTRIBUTING.md` guide - [x] Documentation added - [x] Tests updated - [x] `CHANGELOG.md` updated - [x] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	3 years ago
Joseph Daniel	febb2940ae	Add docs for jsonnet SSD example (#6908 ) Loki's jsonnet libs are no longer in `github.com/grafana/jsonnet-libs` repo this MR fixes that import. Also adds some docs for utilizing the example.	3 years ago
zarikx	8f98d45aaa	loki helm chart: fix indentation in single-binary pdb template (#7266 ) What this PR does / why we need it: After enabling pdb in `loki` helm chart, occurs `unknown field "app.kubernetes.io/name" in io.k8s.apimachinery.pkg.apis.meta.v1.LabelSelector]` error Which issue(s) this PR fixes: Indentation in single-binary pdb template	3 years ago
Jan-Otto Kröpke	9e300baf89	[Helm] Add toggle for MetricsInstance (#7525 ) Signed-off-by: Jan-Otto Kröpke <jok@cloudeteer.de> What this PR does / why we need it: Chart version 3.3.0 introduced a new MetricsInstance CR. The only way to disable the MetricsInstance is `--set loki.monitoring.serviceMonitor.metricsInstance=null`, but this raises helm warning... ``` coalesce.go:220: warning: cannot overwrite table with non table for loki.monitoring.serviceMonitor.metricsInstance (map[annotations:map[] labels:map[] remoteWrite:<nil>]) coalesce.go:220: warning: cannot overwrite table with non table for loki.monitoring.serviceMonitor.metricsInstance (map[annotations:map[] labels:map[] remoteWrite:<nil>]) coalesce.go:220: warning: cannot overwrite table with non table for loki.monitoring.serviceMonitor.metricsInstance (map[annotations:map[] labels:map[] remoteWrite:<nil>]) ``` Checklist - [ ] Reviewed the `CONTRIBUTING.md` guide - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` Signed-off-by: Jan-Otto Kröpke <jok@cloudeteer.de>	3 years ago
Trevor Whitney	b523ff336e	[Helm] Fix invalid ruler config when filesystem storage is used (#7528 ) What this PR does / why we need it: When using filesystem storage, there's a bug in the configmap helm template that sets `ruler.storage` to `null`. This fixes that bug. Which issue(s) this PR fixes: Fixes #7267	3 years ago
Karsten Jeschkies	b16ad8cb38	Document new Helm Charts (#7034 ) What this PR does / why we need it: This change describes various Helm related tasks such as installing Loki and configuring meta monitoring. It also explains different concepts related to the new Helm chart and provides a reference of the new Helm values file. Which issue(s) this PR fixes: Fixes #7035	3 years ago
Trevor Whitney	705e16fbea	[helm] Fix included rules (#7430 ) What this PR does / why we need it: Adds the correct cluster label to our recording rules so they work correctly in the included dashboards. Co-authored-by: Karsten Jeschkies <k@jeschkies.xyz>	3 years ago
Jan-Otto Kröpke	77225e8a7c	Remove prometheus CRDs (#7499 ) What this PR does / why we need it: Remove Prometheus CRDs from loki chart. Signed-off-by: Jan-Otto Kröpke <jok@cloudeteer.de> Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>	3 years ago
Trevor Whitney	6c53113be1	[helm] Add a loki canary test to the helm chart (#7229 ) What this PR does / why we need it: Add a helm chart test that utilizes the Loki canary to confirm the Loki cluster is functioning correctly. Which issue(s) this PR fixes: Fixes #7228 Co-authored-by: Karsten Jeschkies <k@jeschkies.xyz>	3 years ago
Karsten Jeschkies	9bc6e85604	Helm: Allow users to define remote write for metrics. (#7399 )	3 years ago
Goutham Veeramachaneni	1260adc756	[mixin] Add cortex-gw-internal to dashboards (#7481 )	3 years ago
Trevor Whitney	ae2a6f31ae	[Helm] Add flags needed for migration from distributed (#7331 ) What this PR does / why we need it: Adds flags to the helm charts that are needed when doing a zero-downtime migration from a `loki-distributed` helm chart deployment. The flags allow for an additional memberlist join member to be specified. This allows the new `grafana/loki` cluster to join the old `grafana/loki-distributed` cluster, forming one big cluster. The ingesters in the `grafana/loki-distributed` cluster can then be taken down 1-by-1, allowing the whole `grafana/loki-distributed` cluster to be deleted once all the ingesters have scaled down. Which issue(s) this PR fixes: Fixes #7330 Co-authored-by: Karsten Jeschkies <k@jeschkies.xyz>	3 years ago
Trevor Whitney	16862b1edc	[helm] Mimic loki service account with canary account (#7236 ) What this PR does / why we need it: Bring the Loki Canary service account in line with the Loki service account, removing the post install hook, and sharing the top level properties for `automountServiceAccountToken` and `imagePullSecrets`. I'm open to creating canary specific values for these setting if needed, but want to start by sharing the top level values to reduce config if possible. Also default canary to Appversion to be in sync with default Loki version Which issue(s) this PR fixes: Fixes two issues raised in comments from @towolf (thanks!) on this [PR](https://github.com/grafana/loki/pull/7173#issuecomment-1256410181). Fixes #7237	3 years ago
Tim Schwenke	ff406bd4a9	Helm: Replace incorrect key loki.authEnabled in example override values (#7432 ) What this PR does: Replace `loki.authEnabled` in one of the example override YAMLs with `loki.auth_enabled` to match the actual key name. Also adds missing newline at end of file.	3 years ago
Mohamed-Amine Bouqsimi	7debe7c235	Ruler: enable Loki to configure Alertmanagers per tenant (#7359 )	3 years ago
Michel Hollands	488e64e3ff	Update helm chart version (#7484 ) Update the Loki helm chart version after the changes made in https://github.com/grafana/loki/pull/7479 Signed-off-by: Michel Hollands <michel.hollands@grafana.com>	3 years ago
Michel Hollands	ec541d70e9	Add envFrom to the tokengen job (#7479 ) Add an envFrom section to the tokengen job. Fixes https://github.com/grafana/loki/issues/7411 Signed-off-by: Michel Hollands <michel.hollands@grafana.com>	3 years ago
Karsten Jeschkies	62707bf517	Loki mixin: Correct Loki datasource variable name. (#7422 )	3 years ago
Hervé Nicol	91299ab729	[helm loki] add support for custom analytics config (#7262 ) What this PR does / why we need it: I want to disable usage reporting to Grafana. On clusters that don't have access to Internet it generates error logs. And without this patch, the only way is to have the whole `loki.config` section in my custom values file. Checklist - [x] Reviewed the `CONTRIBUTING.md` guide - [x] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` Co-authored-by: Herve Nicol <12008875+hervenicol@users.noreply.github.com>	3 years ago
Karsten Jeschkies	30caf142b2	Provision alerts for Loki Canary in Helm Chart. (#7286 ) What this PR does / why we need it: The Helm Charts install the Loki canary. It should also install the alerts for the canary so the users get the full value. Which issue(s) this PR fixes: Fixes #7284 Special notes for your reviewer: Checklist - [ ] Reviewed the `CONTRIBUTING.md` guide - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	3 years ago
Karsten Jeschkies	6d495a393e	Import Canary dashboard into Loki mixin. (#7304 ) Summary: This imports our canary into the Loki mixin so it can be used by the Helm chart. The dashboard is disabled by default. It can be enabled by setting ```jsonnet { _config+:: { canary+: { enabled: true, }, }, } ``` Co-authored-by: Vladyslav Diachenko <82767850+vlad-diachenko@users.noreply.github.com>	3 years ago
Callum Styan	a7e7a8e013	[dashboards] update dashboards for zone aware ingesters (#7313 ) Mostly related to the job selector; I deployed these against a local grafana instance along the way and I think I got everything correct but we might still need to update some of these again. Signed-off-by: Callum Styan <callumstyan@gmail.com> Signed-off-by: Callum Styan <callumstyan@gmail.com>	3 years ago
Vladyslav Diachenko	c9165fb768	[loki helm chart] fixed to pass CI (#7345 ) Bumped version of the chart and added changelog. These changes were missed in https://github.com/grafana/loki/pull/7301	3 years ago
Byron Esteban	5d441b5526	Service selector for single binary deployment fix. (#7301 ) Single binary deployment is not working when going through default service. The issue is with the labels that currently includes the canary pods. Fixes #7260	3 years ago
Danny Kopping	fb6231bd6b	Add compactor_address to fix startup (#7332 ) The `production/docker` docker-compose setup was broken because of a missing configuration.	3 years ago
Michel Hollands	682e9c881d	Add list of delete requests to deletion dashboard (#7309 ) Add 2 panels to the deletion dashboard that show: - the in progress/finished delete requests during the selected period - the delete request that have been entered, with the query This will help with trouble-shooting deletions. Signed-off-by: Michel Hollands <michel.hollands@grafana.com>	3 years ago

1 2 3 4 5 ...

630 Commits (c71620ae9437aa23142cdc410115f28ae8f29997)