apitech/loki - loki - Gitea: Git with a cup of tea

Commit Graph

Author	SHA1	Message	Date
Trevor Whitney	eb39e2645f	[helm] allow provisioned tokens to be created in different namespaces (#8081 ) What this PR does / why we need it: _Note_: This PR bumps the chart to 4.0, so it includes a few other breaking changes we've been waiting to make. The new helm chart has a few different ways to create tokens when running in enterprise mode: * The tokengen job creates the initial admin token * The provisioner job creates the self-monitoring tenant if enabled * The provisioner job can also create additional tenants if configured The problem with these jobs is they put the generated read/write tokens for these tenants in secrets in the same namespace as the loki deploiyment. This is problematic if you need these tokens for a specific application, for example a Grafana datasource, that is deployed in a separate namespace. This PR introduces two breaking changes, one of which is breaking as it significantly changes how both the self monitoring and additional tenants are configured. First it adds the value `enterprise.adminToken.additionalNamespaces` and moves `enterprise.adminTokenSecret` to `enterprise.adminToken.secret`. If `additionalNamespaces` are included, additional secrets containing the GEL admin token are created in those namespaces as well as the release namespace. Second, it changes the structure of defining a tenant from just a string name, to an object containing a `name` and `secretNamespace` field. The `secretNamespace` is the namespace the secret containing that tenants token(s) will be placed in. In the case of the self-monitoring token, a secret will still be created in the default namespace in addition to the `secretNamespace` specified as that token is required by multiple components.	2 years ago
JordanRushing	d8a0c6f87f	Revert "[loki-canary] Support passing loki address as environment variable (#8024 )" (#8183 ) What this PR does / why we need it: This PR reverts commit `f9ed9cb7d9` which introduced breaking config changes for the Loki canary. The relevant change introduced support for configuring a new `LOKI_ADDRESS` canary environment variable by adopting a new library for flags. This is the easiest path forward to avoid forcing breaking config changes on canary operators; such a change is likely better suited to join other configuration changes in a future major Loki release. Which issue(s) this PR fixes: N/A Special notes for your reviewer: Related PR: - https://github.com/grafana/loki/pull/8024 Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [x] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
liam-howe-maersk	4681f9f487	Alerts: Exclude '/schedulerpb.SchedulerForQuerier/QuerierLoop' route in LokiRequestLatency alert (#8138 ) Excludes the route `/schedulerpb.SchedulerForQuerier/QuerierLoop` from the `LokiRequestLatency` alert query config. We have found that this route often has extremely high request latencies which will trigger the alert constantly for us. Looking through the source code it seems like it is expected to have high request latencies for this route and so in our configuration have excluded the route. We can see that this route is also being excluded in the [respective mimir config](https://github.com/grafana/mimir/blob/main/operations/mimir-mixin-compiled/alerts.yaml#L33) so believe it might be relevant to exclude here in loki as well	2 years ago
dependabot[bot]	70997fd090	Bump github.com/imdario/mergo from 0.3.12 to 0.3.13 (#8176 ) Bumps [github.com/imdario/mergo](https://github.com/imdario/mergo) from 0.3.12 to 0.3.13. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/imdario/mergo/releases">github.com/imdario/mergo's releases</a>.</em></p> <blockquote> <h2>Merging same-type slices supported, YAML upgraded to v3 (only used in tests), and more flexibility for transformers</h2> <h2>What's Changed</h2> <ul> <li>Fix typo in README.md by <a href="https://github.com/eltociear"><code>@eltociear</code></a> in <a href="https://github-redirect.dependabot.com/imdario/mergo/pull/184">imdario/mergo#184</a></li> <li>Adding StructBot to Mergo in the wild section by <a href="https://github.com/tjpnz"><code>@tjpnz</code></a> in <a href="https://github-redirect.dependabot.com/imdario/mergo/pull/193">imdario/mergo#193</a></li> <li>Add Goreleaser to featured projects by <a href="https://github.com/marcauberer"><code>@marcauberer</code></a> in <a href="https://github-redirect.dependabot.com/imdario/mergo/pull/191">imdario/mergo#191</a></li> <li>fix: gate transformers on valid non-nil destinations by <a href="https://github.com/zaquestion"><code>@zaquestion</code></a> in <a href="https://github-redirect.dependabot.com/imdario/mergo/pull/211">imdario/mergo#211</a></li> <li>Support slices of same type by <a href="https://github.com/heaths"><code>@heaths</code></a> in <a href="https://github-redirect.dependabot.com/imdario/mergo/pull/210">imdario/mergo#210</a></li> <li>Upgrade yaml to v3 by <a href="https://github.com/imdario"><code>@imdario</code></a> in <a href="https://github-redirect.dependabot.com/imdario/mergo/pull/212">imdario/mergo#212</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/eltociear"><code>@eltociear</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/imdario/mergo/pull/184">imdario/mergo#184</a></li> <li><a href="https://github.com/tjpnz"><code>@tjpnz</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/imdario/mergo/pull/193">imdario/mergo#193</a></li> <li><a href="https://github.com/marcauberer"><code>@marcauberer</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/imdario/mergo/pull/191">imdario/mergo#191</a></li> <li><a href="https://github.com/zaquestion"><code>@zaquestion</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/imdario/mergo/pull/211">imdario/mergo#211</a></li> <li><a href="https://github.com/heaths"><code>@heaths</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/imdario/mergo/pull/210">imdario/mergo#210</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/imdario/mergo/compare/0.3.12...v0.3.13">https://github.com/imdario/mergo/compare/0.3.12...v0.3.13</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="`1949787570`"><code>1949787</code></a> Update README.md</li> <li><a href="`80c13e16e7`"><code>80c13e1</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/imdario/mergo/issues/212">#212</a> from imdario/dcc/issue-206</li> <li><a href="`f86e6f60b7`"><code>f86e6f6</code></a> Upgrade yaml to v3</li> <li><a href="`39ebbbb298`"><code>39ebbbb</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/imdario/mergo/issues/210">#210</a> from heaths/issue209</li> <li><a href="`fd7d2bcdb0`"><code>fd7d2bc</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/imdario/mergo/issues/211">#211</a> from zaquestion/transformer_valid_destination</li> <li><a href="`8109749b3e`"><code>8109749</code></a> add test for deepMerge panic</li> <li><a href="`4bed36ec55`"><code>4bed36e</code></a> add test for keeping zero values with transformer</li> <li><a href="`ab6b2707a1`"><code>ab6b270</code></a> fix: gate transformers on valid non-nil destinations</li> <li><a href="`200f90d970`"><code>200f90d</code></a> Support slices of same type</li> <li><a href="`fd3dfc91a2`"><code>fd3dfc9</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/imdario/mergo/issues/191">#191</a> from marcauberer/master</li> <li>Additional commits viewable in <a href="https://github.com/imdario/mergo/compare/0.3.12...v0.3.13">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/imdario/mergo&package-manager=go_modules&previous-version=0.3.12&new-version=0.3.13)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2 years ago
Danny Kopping	4e16ea6b4d	Minor LID fixes (#8167 ) Signed-off-by: Danny Kopping <danny.kopping@grafana.com>	2 years ago
Kaviraj Kanagaraj	2597429c89	promtail: Add `max-line-size` limit to drop on client side (#8153 )	2 years ago
Kaviraj Kanagaraj	9b5fa5e100	doc(distributor): Clarify `distributor.max-line-size` flag. (#8165 ) What this PR does / why we need it: Add a clarrification of two flags `distributor.max-line-size` and `distributor.max-line-size-truncate`. And clarity on [discarding the logs](https://github.com/grafana/loki/blob/main/pkg/distributor/validator.go#L84-L92) if later is disabled while still former is set to non-zero values. Whereas if `distributor.max-line-size-truncate` is set, [log line is only truncated.](https://github.com/grafana/loki/blob/main/pkg/distributor/distributor.go#L517-L534) Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com> Which issue(s) this PR fixes: Fixes #NA Special notes for your reviewer: Figured while working on PR #8153 Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [x] Documentation added Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>	2 years ago
Danny Kopping	7c78d7ea44	Removing "replace" directive for line-buffered logger (#8162 )	2 years ago
dependabot[bot]	36907a81dd	Bump golang.org/x/time from 0.1.0 to 0.3.0 (#8161 ) Bumps [golang.org/x/time](https://github.com/golang/time) from 0.1.0 to 0.3.0. <details> <summary>Commits</summary> <ul> <li><a href="`2c09566ef1`"><code>2c09566</code></a> rate: the state of the limiter should not be changed when the requests failed</li> <li><a href="`80b9fac54d`"><code>80b9fac</code></a> x/time/rate: add rate.Sometimes, which runs a function occasionally.</li> <li>See full diff in <a href="https://github.com/golang/time/compare/v0.1.0...v0.3.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=golang.org/x/time&package-manager=go_modules&previous-version=0.1.0&new-version=0.3.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2 years ago
Karsten Jeschkies	17fdfcbaa1	Emit help message when check-mod fails (#8157 )	2 years ago
dependabot[bot]	a8a4ba742d	Bump github.com/Masterminds/sprig/v3 from 3.2.2 to 3.2.3 (#8159 ) Bumps [github.com/Masterminds/sprig/v3](https://github.com/Masterminds/sprig) from 3.2.2 to 3.2.3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/Masterminds/sprig/releases">github.com/Masterminds/sprig/v3's releases</a>.</em></p> <blockquote> <h2>v3.2.3</h2> <h2>Changed</h2> <ul> <li>Updated docs (thanks <a href="https://github.com/book987"><code>@book987</code></a> <a href="https://github.com/aJetHorn"><code>@aJetHorn</code></a> <a href="https://github.com/neelayu"><code>@neelayu</code></a> <a href="https://github.com/pellizzetti"><code>@pellizzetti</code></a> <a href="https://github.com/apricote"><code>@apricote</code></a> <a href="https://github.com/SaigyoujiYuyuko233"><code>@SaigyoujiYuyuko233</code></a> <a href="https://github.com/AlekSi"><code>@AlekSi</code></a>)</li> <li><a href="https://github-redirect.dependabot.com/Masterminds/sprig/issues/348">#348</a>: Updated huandu/xstrings which fixed a snake case bug (thanks <a href="https://github.com/yxxhero"><code>@yxxhero</code></a>)</li> <li><a href="https://github-redirect.dependabot.com/Masterminds/sprig/issues/353">#353</a>: Updated masterminds/semver which included bug fixes</li> <li><a href="https://github-redirect.dependabot.com/Masterminds/sprig/issues/354">#354</a>: Updated golang.org/x/crypto which included bug fixes</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/Masterminds/sprig/blob/master/CHANGELOG.md">github.com/Masterminds/sprig/v3's changelog</a>.</em></p> <blockquote> <h2>Release 3.2.3 (2022-11-29)</h2> <h3>Changed</h3> <ul> <li>Updated docs (thanks <a href="https://github.com/book987"><code>@book987</code></a> <a href="https://github.com/aJetHorn"><code>@aJetHorn</code></a> <a href="https://github.com/neelayu"><code>@neelayu</code></a> <a href="https://github.com/pellizzetti"><code>@pellizzetti</code></a> <a href="https://github.com/apricote"><code>@apricote</code></a> <a href="https://github.com/SaigyoujiYuyuko233"><code>@SaigyoujiYuyuko233</code></a> <a href="https://github.com/AlekSi"><code>@AlekSi</code></a>)</li> <li><a href="https://github-redirect.dependabot.com/Masterminds/sprig/issues/348">#348</a>: Updated huandu/xstrings which fixed a snake case bug (thanks <a href="https://github.com/yxxhero"><code>@yxxhero</code></a>)</li> <li><a href="https://github-redirect.dependabot.com/Masterminds/sprig/issues/353">#353</a>: Updated masterminds/semver which included bug fixes</li> <li><a href="https://github-redirect.dependabot.com/Masterminds/sprig/issues/354">#354</a>: Updated golang.org/x/crypto which included bug fixes</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="`581758eb7d`"><code>581758e</code></a> Updating the changelog for the 3.2.3 release</li> <li><a href="`5787448a04`"><code>5787448</code></a> Updating changelog for 3.2.2 release</li> <li><a href="`8489c3eb22`"><code>8489c3e</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/Masterminds/sprig/issues/354">#354</a> from mattfarina/bump-crypto-v0.3.0</li> <li><a href="`42ac6ac131`"><code>42ac6ac</code></a> Updating crypto library</li> <li><a href="`d65147bc88`"><code>d65147b</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/Masterminds/sprig/issues/353">#353</a> from mattfarina/bump-semver-3.2.0</li> <li><a href="`92ac1aee6a`"><code>92ac1ae</code></a> Updating semver package</li> <li><a href="`ce20d69f9f`"><code>ce20d69</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/Masterminds/sprig/issues/313">#313</a> from book987/master</li> <li><a href="`f9a478a510`"><code>f9a478a</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/Masterminds/sprig/issues/334">#334</a> from aJetHorn/patch-1</li> <li><a href="`58a4f651e0`"><code>58a4f65</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/Masterminds/sprig/issues/349">#349</a> from mattfarina/bump-go-19</li> <li><a href="`32424cc260`"><code>32424cc</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/Masterminds/sprig/issues/347">#347</a> from neelayu/patch-1</li> <li>Additional commits viewable in <a href="https://github.com/Masterminds/sprig/compare/v3.2.2...v3.2.3">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/Masterminds/sprig/v3&package-manager=go_modules&previous-version=3.2.2&new-version=3.2.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2 years ago
Dimitar Dimitrov	723f524e3b	Fix link to CONTRIUTING.md in PR template (#8156 ) The previous link lead to https://github.com/grafana/loki/CONTRIBUTING.md which doesn't exist.	2 years ago
Dimitar Dimitrov	6ea5a8e497	Update vendored dskit (#8155 ) What this PR does / why we need it: The Changelog diff between the two commits is `3e308a4944...7242706251` ``` * [CHANGE] Cache: Switch Memcached backend to use `github.com/grafana/gomemcache` repository instead of `github.com/bradfitz/gomemcache`. #248 * [ENHANCEMENT] Add cache, gate and stringsutil packages. #239 * [ENHANCEMENT] Cache: add Redis support. #245 * [ENHANCEMENT] Cache: Add the ability to use a custom memory allocator for cache results. #249 * [BUGFIX] Memberlist: fix crash when methods from `memberlist.Delegate` interface are called on `memberlist.KV` before the service is fully started. #244 ``` Checklist* - [x] Reviewed the [`CONTRIBUTING.md`](../CONTRIBUTING.md) guide (required) - N/A Documentation added - N/A Tests updated - N/A `CHANGELOG.md` updated - N/A Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
Luis Felipe Vaca	d317e659c7	lambda-promtail-: fix parse kinesis timestamp (#7158 )	2 years ago
Owen Diehl	07487cd89d	fixes bug with queryIngesterWithin logic in asyncStore ingester stats… (#8145 ) Fixes a previous mistake in the logic calculating when to skip querying ingesters in the async store Statistics method. Notably `through.After` should be `through.Before` when skipping querying ingesters as that's when there's no overlap with the `query-ingesters-within` period: ```go // OLD CODE BELOW if a.queryIngestersWithin != 0 { // don't query ingesters if the query does not overlap with queryIngestersWithin. if !through.After(model.Now().Add(-a.queryIngestersWithin)) { // <----- should be through.Before return a.Store.Stats(ctx, userID, from, through, matchers...) } } ``` I discovered the problem while debugging querier OOMs during a boltdb-shipper -> tsdb migration and ultimately found this happened under the following circumstances: * Queries over high volumes of _recent_ data wouldn't query ingesters for index metadata * Without index metadata, we only checked storage metadata * There is a delay before we ship the index to storage, meaning we don't see it if ingesters are skipped * Calculating ideal shard factors without recent data for queries that only touch recent data _dramatically_ underestimates the desired shard factor * Queries aren't split enough and get scheduled onto too few querier replicas * They oom. We had some fun examples like a single replica trying to download 419,000 chunks/query To be clear, this is still a hypothesis, but a plausible one, especially after finding the boolean logic error this PR fixes. Instead of changing this one line, I took the opportunity to refactor this into a shared utility used by our other `GetChunkRefs` method which is already tested, ensuring the logic works as expected. I also added some more logging visibility into this code so we can understand what the difference is when querying statistics from storage vs ingesters. Finally, I added a helper to prepare our `Stats` objects to be logged which is now used in a few places.	2 years ago
Travis Patterson	5e53303cb8	run 'make doc' and commit the changes (#8142 )	2 years ago
Raphael Deem	63811f9025	Update README.md (#7799 )	2 years ago
Philipp Trulson	8edf8f9700	Helm: Use image tag for version labels in kubernetes resources (#8135 ) What this PR does / why we need it: This PR makes sure that the value of the `app.kubernetes.io/version` label in Kubernetes is the same as the image tag for Loki when set instead of always pinning it to the hardcoded `AppVersion` of the chart. Which issue(s) this PR fixes: Fixes #8077 Special notes for your reviewer: None Checklist - [x] Reviewed the [`CONTRIBUTING.md`](../CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
saurabhsadhale	c4091c83f4	operator: Fix docs for OpenShift Data Foundation storage uses bucketnames instead of bucketname (#8139 )	2 years ago
Ludovic Cleroux	6e3b62bf3e	Documentation: Add installation instructions for Istio (#4812 ) What this PR does / why we need it: Because there is very little information on how to install loki in the istio service mesh, and I spent a good deal of time figuring it out. Co-authored-by: Owen Diehl <ow.diehl@gmail.com>	2 years ago
Irina	5eba028656	Move to fork github.com/grafana/cloudflare-go (#8133 ) What this PR does / why we need it: The PR https://github.com/cloudflare/cloudflare-go/pull/743 to the upstream repo https://github.com/cloudflare/cloudflare-go was closed with the resolution: > We've spoken to the Grafana Loki team and they'll be building out an integration with Logpush so I don't think this is needed from their side anymore. I [spoke](https://raintank-corp.slack.com/archives/C9T1FLN9K/p1666293494583359) to Loki team and found out that moving to Logpush is not on the shortlist plan right now. I suggest moving to [github.com/grafana/cloudflare-go](https://github.com/grafana/cloudflare-go) fork as the main dependency to get rid of replacement directive. `02e0b3ae89/go.mod (L320)` Another point is replace directives complicate using loki as a dependency in other packages because replace directives should be moved to the upstream package as well. In general, replace was designed as a temporary solution to test code. It shouldn't be used permanently. Which issue(s) this PR fixes: Fixes https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/16722, https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/16453 Special notes for your reviewer: Checklist - [x] Reviewed the [`CONTRIBUTING.md`](../CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
dependabot[bot]	1760653e37	Bump github.com/prometheus/common from 0.38.0 to 0.39.0 (#8134 ) Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.38.0 to 0.39.0. Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2 years ago
Christophe Collot	ec33a891df	lambda-promtail: remove duplicate key in terraform config sample (#8137 ) What this PR does / why we need it: This PR removes a duplicate key in the terraform configuration sample Which issue(s) this PR fixes: None Special notes for your reviewer: This is a trivial PR	2 years ago
Callum Styan	2c2f4914f6	[jsonnet] port some common jsonnet for statefulset and ingester creation (#7039 ) The mimir team turned a lot of jsonnet deployment code/config into functions. The functions make common config across deployments/statefulsets easier, and also creation of new similar but slightly different deployments/statefulsets of exsting components simpler as well. For example, it will make zone aware ingester creation simpler. The current changeset should (as in I tested it via `tk diff`) result in no diff for our own environments. Note that this is just ingester related, there's plenty of other nice jsonnet things the mimir team is doing that we could also copy. Signed-off-by: Callum Styan <callumstyan@gmail.com> Signed-off-by: Callum Styan <callumstyan@gmail.com>	2 years ago
Nils	e4fbd3c949	Loki: Add support for Azure Workload Identity authentication (#7540 )	2 years ago
youngpablo	ce09aac46d	resolves #5950 (input header error) (#7829 ) this PR fix error while parsing logs from containers with tty: true https://pkg.go.dev/github.com/docker/docker/client#Client.ContainerLogs like in docs: >if the container is using a TTY, there is only a single stream (stdout), and data is copied directly from the container output stream, no extra multiplexing or headers. cause of it we dont need to use StdCopy and can just write to StdOut Fixes #5950 thanks for help @scripter-v Co-authored-by: Karsten Jeschkies <k@jeschkies.xyz> Co-authored-by: Karsten Jeschkies <karsten.jeschkies@grafana.com>	2 years ago
Marcus Teixeira	78c2063e0b	Docs: fix helm ssd typo (#7959 ) Fix docs about helm ssd installation. Co-authored-by: Travis Patterson <travis.patterson@grafana.com>	2 years ago
Sandeep Sukhani	dfff86f1cd	skip compacting tables that do not fit in start and end date of desired schema config (#8127 ) Before compacting tables, we look up the schema config for them. If we do not find a schema config for a table, we skip them. However, the schema lookup code was considering the start time of the schema and not the end time. This can cause the compactor to try compacting tables with the same prefix as one of the previous schemas, but the table interval falls into one of the subsequent schemas with a different config. This PR fixes the issue and simplifies the code by reusing existing schema lookup code. I have also updated test cases to verify the fix works.	2 years ago
Karsten Jeschkies	4504ed2701	Cross build Promtail for ARM with journald support. (#8131 ) This is the follow up to #8111 and adds journald support for Promatil ARM and ARM64 builds. I've tested it locally with my Raspberry Pi and it works. Fixes #1459	2 years ago
Dbzman	cd1ba1911e	Fix labels for alerts (#7886 ) This fixes wrong labels for the LokiCanaryLatency alert and introduces "cluster" as label for LokiTooManyCompactorsRunning to be able to have multiple loki instances in the same namespace. documented in `docs/sources/upgrading/_index.md`	2 years ago
Guillaume Coué	802b337c63	Update README.md (#8132 ) What this PR does / why we need it: Updates docker diagram after changes in #8019 Signed-off-by: Danny Kopping <danny.kopping@grafana.com> Co-authored-by: Danny Kopping <danny.kopping@grafana.com>	2 years ago
Jake Herbst	02e0b3ae89	Fix logentry drop to more intuitively match numeric fields (fixes #7011 ) (#7292 ) What this PR does / why we need it: 1. Makes the `drop` stage matching for numeric fields more intuitive. 2. Adds tests scenarios to confirm fix Which issue(s) this PR fixes: Fixes #7011	2 years ago
Danny Kopping	b9a9cdf2f7	Fixing test regression (#8130 ) Regression introduced by #7723 which was merged around the same time Signed-off-by: Danny Kopping <danny.kopping@grafana.com>	2 years ago
Danny Kopping	37c1ec442f	Correct template and LID (#8128 ) The extra colon causes a YAML parsing failure, see https://github.com/grafana/loki/actions/runs/3905966435/jobs/6678935989 Signed-off-by: Danny Kopping <danny.kopping@grafana.com>	2 years ago
Cyril Tovena	2861c0036f	Improve the JSON parser performance. (#7723 ) Sorry I couldn't help myself and worked a bit on the JSON parser by using another library that allows way less allocations. On top of this, the parser code is also much simpler to understand. I realize that we could possibly also intern/cache (limited obviously) extracted JSON value per key. I would do it per key because otherwise, a high cardinality key can take over the intern/cache which will make it worthless. Happy to walk someone through the idea, I think this would be a big jump too. Would be great to run and test this in our dev environment using some JSON queries before releasing it. ``` ❯ benchstat before.txt after.txt name old time/op new time/op delta _Parser/json/no_labels_hints-10 2.53µs ± 0% 2.16µs ± 2% -14.59% (p=0.008 n=5+5) _Parser/json/labels_hints-10 1.93µs ± 0% 1.47µs ± 0% -23.96% (p=0.008 n=5+5) name old alloc/op new alloc/op delta _Parser/json/no_labels_hints-10 656B ± 0% 280B ± 0% -57.32% (p=0.008 n=5+5) _Parser/json/labels_hints-10 512B ± 0% 176B ± 0% -65.62% (p=0.008 n=5+5) name old allocs/op new allocs/op delta _Parser/json/no_labels_hints-10 46.0 ± 0% 18.0 ± 0% -60.87% (p=0.008 n=5+5) _Parser/json/labels_hints-10 39.0 ± 0% 12.0 ± 0% -69.23% (p=0.008 n=5+5) ```	2 years ago
Allex	f4b6c392b3	helm: Add `appProtocol: tcp` to headless grpc ports (#7990 ) What this PR does / why we need it: This sets the `appProtocol` of the headless services of the `loki` helm chart to `tcp`. This is needed when deploying the helm chart in combination with Istio due to it's protocol selection breaking the routing between replicas of the satefulsets.	2 years ago
Alexandru Gologan	3f5f0c38d0	Helm: fix ruler config storage regression (#8071 ) While #7528 fixed an issue with null storage when using filesystem it changed the behavior of other storage configs. Fix reintroduces previous behavior where by default you get the computed `rulerStorageConfig` and appends/overlays `rulerConfig`. This enables the use of `.Values.storage` adding to `rulerConfig` only the extra parameters one would need e.g. `enable_api: true`. Co-authored-by: Travis Patterson <travis.patterson@grafana.com>	2 years ago
Kaviraj Kanagaraj	0d1144cf8f	chore(go.mod): Remove unnecessary grpc contraints from `weaveworks/common` (#8125 ) Not needed after https://github.com/weaveworks/common/pull/254 and https://github.com/weaveworks/common/pull/262 More rationale on the issue. Fixes #8085 Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>	2 years ago
Owen Diehl	c39cce74d1	Go mod tidy (#8126 ) Saw some errors on main -- this just cleans up go mod via `go mod tidy`	2 years ago
Dariusch Ochlast	5cff63dd02	helm: fix autoscaling/v2 template (#8043 ) What this PR does / why we need it: Upon installing the new 3.8.1 version of the loki helm chart my HelmRelease (flux) threw this error: ``` HelmRelease reconciliation failed: Helm upgrade failed: error validating "": error validating data: [ValidationError(HorizontalPodAutoscaler.spec.metrics[0].resource): unknown field "targetAverageUtilization" in io.k8s.api.autoscaling.v2.ResourceMetricSource, ValidationError(HorizontalPodAutoscaler.spec.metrics[0].resource): missing required field "target" in io.k8s.api.autoscaling.v2.ResourceMetricSource] ``` The error was introduced in https://github.com/grafana/loki/pull/7416	2 years ago
Aditya C S	8df5803d9a	feat(logql): Support drop labels in logql pipeline (#7975 ) This PR introduces `drop` stage in logql pipeline. Fixes #7870, Fixes #7368	2 years ago
Rutger	7a1fcab465	Promtail: Improve LabelsMap CPU performance (#7882 ) What this PR does / why we need it: The labelsMapToString function takes a relative high amount of CPU in a simple promtail pipeline. By replacing the fmt.Sprintf with a string. Builder we achieve a 50+% improvement in the function. In my local promtail installation I get about a 10% global cpu reduction. ``` name old time/op new time/op delta LabelsMapToString-8 1.10µs ± 3% 0.30µs ± 4% -72.40% (p=0.008 n=5+5) name old alloc/op new alloc/op delta LabelsMapToString-8 344B ± 0% 184B ± 0% -46.51% (p=0.008 n=5+5) name old allocs/op new allocs/op delta LabelsMapToString-8 14.0 ± 0% 6.0 ± 0% -57.14% (p=0.008 n=5+5) ``` Special notes for your reviewer: The code does get more complex, and this might be a trade-off. Considering promtail is running on many machines (ie. kubernetes nodes) I think the gain is worth it. Two alternatives: - Only replace the `lstrs = append(lstrs, fmt.Sprintf("%s=%q", l, v))` call, as it takes most of the time - Get rid of the explicit `b.Grow` calls and the tracking of size. This only adds a slight improvement Checklist - [x] Reviewed the `CONTRIBUTING.md` guide - [ ] Documentation added - [x] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` Co-authored-by: Owen Diehl <ow.diehl@gmail.com>	2 years ago
dependabot[bot]	457be16d28	Bump helm/kind-action from 1.4.0 to 1.5.0 (#7970 ) Bumps [helm/kind-action](https://github.com/helm/kind-action) from 1.4.0 to 1.5.0. Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2 years ago
tab0r	1289bcc272	update local docker-compose file to provision the Loki data source (#7869 ) What this PR does / why we need it: * auto-provisions the dockerized Loki as a datasource * [existing docs](https://github.com/grafana/loki/tree/main/production#run-locally-using-docker) tell user to "follow the [steps for configuring the datasource in Grafana](https://github.com/grafana/loki/blob/main/docs/sources/getting-started/grafana.md)", but that link is broken * and this docker-compose should be focused on getting the user up and running ASAP anyway, without requiring jumping to a different reference doc Which issue(s) this PR fixes: Fixes #<issue number> Special notes for your reviewer: Checklist - [x] Reviewed the `CONTRIBUTING.md` guide - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
Danny Kopping	2c0cc01fa1	Minor fixups to LIDs (#8124 ) Including spelling my own surname right! 🙈 Signed-off-by: Danny Kopping <danny.kopping@grafana.com>	2 years ago
Tazmaniac	e465e38382	Helm: Add missing azure check (#8113 ) In Azure storage case, storage ruler config is correctly prepared, but not included.	2 years ago
Danny Kopping	9cab63d921	Loki Improvement Documents (LIDs) (#8056 ) What this PR does / why we need it: This PR adds a _Loki Improvement Document_ process to engage contributors and the community on major changes to Loki, _before_ large amounts of work is done. The aim here is to have a lightweight documented history of our decisions which the community can view in perpetuity. Signed-off-by: Danny Kopping <danny.kopping@grafana.com>	2 years ago
Travis Patterson	b704cf986b	Remove flaky helm test (#8122 ) This test is causing tens of timeouts across all PRs in our system. Delete it to improve CI stability	2 years ago
Mohamed-Amine Bouqsimi	099bdd42aa	operator: Add API validation to Alertmanager header auth config (#8001 )	2 years ago
Travis Patterson	4a3e6f9d95	Bump go modules GitHub.com prometheus alertmanager 0.25.0 (#8100 ) This PR required some code changes: https://github.com/grafana/loki/pull/8095 We have all the information, it's just plumbed in a little different now. Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2 years ago

... 2 3 4 5 6 ...

4607 Commits (ee0f46beed12f482032649966ece7fd1df7abdb5) All Branches Search

4607 Commits (ee0f46beed12f482032649966ece7fd1df7abdb5)

All Branches