160 Commits (fb26baa5b1bd58b33a34e9c946c81b253d7610bc)

Author	SHA1	Message	Date
李国忠	fb26baa5b1	[new feature] promtail: Add config reload endoint / signal to promtail (#7247)	3 years ago
Brandon W Maister	381735d3d4	logging: Change Docker target discovery log level from Error to Info (#7312) ... **What this PR does / why we need it**: Discovering a new node is not an error, so having it send errors to dashboards is confusing. **Special notes for your reviewer**: **Checklist** - [x] Reviewed the `CONTRIBUTING.md` guide - [x] Documentation added - [ ] Tests updated - [x] `CHANGELOG.md` updated - [x] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	3 years ago
Hemanth Krishna	0e54477309	area(promtail): add -check-syntax functionality (#7363) ... Adds `-check-syntax` to promtail which will exit just by validating the config file. Fixes #6862. Signed-off-by: Hemanth Krishna <hkpdev008@gmail.com>	3 years ago
Danny Kopping	c3e92b876c	Restoring lint checks that were previously disabled (#7340) ... I removed these checks in https://github.com/grafana/loki/pull/7337 to not make https://github.com/grafana/loki/pull/7243 overly complex to review. Refactored code to fix valid lint issues, ignored the irrelevant/dangerous ones. I also removed `unused` and `unparam` as these produce low-quality results that are largely useless.	3 years ago
Danny Kopping	355175ff89	Upgrade to Go 1.19 (#7243) ... Upgrade Loki and all related components to Go 1.19.2.	3 years ago
Danny Kopping	6bf5b5d8c1	Use a line-buffered logger to deamplify write syscalls (#6954) ... We initialise a global logger in `pkg/util/log/log.go` and use it extensively throughout the Loki codebase. Every time we write a log message, a `write` syscall is invoked. Syscalls are problematic because they transition the process from userspace to kernelspace, which means: - a context-switch is incurred, which is inherently expensive ([1-2 microseconds](https://eli.thegreenplace.net/2018/measuring-context-switching-and-memory-overheads-for-linux-threads/)) - the goroutine executing the code is **blocked** - the underlying OS thread (_M_ in the go scheduler model) is **also blocked** - the goroutine has to be rescheduled once the syscall exits - the go scheduler may need to spawn additional OS threads if all are blocked in syscalls - which can also be expensive This change introduces the use of a line-buffered logger. It has a buffer of [256](https://gist.github.com/dannykopping/0704db32c0b08751d1d2494efaa734c2) entries, and once that buffer is filled it will flush to disk. However, a situation will arise in which that buffer remains somewhat empty for a period of time, so there is a periodic flush mechanism, configured to flush every 100ms. There is also a preallocated bytes slice of 10MB which is reused, to avoid excessive slice resizing & garbage collection. This does mean that we could lose up to 256 log messages in case of an ungraceful termination of the process, but this would need to be precisely timed within the 100ms flushes - in other words, the likelihood is low, and generally we shouldn't `kill -9` any Loki process.	3 years ago
Irina	d1a996afce	Added mapstructure tag to promtail configs structs (#7320) ... Added mapstructure tags to configs structs to promtail client. It is needed for [opentelemetry-collector-contrib](https://github.com/open-telemetry/opentelemetry-collector-contrib). I working on adding promtail receiver component there. Opentelemetry collector decodes configs with mapstructure	3 years ago
Dylan Guedes	f571282ffc	Tests: Improve several tests behavior (#7283) ... **What this PR does / why we need it**: Follow-up of https://github.com/grafana/loki/pull/7273 * Tune a filetarget test to remove created files to guarantee that all tailers are interrupted/fred * Call pubsub close for our GCP `pull target` * Append testName to the job names used in GCP tests. This will help us to identify which tests are struggling.	3 years ago
Dylan Guedes	2dc5a71a67	Tests: Reduce flakiness of GCPLog and integration tests (#7273) ... **What this PR does / why we need it**: - Reduce flakiness of GCPLog tests by reusing context and stopping GCP topic - Reduce flakiness of integration tests by: - using port as they're assigned - reusing context - adding timeout to calls (hence, if something get stuck, tests fail earlier)	3 years ago
Dylan Guedes	f3b72c8b59	Promtail: Change max support compressed line size to be 2MB (#7268) ... **What this PR does / why we need it**: Change Promtail compression support max line size to 2MB instead of 4096 bytes (~4KB). This however doesn't change the default buffer size. 4096 bytes means we can't ever have a buffer size bigger than ~4KB but since the default mem page size is 4096 ([source](https://unix.stackexchange.com/questions/128213/how-is-page-size-determined-in-virtual-address-space)), we end up ignoring all lines.	3 years ago
Pablo	64fe0af9dd	Expose tenant ID through relabel in push promtail targets (#7250) ... **What this PR does / why we need it**: Some Promtail targets that support pushing logs through HTTP, allow using a specific header for writing logs for multiple tenants. This log is propagated through a Promtail internal label, that is then consumed by the remote write client. If Promtail is used in a multi-tenant manner, it'd be nice to somehow be able to track how much is each tenant's share from the logs received. This PR exposes the received tenant id value through relabeling. This allows for example, keeping it as a label and exposing a metric though the `metrics` pipeline stage, which can be segregated by tenant. **Which issue(s) this PR fixes**: Related to https://github.com/grafana/cloud-onboarding/issues/2067	3 years ago
Dylan Guedes	73bea7e4fa	Promtail: Add compressed files support (#6708) ... **What this PR does / why we need it**: Adds to Promtail the ability to read compressed files. It works by: 1. Infer which compression format to use based on the file extension 2. Uncompress the file with the native `golang/compress` packages 3. Iterate over uncompressed lines and send them to Loki Its usage is the same as our current file tailing. **Which issue(s) this PR fixes**: Fixes #5956 Co-authored-by: Danny Kopping <dannykopping@gmail.com>	3 years ago
Pablo	42bfc22d23	Fix promtail `metric` stage causing failure when getting extracted metrics (#7216) ... **What this PR does / why we need it**: Promtail allows ingested log entries to be modified before pushing them to Loki with the use of pipelines. One of the available pipeline "stages" is called `metrics`, and allows extracting metrics from incoming logs. These metrics are labeled with the labels available in the processed `Entry`. There's some edge cases in which if either a entry label is invalid, or it starts with the prometheus internal label prefix, `__`, calling the promtail `/metrics` fails. One way to easily reproduce this is by having the following configuration: ```yaml pipeline_stages: - static_labels: good_label: "1" - tenant: value: "2" - metrics: loki_count: type: Counter description: "should count all entries" config: match_all: true action: inc ``` Which exposes a `promtail_custom_loki_count` metrics that counts processed log entries. In this case, the step before the `metrics` one injects an internal label `__tenant_id__` to be used by the remote write client. Since this label starts with the prometheus reserved prefix, this will make calling the `metrics` endpoint fail with an error like the following: ``` An error has occurred while serving metrics: 1 error(s) occurred: * "__tenant_id__" is not a valid label name for metric "promtail_custom_loki_count" ``` This PR attempts to fix that by, before creating the corresponding metrics, dropping invalid or internal labels. That way promtail will just use labels that are valid. **Which issue(s) this PR fixes**: Related to https://github.com/grafana/cloud-onboarding/issues/2067 **Special notes for your reviewer**: **Checklist** - [ ] Reviewed the `CONTRIBUTING.md` guide - [ ] Documentation added - [x] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	3 years ago
Eng Zer Jun	e2842c69c5	Replace deprecated `io/ioutil` with `io` and `os` packages (#7212) ... The `io/ioutil` package has been deprecated in Go 1.16 (See https://pkg.go.dev/io/ioutil). This PR replaces the existing `io/ioutil` functions with their new definitions in `io` and `os` packages. Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>	3 years ago
Jeremy Wu	161fcac646	support custom label selector in kubernetes_sd_configs (#5920) ... make promtail scrape logs of pod with specific field or label selector, so that it will watch less logs and make fewer calculations and get a better performance in some scenarios. Signed-off-by: Zhimin Wu <hoozecn@gmail.com> Co-authored-by: Karen Miller <84039272+KMiller-Grafana@users.noreply.github.com>	3 years ago
Chris Hodges	d1f42fff50	promtail: Fix issue with dropping logs when a file based SD target's labels are updated (#7016) ... <!-- Thanks for sending a pull request! Before submitting: 1. Read our CONTRIBUTING.md guide 2. Name your PR as `<Feature Area>: Describe your change`. a. Do not end the title with punctuation. It will be added in the changelog. b. Start with an imperative verb. Example: Fix the latency between System A and System B. c. Use sentence case, not title case. d. Use a complete phrase or sentence. The PR title will appear in a changelog, so help other people understand what your change will be. 3. Rebase your PR if it gets out of sync with main --> **What this PR does / why we need it**: Allows for modifying labels for a target and continuing to scrape logs afterwards. **Which issue(s) this PR fixes**: Fixes #7001 **Special notes for your reviewer**: <!-- Note about CHANGELOG entries, if a change adds: * an important feature * fixes an issue present in a previous release, * causes a change in operation that would be useful for an operator of Loki to know then please add a CHANGELOG entry. For documentation changes, build changes, simple fixes etc please skip this step. We are attempting to curate a changelog of the most relevant and important changes to be easier to ingest by end users of Loki. Note about the upgrade guide, if this changes: * default configuration values * metric names or label names * changes existing log lines such as the metrics.go query output line * configuration parameters * anything to do with any API * any other change that would require special attention or extra steps to upgrade Please document clearly what changed AND what needs to be done in the upgrade guide. --> **Checklist** - [ ] Documentation added - [x] Tests updated - [x] Is this an important fix or new feature? Add an entry in the `CHANGELOG.md`. - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	3 years ago
李国忠	a290549a59	Promtail: Add support for max stream limit (#7101) ... **What this PR does / why we need it**: Add Promtail support to a new feature/configuration named `max_stream_limit` * This new feature limits the max number of streams Promtail can materialize. The new feature is also useful to avoid OOMing Promtail **Which issue(s) this PR fixes**: Fixes #6968	3 years ago
Pablo	76c1198d58	Improvements to Promtail GCP push target (#7057) ... <!-- Thanks for sending a pull request! Before submitting: 1. Read our CONTRIBUTING.md guide 2. Name your PR as `<Feature Area>: Describe your change`. a. Do not end the title with punctuation. It will be added in the changelog. b. Start with an imperative verb. Example: Fix the latency between System A and System B. c. Use sentence case, not title case. d. Use a complete phrase or sentence. The PR title will appear in a changelog, so help other people understand what your change will be. 3. Rebase your PR if it gets out of sync with main --> **What this PR does / why we need it**: This PR includes some pending improvements to newish promtail GCP push target: - Pending low hanging optimization for replacing a regex that gets evaluated on every incoming request from GCP, for a simpler solution. [Related comments](https://github.com/grafana/loki/pull/6777#discussion_r935804383) - Some small refactors. See: [this](https://github.com/grafana/loki/pull/6777#pullrequestreview-1059064564) - Add some validations over the payload the target receives. Payload details are [here](https://cloud.google.com/pubsub/docs/push). This PR adds just validation over the log line, the incoming GCP message ID to add some traceability if needed, and the subscription name because it can be used as label. - Add `subscription` GCP payload field as label, which includes the PubSub subscription identifier. - Add `cause` label to error metrics. Since there's multiple failure point this might help debugging / notice strange behaviours. Also, by running the push target in some dev workloads, we noticed it has some labels different to the ones added in the pull target. This PR also refactors the logic to re-use the same GCP log entry parsing logic in both targets. That way the labels exposed to the user in the push target are $Labels_{pull} \cup Labels_{push}$. **Which issue(s) this PR fixes**: Related to: https://github.com/grafana/cloud-onboarding/issues/2067 **Special notes for your reviewer**: This PR is a follow up [this other one](https://github.com/grafana/loki/pull/6777). It works on some comments made after merge, and adds some changes we saw necessary upon running this target in real environments. <!-- Note about CHANGELOG entries, if a change adds: * an important feature * fixes an issue present in a previous release, * causes a change in operation that would be useful for an operator of Loki to know then please add a CHANGELOG entry. For documentation changes, build changes, simple fixes etc please skip this step. We are attempting to curate a changelog of the most relevant and important changes to be easier to ingest by end users of Loki. Note about the upgrade guide, if this changes: * default configuration values * metric names or label names * changes existing log lines such as the metrics.go query output line * configuration parameters * anything to do with any API * any other change that would require special attention or extra steps to upgrade Please document clearly what changed AND what needs to be done in the upgrade guide. --> **Checklist** - [x] Documentation added - [x] Tests updated - [ ] Is this an important fix or new feature? Add an entry in the `CHANGELOG.md`. - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` Co-authored-by: Kaviraj Kanagaraj <kavirajkanagaraj@gmail.com>	3 years ago
Trevor Whitney	c0eb73c34a	Enable build in env w/o internet or GCP creds (#7029) ... **What this PR does / why we need it**: The build is currently dependent upon you building in an environment with internet connectivity and GCP credentials. This PR fixes the few parts of our code and test that rely on these external dependencies so it can be built in an environment without internet or GCP credentials (such as when building a [nix flake](https://github.com/grafana/loki/pull/7020)) **Which issue(s) this PR fixes**: Fixes #7028	3 years ago
Callum Styan	4a21923913	update to alpine:3.6.2 (#6979) ... Updates the alpine image version we use to 3.16.2 and will also build/publish a new loki build image Signed-off-by: Callum Styan <callumstyan@gmail.com> Signed-off-by: Callum Styan <callumstyan@gmail.com>	3 years ago
Christian Simon	88e2705034	Update alpine and golang base images (#6897) ... * Upgrade base images to alpine 3.15.6 everywhere https://alpinelinux.org/posts/Alpine-3.13.12-3.14.8-3.15.6-3.16.2-released.html * Update golang images to 1.18.5	3 years ago
carlospeon	171a09b822	Add support for journal matches (only conjuntions) (#6656)	3 years ago
Kaviraj Kanagaraj	e8b44172d8	test(promtail): Fix flaky test with promtail bind port. (#6859) ... * test(promtail): Fix flaky test with promtail bind port. You cannot run promtail tests if there is already running promtail in your local. e.g: ``` $ go test -run TestPromtail ./clients/pkg/promtail/ ``` It gives you error ``` --- FAIL: TestPromtail (0.02s) promtail_test.go:112: error creating promtail listen tcp 127.0.0.1:9080: bind: address already in use FAIL FAIL github.com/grafana/loki/clients/pkg/promtail 0.043s ``` Cause for the error is, test uses static default port (the same we use for promtail normally) in tests. This is not **too** annonying if seen in isolation. But mainly annoying in two cases particularly 1. Hard to run tests parallely in general with these kind of static ports 2. These are causing some real problems in some integeration tests on GEL which starts docker-compose to run some test suites and even stopping containers won't release ports soon enough making CI fail randomly. This PR takes advantage of Go idiom of passing `port=0` to http (and also grpc) servers enforce Go's `net` package to bind some unused random ports. Making each test run choose random ports enabling easy running theses tests in parallel. NOTE: This PR also contains upgrade in `common/server` package that made this fix possible. https://github.com/weaveworks/common/pull/249 Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com> * go mod tidy Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>	3 years ago
Alexandre de Sá	6b47aab2de	promtail/client: add bot fields (#6828) ... * chore: add bot fields * Update CHANGELOG.md * chore: update cloudflare configuration section URI * docs: include BotScore and BotScoreSrc to all set of fields * Update CHANGELOG.md	3 years ago
Pablo	c9ef0621d1	Promtail: Add new target for receiving GCP PubSub Push messages (#6777)	3 years ago
Kaviraj Kanagaraj	0d99d80acd	upgrade `go:1.17.9` to `go:1.18.4` (#6726)	3 years ago
Pablo	d4cdc37682	promtail: Inject tenant ID when receiving X-Scope-OrgID in heroku target (#6695) ... * inject tenant ID header * fix import order	3 years ago
Pablo	0e28452f1f	Targets: Add Heroku HTTPS drain target (#6448)	3 years ago
Dylan Guedes	f17d3d768c	Promtail: Add text encoding conversion to file targets (#6395) ... Adds support for text encoding conversion for file targets. To use it, add `encoding: <encoding_name>` into the scrapeconfig.	3 years ago
Johan Fleury	9b980c45ed	Promtail: update certificates used for syslog’s tests (#6534) ... All the certificates now have a 20 year lifetime. This reverts commit 2fc20af9a4.	3 years ago
Ed Welch	2fc20af9a4	Promtail: disable syslog tests which have expired certs (#6520) ... * disable tests which are failing from hardcoded certs which are now expired. Signed-off-by: Edward Welch <edward.welch@grafana.com> * lint Signed-off-by: Edward Welch <edward.welch@grafana.com>	3 years ago
Tristan Colgate-McFarlane	21f69643b3	promtail: fix infinite loop in file target (fixes #5350) (#6135)	3 years ago
Jesus Vazquez	db9dbe8e1d	Bump prometheus dependency (#6403) ... * Bump prometheus dependency We had to add a replace of prometheus in go mod because thanos is importing an older version and then replacing it. * Undo textparser.New variable mismatch * modtimevfs path update * Fix labels withlabels and withoutlabels usages WithoutLabels and WithLabels methods have dissappeared. Now labels.NewBuilder has to be used. * Fix RuleManager interface for Update() Update now accepts a new param called ruleGroupPostProcessFunc which is an optional function to be executed after rule group processing. In this case I've set it to nil in the usages i've found. * NewQueryRange now accepts QueryOpts The NewQueryRange function now accepts QueryOptions so I had to update all the calls. I've set the opts to nil since we're not using them. * gofmt	3 years ago
Kaviraj Kanagaraj	01481cca0c	Promtail: Support all `cri-o` tags (multiline tags). (#6177) ... * Promtail: Support `cri-o` tags. Hacked something together that works during flight to Grafanafest. * Fix newCri test cases Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com> * Add test for real "panic" stacktrace Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com> * Add bounded size for partial lines slice Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com> * Leave the promtail config alone Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com> * PR remarks Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com> * PR remarks: Avoid discarding lines when partial lines reaches upper bound. Instead merge into single full line and print warning. Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>	3 years ago
Rutger	1794a76613	Promtail: Add metrics for journal target (#6105) ... * Add metrics for journal target There are no metrics for the journal target yet, this adds two basic ones: - Total number of lines processed - Total number of errors processing lines (with a reason) Because of the way the journal works, tailing one file with many possible process writing to it, I chose note to expose counts per unit. * Add changelog entry * Fix compilation of (unsupported) journalmanager target on windows * Extract possible errors to constants & add tests	3 years ago
Trevor Wood	23cc93862d	chore(fluentd): resolve rubocop failures (#6359) ... Signed-off-by: Trevor Wood <Trevor.G.Wood@gmail.com>	3 years ago
Shane St Savage	135f672c91	fix: allow promtail docker_sd_config to handle long log lines (#6256) ... In promtail's docker_sd_config, parsing of a container's logs would fail if any log line was over 64k bytes in length. This is because bufio.Scanner uses a 64k buffer by default. Since there doesn't appear to be a way to elegantly catch `bufio.ErrTooLong` and carry on, the parsing approach was changed to bufio.Reader which can handle lines of arbitrary length.	3 years ago
Jan-Otto Kröpke	a1e0298a57	Support tenant id from value (#6290) ... Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>	3 years ago
Trevor Wood	0470e4e7d3	feat(fluentd): allow fluentd_thread label to be configurable (#6240) ... Signed-off-by: Trevor Wood <Trevor.G.Wood@gmail.com>	3 years ago
Callum Styan	b6ac00e1a3	[Promtail] drop lines with malformed json (#6099) ... * Refactor json pipeline stage to have a Run function Signed-off-by: Callum Styan <callumstyan@gmail.com> * Allow for dropping log lines in json pipeline stage if they are not valid json strings Signed-off-by: Callum Styan <callumstyan@gmail.com> * fix linting Signed-off-by: Callum Styan <callumstyan@gmail.com> * Clean up new malformed json test. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Address some review feedback. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Refactor json pipeline stage test to use testify assert instead of t.Errorf Signed-off-by: Callum Styan <callumstyan@gmail.com> * Update changelog and docs with new drop malformed option Signed-off-by: Callum Styan <callumstyan@gmail.com> * Update CHANGELOG.md Co-authored-by: Karen Miller <84039272+KMiller-Grafana@users.noreply.github.com> * Update docs based on Karen's comments. Signed-off-by: Callum Styan <callumstyan@gmail.com> Co-authored-by: Karen Miller <84039272+KMiller-Grafana@users.noreply.github.com>	3 years ago
Christian Haudum	7fff660144	Add UDP protocol support to Promtail's syslog target (#5790) ... Until now, the syslog target in Promtail did only support TCP. This PR adds support for sending syslog messages to Promtail (via ng-syslog or rsyslog) via UDP. UPD for syslogs can be used if you prefer speed over guaranteed delivery. Signed-off-by: Christian Haudum <christian.haudum@gmail.com>	3 years ago
Paschalis Tsilias	179d741c5f	promtail: Add support for exclusion patterns in `static_config` (#5943) ... * PR base Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com> * Add CHANGELOG entry; updated documentation for new label Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com> * Follow logic from t.path in exlusion case; always handle matching Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com> * Make error message unique Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com> * Only run if t.pathExclude is set Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com> * Revert "Only run if t.pathExclude is set" This reverts commit 17abb006ce141071c4bca4b7d133bea2aa314594.	3 years ago
Alex Ferm	d7f03be212	Update libsystemd-dev from bullseye-backports for arm32 docker images, fixes (#5938) (#6012)	3 years ago
Vladyslav Diachenko	4a91fdcc7f	migrated gelfTarget to go-gelf/v2 library that contains fix for chunked messages (#5992)	3 years ago
Callum Styan	8f62334a58	[promtail] Add a log message stating that client level stream lag labels are deprecated (#5850) ... * Add a log message stating that client level stream lag labels are deprecated and will not be used. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Error on startup if a client level stream lag labels value is set. Signed-off-by: Callum Styan <callumstyan@gmail.com> * fix lint error Signed-off-by: Callum Styan <callumstyan@gmail.com>	3 years ago
Christian Simon	9d0fd3a7e3	Upgrade golang version to v1.17.9 (#5899) ... ``` git ls-files '*[Dd]ockerfile*' | grep -v ^vendor/ | xargs sed -i "s/golang:[0-9\\.]*/golang:1.17.9/g" | ag 'golang:' ```	3 years ago
thepheer	81021c920f	remove excessive underscore from `dockerLabelLogStream` (#5890)	3 years ago
Karsten Jeschkies	c9f3868287	Update dskit to v0.0.0-20220331160727-49faf69f72ca. (#5881)	3 years ago
Callum Styan	800b7c6345	[promtail] Mark promtail single client config flags and config file block as deprecated (#5842) ... * Mark promtail single client config flags and config file block as deprecated. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Update some promtail docs examples that still use `client` instead of `clients`. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Fix imports. Signed-off-by: Callum Styan <callumstyan@gmail.com> * properly format url as an array item since we changed to clients from client Signed-off-by: Callum Styan <callumstyan@gmail.com>	3 years ago
Cyril Tovena	dd7200564b	Improve kafka discovery test. (#5860) ... The `Test_TopicDiscovery` expections were wrong, we only need them to be true at some point since this is reconciliation loop. Fixes #5858 Nice catch ! Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>	3 years ago