Like Prometheus, but for logs.

prometheushacktoberfestgrafanacloudnativeloggingloki

You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Sandeep Sukhani 3e1f2fc273 caching: do not try to fill the gap in log results cache when the new query interval does not overlap the cached query interval (#9757) ... **What this PR does / why we need it**: Currently, when we find a relevant cached negative response for a logs query, we do the following: * If the cached query completely covers the new query: * return back an empty response. * else: * fill the gaps on either/both sides of the cached query. The problem with filling the gaps is that when the cached query does not overlap at all with the new query, we have to extend the query beyond what the query requests for. However, with the logs query, we have a limit on the number of lines we can send back in the response. So, this could result in the query response having logs which were not requested by the query, which then get filtered out by the [response extractor](b78d3f0552/pkg/querier/queryrange/log_result_cache.go (L299)), unexpectedly resulting in an empty response. For example, if the query was cached for start=15, end=20 and we get a `backwards` query for start=5, end=10. To fill the gap, the query would be executed for start=5, end=15. Now, if we have logs more than the query `limit` in the range 10-15, we would filter out all the data in the response extractor and send back an empty response to the user. This PR fixes the issue by doing the following changes when handling cache hit: * If the cached query completely covers the new query: * return back an empty response[_existing_]. * else if the cached query does not overlap with the new query: * do the new query as requested. * If the new query results in an empty response and has a higher interval than the cached query: * update the cache * else: * query the data for missing intervals on both/either side[_existing_] * update the cache with extended intervals if the new queries resulted in an empty response[_existing_] **Special notes for your reviewer**: We could do further improvements in the handling of queries not overlapping with cached query by selectively extending the queries based on query direction and cached query lying before/after the new query. For example, if the new query is doing `backwards` query and the `cachedQuery.End` < `newQuery.Start`, it should be okay to extend the query and do `cachedQuery.End` to `newQuery.End` to fill the cache since query would first fill the most relevant data before hitting the limits. I did not want to complicate the fix so went without implementing this approach. We can revisit later if we feel we need to improve our caching. **Checklist** - [x] Tests updated - [x] `CHANGELOG.md` updated --------- Co-authored-by: Travis Patterson <travis.patterson@grafana.com>		3 years ago
..
background.go	Adding background cache (en|de)queue counters (#9665)	3 years ago
background_extra_test.go	…
background_test.go	Querier: configurable writeback queue bytes size (#9604)	3 years ago
cache.go	Stats cache can be configured independently (#9535)	3 years ago
cache_gen.go	Add cache usage statistics (#6317)	4 years ago
cache_gen_test.go	…
cache_test.go	Add cache usage statistics (#6317)	4 years ago
embeddedcache.go	Remove groupcache (#7126)	3 years ago
fifo_cache.go	Upgrade `golangci-lint` and fix linting errors (#9601)	3 years ago
fifo_cache_test.go	Define a reason why the fifocache has evicted an item (#6335)	4 years ago
instrumented.go	[instrument] cache: add tracing instrumentation when error !=nil (#5202)	4 years ago
memcached.go	Adding more buckets to loki_memcache_request_duration_seconds histogram (#9431)	3 years ago
memcached_client.go	Remove dependency on thanos-io/thanos (#8227)	3 years ago
memcached_client_selector.go	Log when memcached servers are updated (#9426)	3 years ago
memcached_client_selector_test.go	Move to fork github.com/grafana/gomemcache (#7936)	3 years ago
memcached_client_test.go	Update vendored dskit (#8155)	3 years ago
memcached_test.go	Update vendored dskit (#8155)	3 years ago
mock.go	caching: do not try to fill the gap in log results cache when the new query interval does not overlap the cached query interval (#9757)	3 years ago
redis_cache.go	Add cache usage statistics (#6317)	4 years ago
redis_cache_test.go	Add cache usage statistics (#6317)	4 years ago
redis_client.go	Prevent redis client from incorrectly choosing cluster mode with local address (#9185)	3 years ago
redis_client_test.go	Prevent redis client from incorrectly choosing cluster mode with local address (#9185)	3 years ago
snappy.go	Add cache usage statistics (#6317)	4 years ago
stats.go	Add store & cache download statistics (#7982)	3 years ago
stop_once.go	…
tiered.go	Add cache usage statistics (#6317)	4 years ago
tiered_test.go	[optimization] cache prometheus : fix "loki_cache_request_duration_seconds_bucket" ‘status_code’ label always equals "200" (#4891)	4 years ago