Auth basic: fixed file descriptor leak on memory allocation error.

Found by Coverity (CID 1662016).
5 months ago · 093b9bbca1
parent 2a7f783bd6
commit 093b9bbca1
1 changed files with 2 additions and 1 deletions
--- a/src/http/modules/ngx_http_auth_basic_module.c
+++ b/src/http/modules/ngx_http_auth_basic_module.c
@ -253,7 +253,8 @@ ngx_http_auth_basic_handler(ngx_http_request_t *r)
        pwd.len = i - passwd;
        pwd.data = ngx_pnalloc(r->pool, pwd.len + 1);
        if (pwd.data == NULL) {
-            return NGX_HTTP_INTERNAL_SERVER_ERROR;
+            rc = NGX_HTTP_INTERNAL_SERVER_ERROR;
+            goto cleanup;
        }

        ngx_cpystrn(pwd.data, &buf[passwd], pwd.len + 1);