apitech
/
node_exporter
mirror of https://github.com/prometheus/node_exporter
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Add unit suffix to textfile collector mtime metric (#796)

Browse Source
pull/731/merge
Julius Volz 8 years ago committed by GitHub
parent a98067a294
commit 6cac74f0e0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
11 changed files with 28 additions and 28 deletions
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Show Stats Download Patch File Download Diff File
  1. 4
      collector/fixtures/e2e-output.txt
  2. 4
      collector/fixtures/e2e-ppc64le-output.txt
  3. 6
      collector/fixtures/textfile/different_metric_types.out
  4. 6
      collector/fixtures/textfile/histogram.out
  5. 6
      collector/fixtures/textfile/histogram_extra_dimension.out
  6. 6
      collector/fixtures/textfile/inconsistent_metrics.out
  7. 6
      collector/fixtures/textfile/summary.out
  8. 6
      collector/fixtures/textfile/summary_extra_dimension.out
  9. 8
      collector/fixtures/textfile/two_metric_files.out
  10. 2
      collector/textfile.go
  11. 2
      end-to-end-test.sh

4
collector/fixtures/e2e-output.txt
Unescape View File

@ -2699,8 +2699,8 @@ node_sockstat_UDP_mem_bytes 0
# HELP node_sockstat_sockets_used Number of sockets sockets in state used.
# TYPE node_sockstat_sockets_used gauge
node_sockstat_sockets_used 229
# HELP node_textfile_mtime Unixtime mtime of textfiles successfully read.
# TYPE node_textfile_mtime gauge
# HELP node_textfile_mtime_seconds Unixtime mtime of textfiles successfully read.
# TYPE node_textfile_mtime_seconds gauge
# HELP node_textfile_scrape_error 1 if there was an error opening or reading a file, 0 otherwise
# TYPE node_textfile_scrape_error gauge
node_textfile_scrape_error 0

4
collector/fixtures/e2e-ppc64le-output.txt
Unescape View File

@ -2729,8 +2729,8 @@ node_sockstat_UDP_mem_bytes 0
# HELP node_sockstat_sockets_used Number of sockets sockets in state used.
# TYPE node_sockstat_sockets_used gauge
node_sockstat_sockets_used 229
# HELP node_textfile_mtime Unixtime mtime of textfiles successfully read.
# TYPE node_textfile_mtime gauge
# HELP node_textfile_mtime_seconds Unixtime mtime of textfiles successfully read.
# TYPE node_textfile_mtime_seconds gauge
# HELP node_textfile_scrape_error 1 if there was an error opening or reading a file, 0 otherwise
# TYPE node_textfile_scrape_error gauge
node_textfile_scrape_error 0

6
collector/fixtures/textfile/different_metric_types.out
Unescape View File

@ -24,9 +24,9 @@ event_duration_seconds_total_count{baz="result_sort"} 1.427647e+06
# TYPE events_total counter
events_total{foo="bar"} 10
events_total{foo="baz"} 20
# HELP node_textfile_mtime Unixtime mtime of textfiles successfully read.
# TYPE node_textfile_mtime gauge
node_textfile_mtime{file="metrics.prom"} 1
# HELP node_textfile_mtime_seconds Unixtime mtime of textfiles successfully read.
# TYPE node_textfile_mtime_seconds gauge
node_textfile_mtime_seconds{file="metrics.prom"} 1
# HELP node_textfile_scrape_error 1 if there was an error opening or reading a file, 0 otherwise
# TYPE node_textfile_scrape_error gauge
node_textfile_scrape_error 0

6
collector/fixtures/textfile/histogram.out
Unescape View File

@ -1,6 +1,6 @@
# HELP node_textfile_mtime Unixtime mtime of textfiles successfully read.
# TYPE node_textfile_mtime gauge
node_textfile_mtime{file="metrics.prom"} 1
# HELP node_textfile_mtime_seconds Unixtime mtime of textfiles successfully read.
# TYPE node_textfile_mtime_seconds gauge
node_textfile_mtime_seconds{file="metrics.prom"} 1
# HELP node_textfile_scrape_error 1 if there was an error opening or reading a file, 0 otherwise
# TYPE node_textfile_scrape_error gauge
node_textfile_scrape_error 0

6
collector/fixtures/textfile/histogram_extra_dimension.out
Unescape View File

@ -1,6 +1,6 @@
# HELP node_textfile_mtime Unixtime mtime of textfiles successfully read.
# TYPE node_textfile_mtime gauge
node_textfile_mtime{file="metrics.prom"} 1
# HELP node_textfile_mtime_seconds Unixtime mtime of textfiles successfully read.
# TYPE node_textfile_mtime_seconds gauge
node_textfile_mtime_seconds{file="metrics.prom"} 1
# HELP node_textfile_scrape_error 1 if there was an error opening or reading a file, 0 otherwise
# TYPE node_textfile_scrape_error gauge
node_textfile_scrape_error 0

6
collector/fixtures/textfile/inconsistent_metrics.out
Unescape View File

@ -21,9 +21,9 @@ http_requests_total{baz="",code="206",foo="",handler="static",method="get"} 2
http_requests_total{baz="",code="400",foo="",handler="query_range",method="get"} 40
http_requests_total{baz="",code="503",foo="",handler="query_range",method="get"} 3
http_requests_total{baz="bar",code="200",foo="",handler="",method="get"} 93
# HELP node_textfile_mtime Unixtime mtime of textfiles successfully read.
# TYPE node_textfile_mtime gauge
node_textfile_mtime{file="metrics.prom"} 1
# HELP node_textfile_mtime_seconds Unixtime mtime of textfiles successfully read.
# TYPE node_textfile_mtime_seconds gauge
node_textfile_mtime_seconds{file="metrics.prom"} 1
# HELP node_textfile_scrape_error 1 if there was an error opening or reading a file, 0 otherwise
# TYPE node_textfile_scrape_error gauge
node_textfile_scrape_error 0

6
collector/fixtures/textfile/summary.out
Unescape View File

@ -20,9 +20,9 @@ event_duration_seconds_total{baz="result_sort",quantile="0.9"} 2.975e-06
event_duration_seconds_total{baz="result_sort",quantile="0.99"} 4.08e-06
event_duration_seconds_total_sum{baz="result_sort"} 3.4123187829998307
event_duration_seconds_total_count{baz="result_sort"} 1.427647e+06
# HELP node_textfile_mtime Unixtime mtime of textfiles successfully read.
# TYPE node_textfile_mtime gauge
node_textfile_mtime{file="metrics.prom"} 1
# HELP node_textfile_mtime_seconds Unixtime mtime of textfiles successfully read.
# TYPE node_textfile_mtime_seconds gauge
node_textfile_mtime_seconds{file="metrics.prom"} 1
# HELP node_textfile_scrape_error 1 if there was an error opening or reading a file, 0 otherwise
# TYPE node_textfile_scrape_error gauge
node_textfile_scrape_error 0

6
collector/fixtures/textfile/summary_extra_dimension.out
Unescape View File

@ -1,6 +1,6 @@
# HELP node_textfile_mtime Unixtime mtime of textfiles successfully read.
# TYPE node_textfile_mtime gauge
node_textfile_mtime{file="metrics.prom"} 1
# HELP node_textfile_mtime_seconds Unixtime mtime of textfiles successfully read.
# TYPE node_textfile_mtime_seconds gauge
node_textfile_mtime_seconds{file="metrics.prom"} 1
# HELP node_textfile_scrape_error 1 if there was an error opening or reading a file, 0 otherwise
# TYPE node_textfile_scrape_error gauge
node_textfile_scrape_error 0

8
collector/fixtures/textfile/two_metric_files.out
Unescape View File

@ -1,7 +1,7 @@
# HELP node_textfile_mtime Unixtime mtime of textfiles successfully read.
# TYPE node_textfile_mtime gauge
node_textfile_mtime{file="metrics1.prom"} 1
node_textfile_mtime{file="metrics2.prom"} 1
# HELP node_textfile_mtime_seconds Unixtime mtime of textfiles successfully read.
# TYPE node_textfile_mtime_seconds gauge
node_textfile_mtime_seconds{file="metrics1.prom"} 1
node_textfile_mtime_seconds{file="metrics2.prom"} 1
# HELP node_textfile_scrape_error 1 if there was an error opening or reading a file, 0 otherwise
# TYPE node_textfile_scrape_error gauge
node_textfile_scrape_error 0

2
collector/textfile.go
Unescape View File

@ -36,7 +36,7 @@ var (
textFileDirectory = kingpin.Flag("collector.textfile.directory", "Directory to read text files with metrics from.").Default("").String()
textFileAddOnce sync.Once
mtimeDesc = prometheus.NewDesc(
"node_textfile_mtime",
"node_textfile_mtime_seconds",
"Unixtime mtime of textfiles successfully read.",
[]string{"file"},
nil,

2
end-to-end-test.sh
Unescape View File

@ -50,7 +50,7 @@ cd "$(dirname $0)"
port="$((10000 + (RANDOM % 10000)))"
tmpdir=$(mktemp -d /tmp/node_exporter_e2e_test.XXXXXX)
skip_re="^(go_|node_exporter_build_info|node_scrape_collector_duration_seconds|process_|node_textfile_mtime)"
skip_re="^(go_|node_exporter_build_info|node_scrape_collector_duration_seconds|process_|node_textfile_mtime_seconds)"
arch="$(uname -m)"

Write Preview
Loading…
Cancel
Save