Revert "Fix race condition in Rule manager.Update() function"

This reverts commit 8b11d2cfb6. Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
6 years ago · 2051ae2e6a
parent babadf13e8
commit 2051ae2e6a
1 changed files with 2 additions and 2 deletions
--- a/rules/manager.go
+++ b/rules/manager.go
@ -921,7 +921,7 @@ func (m *Manager) Update(interval time.Duration, files []string, externalLabels
 		}

 		wg.Add(1)
-		go func(newg *Group, oldg *Group) {
+		go func(newg *Group) {
 			if ok {
 				oldg.stop()
 				newg.CopyState(oldg)
@ -934,7 +934,7 @@ func (m *Manager) Update(interval time.Duration, files []string, externalLabels
 				newg.run(m.opts.Context)
 			}()
 			wg.Done()
-		}(newg, oldg)
+		}(newg)
 	}

 	// Stop remaining old groups.