From 95d47c051235b7b4ce5dba35543a5851429d9a9d Mon Sep 17 00:00:00 2001 From: Bryan Boreham Date: Mon, 23 Jun 2025 15:04:41 +0100 Subject: [PATCH] [TESTS] Rules: remove brittle TestNewGroup It broke on different implementation of 'NewNopLogger'. Signed-off-by: Bryan Boreham --- rules/group_test.go | 9 --------- 1 file changed, 9 deletions(-) diff --git a/rules/group_test.go b/rules/group_test.go index 3911640a82..ff1ef3d6c1 100644 --- a/rules/group_test.go +++ b/rules/group_test.go @@ -17,18 +17,9 @@ import ( "testing" "time" - "github.com/prometheus/common/promslog" "github.com/stretchr/testify/require" ) -func TestNewGroup(t *testing.T) { - g := NewGroup(GroupOptions{ - File: "test-file", - Name: "test-name", - }) - require.Equal(t, promslog.NewNopLogger().With("file", "test-file", "group", "test-name"), g.logger) -} - func TestGroup_Equals(t *testing.T) { tests := map[string]struct { first *Group